Re: Current Issues with Patch Review Workflow Using git.guix-patches.cbaines.net

2023-09-04 Thread jgart
> I don't think automatically closing older issues is helpful, they still > need looking at. Or instead of closing them, put the patch into a state that is not open. Like an archived state or some other state that does not require action until someone takes ownership of the issue and resolves it

Re: Current Issues with Patch Review Workflow Using git.guix-patches.cbaines.net

2023-09-04 Thread Christopher Baines
"jgart" writes: > Hi Guixers, > > Andreas' detailed a nice workflow for reviewing patches in a previous thread*: > > ``` > git clone https://git.guix-patches.cbaines.net/guix-patches/ > git checkout issue-x > git format-patch ... > then in the development checkout of Guix: > git am ...; make

Re: Current Issues with Patch Review Workflow Using git.guix-patches.cbaines.net

2023-09-04 Thread jgart
>> Old tickets are not kept around. Hi, Oh ok, old tickets were never included instead of old tickets being deleted. I'm not familiar with this code yet. Thanks for the clarification.

Re: Current Issues with Patch Review Workflow Using git.guix-patches.cbaines.net

2023-09-04 Thread Andreas Enge
Hello jgart, Am Mon, Sep 04, 2023 at 05:48:05PM + schrieb jgart: > Old tickets are not kept around. > For example, A branch for ticket 51810* does not exist anymore. this is probably due to the fact that the git repo did not yet exist at the time. The oldest issue I see is 60286 from December

Current Issues with Patch Review Workflow Using git.guix-patches.cbaines.net

2023-09-04 Thread jgart
Hi Guixers, Andreas' detailed a nice workflow for reviewing patches in a previous thread*: ``` git clone https://git.guix-patches.cbaines.net/guix-patches/ git checkout issue-x git format-patch ... then in the development checkout of Guix: git am ...; make; ./pre-inst-env guix build ``` I no