Nikita Karetnikov nik...@karetnikov.org skribis:
Anyway, can I push this patch?
Yes, please push.
From 00188949e6c49592f6f2dc30bf21731ae142afc0 Mon Sep 17 00:00:00 2001
From: Nikita Karetnikov nik...@karetnikov.org
Date: Thu, 26 Sep 2013 02:00:06 +
Subject: [PATCH 1/3] guix package:
Nikita Karetnikov nik...@karetnikov.org skribis:
What about these patches? Should the first patch also test the
following case?
+(let ((numbers (generation-numbers profile)))
+ (if (equal? numbers '(0))
+ (exit 1)
+
. Thus it’s OK for --list-generations to not
print anything, but it must exit with 0.
Likewise, --delete-generations should do nothing and exit with 0 with
the only generation that would be deleted is Generation 0.
Does it make sense?
I was asking a different question, that is, whether we
What about these patches? Should the first patch also test the
following case?
+(let ((numbers (generation-numbers profile)))
+ (if (equal? numbers '(0))
+ (exit 1)
+ (for-each list-generation numbers
From
I think we should change ‘--list-generations’ to not output the zeroth
generation. Even though it could be present in the profile, users
shouldn’t be concerned about it.
Agreed.
Good.
I think it should be impossible to remove Generation 0 through the
command-line tools, because
I think we should change ‘--list-generations’ to not output the zeroth
generation. Even though it could be present in the profile, users
shouldn’t be concerned about it.
Agreed.
Can I push these patches to ‘master’? Should I document that the zeroth
generation is always ignored?
From
I think we should change ‘--list-generations’ to not output the zeroth
generation. Even though it could be present in the profile, users
shouldn’t be concerned about it.
Currently, ‘--delete-generations’ ignores the zeroth generation. Other
options seem even more confusing:
1. If you don’t
. Other
options seem even more confusing:
1. If you don’t have any other generations and delete it, profile
couldn’t point to anything.
2. If you delete it along with the profile, users might be confused (or
angry).
WDYT?
I think it should be impossible to remove Generation 0
