Re: New package recipe: libopus-1.1

2014-01-24 Thread Ludovic Courtès
Sree Harsha Totakura skribis: > From 23dcddebb12c619e22dac20a6181dfb77df4c876 Mon Sep 17 00:00:00 2001 > From: Sree Harsha Totakura > Date: Thu, 23 Jan 2014 19:38:39 +0100 > Subject: [PATCH] gnu: oggvorbis: Add libopus-1.1. > > * gnu/packages/oggvorbis.scm: Add libopus-1.1. Thanks, applied with

Re: Rename oggvorbis.scm to xiph-codecs.scm? (was Re: New package recipe: libopus-1.1)

2014-01-24 Thread Ludovic Courtès
Andreas Enge skribis: > On Thu, Jan 23, 2014 at 11:58:43AM -0500, Thompson, David wrote: >> On Thu, Jan 23, 2014 at 11:51 AM, Ludovic Courtès wrote: >> > Or just xiph.scm? Because not everything is a codec strictly speaking. >> I like this name best. > > Done in 54ff0b7. Please correct any erro

Re: Rename oggvorbis.scm to xiph-codecs.scm? (was Re: New package recipe: libopus-1.1)

2014-01-23 Thread Mark H Weaver
"Thompson, David" writes: > On Thu, Jan 23, 2014 at 11:51 AM, Ludovic Courtès wrote: >> Or just xiph.scm? Because not everything is a codec strictly speaking. > > I like this name best. Sure, xiph.scm sounds good to me. Mark

Re: New package recipe: libopus-1.1

2014-01-23 Thread Sree Harsha Totakura
Hi! Attached the patch with the suggested changes. Sree On 01/22/2014 11:42 PM, Ludovic Courtès wrote: > As you can see there are a bunch of conventions, but hopefully it will > be easy to adjust and won’t be too much of a burden. From 23dcddebb12c619e22dac20a6181dfb77df4c876 Mon Sep 17 00:00:00

Re: Rename oggvorbis.scm to xiph-codecs.scm? (was Re: New package recipe: libopus-1.1)

2014-01-23 Thread Andreas Enge
On Thu, Jan 23, 2014 at 11:58:43AM -0500, Thompson, David wrote: > On Thu, Jan 23, 2014 at 11:51 AM, Ludovic Courtès wrote: > > Or just xiph.scm? Because not everything is a codec strictly speaking. > I like this name best. Done in 54ff0b7. Please correct any errors you find... (As I just restar

Re: Rename oggvorbis.scm to xiph-codecs.scm? (was Re: New package recipe: libopus-1.1)

2014-01-23 Thread Thompson, David
On Thu, Jan 23, 2014 at 11:51 AM, Ludovic Courtès wrote: > Or just xiph.scm? Because not everything is a codec strictly speaking. I like this name best. - Dave

Re: Rename oggvorbis.scm to xiph-codecs.scm? (was Re: New package recipe: libopus-1.1)

2014-01-23 Thread Ludovic Courtès
Mark H Weaver skribis: > Andreas Enge writes: >> Actually, it should go into oggvorbis.scm, where we put all xiph codecs. > > I think that module should be renamed. Maybe xiph-codecs.scm ? Or just xiph.scm? Because not everything is a codec strictly speaking. Ludo’.

Rename oggvorbis.scm to xiph-codecs.scm? (was Re: New package recipe: libopus-1.1)

2014-01-23 Thread Mark H Weaver
Andreas Enge writes: > Actually, it should go into oggvorbis.scm, where we put all xiph codecs. I think that module should be renamed. Maybe xiph-codecs.scm ? Mark

Re: New package recipe: libopus-1.1

2014-01-22 Thread Ludovic Courtès
Sree Harsha Totakura skribis: > +(synopsis "Libopus - highly versatile audio codec") One last thing: please don’t repeat the package name in the synopsis (there have been exceptions to this rule but we’ll fix them over time.) As you can see there are a bunch of conventions, but hopefully it

Re: New package recipe: libopus-1.1

2014-01-22 Thread Ludovic Courtès
Andreas Enge skribis: > thanks for the patch, and congratulations for your first guix package > (which I did not try out yet, I simply assumed it worked...). Indeed, cool. :-) And thanks to the other people for the reviews! > Actually, it should go into oggvorbis.scm, where we put all xiph co

Re: New package recipe: libopus-1.1

2014-01-22 Thread Andreas Enge
Hello Sree, thanks for the patch, and congratulations for your first guix package (which I did not try out yet, I simply assumed it worked...). Actually, it should go into oggvorbis.scm, where we put all xiph codecs. Could you please do so and drop the new file, also from gnu-system.am? I am not

Re: New package recipe: libopus-1.1

2014-01-22 Thread Sree Harsha Totakura
Hi, Thank you for the feedback. Here is the new patch incorporating your suggestions. Sree On 01/22/2014 04:29 PM, Cyril Roelandt wrote: > On 01/22/2014 04:23 PM, Sree Harsha Totakura wrote: >> Hi, > > Hello, > >> >> Attached is a recipe for libopus-1.1. Please include it. >> > > Comments i

Re: New package recipe: libopus-1.1

2014-01-22 Thread Sree Harsha Totakura
Hi, Here is the patch with the suggested commit message. Sree On 01/22/2014 05:37 PM, Mark H Weaver wrote: > gnu: Add libopus. > > * gnu/packages/opus.scm: New file. > * gnu-system.am (GNU_SYSTEM_MODULES): Add it. From 18c8bb6e1064ec39982c5350e22c74562fd6ea94 Mon Sep 17 00:00:00 2001 From: Sree

Re: New package recipe: libopus-1.1

2014-01-22 Thread Mark H Weaver
Hi Sree, Sree Harsha Totakura writes: > From 8feb9cdc97f42808297ace8a73ecc8cb88a1a045 Mon Sep 17 00:00:00 2001 > From: Sree Harsha Totakura > Date: Wed, 22 Jan 2014 17:09:24 +0100 > Subject: [PATCH] new package: libopus-1.1 > > > Signed-off-by: Sree Harsha Totakura Please follow our convention

Re: New package recipe: libopus-1.1

2014-01-22 Thread Cyril Roelandt
On 01/22/2014 04:23 PM, Sree Harsha Totakura wrote: Hi, Hello, Attached is a recipe for libopus-1.1. Please include it. Comments inlined. Thank you, Sree 0001-new-package-libopus-1.1.patch From eafeaed576eccd20e108f62dc61d89d2c4be353b Mon Sep 17 00:00:00 2001 From: Sree Harsha Tot

New package recipe: libopus-1.1

2014-01-22 Thread Sree Harsha Totakura
Hi, Attached is a recipe for libopus-1.1. Please include it. Thank you, Sree From eafeaed576eccd20e108f62dc61d89d2c4be353b Mon Sep 17 00:00:00 2001 From: Sree Harsha Totakura Date: Wed, 22 Jan 2014 16:17:18 +0100 Subject: [PATCH] new package: libopus-1.1 Signed-off-by: Sree Harsha Totakura -