Andreas Enge andr...@enge.fr skribis:
On Thu, Jan 23, 2014 at 11:58:43AM -0500, Thompson, David wrote:
On Thu, Jan 23, 2014 at 11:51 AM, Ludovic Courtès l...@gnu.org wrote:
Or just xiph.scm? Because not everything is a codec strictly speaking.
I like this name best.
Done in 54ff0b7.
Sree Harsha Totakura sreehar...@totakura.in skribis:
From 23dcddebb12c619e22dac20a6181dfb77df4c876 Mon Sep 17 00:00:00 2001
From: Sree Harsha Totakura sreehar...@totakura.in
Date: Thu, 23 Jan 2014 19:38:39 +0100
Subject: [PATCH] gnu: oggvorbis: Add libopus-1.1.
* gnu/packages/oggvorbis.scm:
Mark H Weaver m...@netris.org skribis:
Andreas Enge andr...@enge.fr writes:
Actually, it should go into oggvorbis.scm, where we put all xiph codecs.
I think that module should be renamed. Maybe xiph-codecs.scm ?
Or just xiph.scm? Because not everything is a codec strictly speaking.
Ludo’.
On 01/22/2014 04:23 PM, Sree Harsha Totakura wrote:
Hi,
Hello,
Attached is a recipe for libopus-1.1. Please include it.
Comments inlined.
Thank you,
Sree
0001-new-package-libopus-1.1.patch
From eafeaed576eccd20e108f62dc61d89d2c4be353b Mon Sep 17 00:00:00 2001
From: Sree Harsha
Hi,
Here is the patch with the suggested commit message.
Sree
On 01/22/2014 05:37 PM, Mark H Weaver wrote:
gnu: Add libopus.
* gnu/packages/opus.scm: New file.
* gnu-system.am (GNU_SYSTEM_MODULES): Add it.
From 18c8bb6e1064ec39982c5350e22c74562fd6ea94 Mon Sep 17 00:00:00 2001
From: Sree
Hello Sree,
thanks for the patch, and congratulations for your first guix package
(which I did not try out yet, I simply assumed it worked...).
Actually, it should go into oggvorbis.scm, where we put all xiph codecs.
Could you please do so and drop the new file, also from gnu-system.am?
I am not
Andreas Enge andr...@enge.fr skribis:
thanks for the patch, and congratulations for your first guix package
(which I did not try out yet, I simply assumed it worked...).
Indeed, cool. :-)
And thanks to the other people for the reviews!
Actually, it should go into oggvorbis.scm, where we
Sree Harsha Totakura sreehar...@totakura.in skribis:
+(synopsis Libopus - highly versatile audio codec)
One last thing: please don’t repeat the package name in the synopsis
(there have been exceptions to this rule but we’ll fix them over time.)
As you can see there are a bunch of