Re: hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts)

2023-09-18 Thread Simon Tournier
Hi Ludo, On Mon, 18 Sept 2023 at 15:56, Ludovic Courtès wrote: > Anyhow, how about this plan: > > 1. Merge with the hard Git > dependency. Is #65866 fixing bug#63331 (Guile-GnuTLS/Git circular dependency) [1]? Does the merge of #65866 lead to close

Re: hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts)

2023-09-18 Thread Ludovic Courtès
Hello! Maxim Cournoyer skribis: > Yeah, 'git gc' is lacking from libgit2. I'm not against adding > dependency on the real 'git' CLI, but at that point, as Simon mentioned, > I see little reason to keep libgit2 around for much longer, given it > performs worst than git CLI in every aspect. I

Re: hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts)

2023-09-16 Thread Maxim Cournoyer
Hi Ludovic, Ludovic Courtès writes: > Hi! > > Maxim Cournoyer skribis: > >> So given there's no technical reasons not to use libgit2, I'd use that >> and keep the closure size down. > > For the record, that’s a 6% increase: > > $ guix size guix | tail -1 > total: 633.0 MiB > $ guix size guix

Re: hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts)

2023-09-14 Thread Simon Tournier
Hi, On Thu, 14 Sept 2023 at 18:51, Ludovic Courtès wrote: > For the record, that’s a 6% increase: > > --8<---cut here---start->8--- > $ guix size guix | tail -1 > total: 633.0 MiB > $ guix size guix git-minimal | tail -1 > total: 675.7 MiB >

Re: hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts)

2023-09-14 Thread Ludovic Courtès
Hi! Maxim Cournoyer skribis: > So given there's no technical reasons not to use libgit2, I'd use that > and keep the closure size down. For the record, that’s a 6% increase: --8<---cut here---start->8--- $ guix size guix | tail -1 total: 633.0 MiB $ guix

Re: hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts)

2023-09-14 Thread Ludovic Courtès
Hi, Josselin Poiret skribis: > My opinion is that the preferred API for Git is still the UNIX one via > plumbing commands. Anything else is trying to catch up to it, and then > we get into this conundrum that we want to do everything in Scheme, but > we're unable to do it as well as Git

Re: hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts)

2023-09-12 Thread wolf
On 2023-09-12 08:56:15 -0400, Maxim Cournoyer wrote: > Hi, > > Josselin Poiret writes: > > > Hi, > > > > Maxim Cournoyer writes: > > > >> That's no longer true, as of libgit2 v1.7.0 [0]. I already have it > >> packaged in a branch, but I need to iron out dependent breakages. > >> > >> [0]

Re: hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts)

2023-09-12 Thread Maxim Cournoyer
Hi, Josselin Poiret writes: > Hi, > > Maxim Cournoyer writes: > >> That's no longer true, as of libgit2 v1.7.0 [0]. I already have it >> packaged in a branch, but I need to iron out dependent breakages. >> >> [0] https://github.com/libgit2/libgit2/releases/tag/v1.7.0 >> >> So given there's

Re: hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts)

2023-09-12 Thread Josselin Poiret
Hi, Maxim Cournoyer writes: > That's no longer true, as of libgit2 v1.7.0 [0]. I already have it > packaged in a branch, but I need to iron out dependent breakages. > > [0] https://github.com/libgit2/libgit2/releases/tag/v1.7.0 > > So given there's no technical reasons not to use libgit2, I'd

Re: hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts)

2023-09-12 Thread Simon Tournier
Hi Vagrant, On Mon, 11 Sep 2023 at 12:35, Vagrant Cascadian wrote: > What about making git an optional dependency, and only calling out to > "git gc" if git is available in PATH? Somehow, that’s more or less the case, IIUC, --8<---cut here---start->8--- 15

Re: hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts)

2023-09-11 Thread Csepp
Vagrant Cascadian writes: > [[PGP Signed Part:Undecided]] > On 2023-09-11, Simon Tournier wrote: >> On Mon, 11 Sep 2023 at 16:23, Ludovic Courtès wrote: >>> Note that the patch series adds a hard dependency on Git. >>> This is because the existing ‘git-fetch’ code depends on Git, >>> which is

Re: hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts)

2023-09-11 Thread Vagrant Cascadian
On 2023-09-11, Simon Tournier wrote: > On Mon, 11 Sep 2023 at 16:23, Ludovic Courtès wrote: >> Note that the patch series adds a hard dependency on Git. >> This is because the existing ‘git-fetch’ code depends on Git, >> which is itself motivated by the fact that Git supports >> shallow clones

Re: hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts)

2023-09-11 Thread Maxim Cournoyer
Hi wolf, wolf writes: [...] >> Personally, I do not have a strong opinion about the Big Plan™. I note >> that the introduction of Git as a hard dependency is a slippery slope >> considering the current state of libgit2. Here, it starts with “git >> clone”, then “git gc” (unsupported by

Re: hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts)

2023-09-11 Thread Maxim Cournoyer
Hi, Simon Tournier writes: > Hi, > > On Mon, 11 Sep 2023 at 16:23, Ludovic Courtès wrote: > >> Note that the patch series adds a hard dependency on Git. >> This is because the existing ‘git-fetch’ code depends on Git, >> which is itself motivated by the fact that Git supports >> shallow clones

Re: hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts)

2023-09-11 Thread Simon Tournier
Re, On Mon, 11 Sep 2023 at 17:17, Simon Tournier wrote: > On Mon, 11 Sep 2023 at 16:23, Ludovic Courtès wrote: > >> Note that the patch series adds a hard dependency on Git. >> This is because the existing ‘git-fetch’ code depends on Git, >> which is itself motivated by the fact that Git

Re: hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts)

2023-09-11 Thread wolf
On 2023-09-11 17:17:24 +0200, Simon Tournier wrote: > Hi, > > On Mon, 11 Sep 2023 at 16:23, Ludovic Courtès wrote: > > > Note that the patch series adds a hard dependency on Git. > > This is because the existing ‘git-fetch’ code depends on Git, > > which is itself motivated by the fact that Git

hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts)

2023-09-11 Thread Simon Tournier
Hi, On Mon, 11 Sep 2023 at 16:23, Ludovic Courtès wrote: > Note that the patch series adds a hard dependency on Git. > This is because the existing ‘git-fetch’ code depends on Git, > which is itself motivated by the fact that Git supports > shallow clones and libgit2/Guile-Git doesn’t. Going