Re: [h2] Small MVMap reopen bug?

2013-10-09 Thread Brian Bray
Removing it is probably ok. I wasn't actually depending on it, I just sort of stumbled on it. On Monday, October 7, 2013 1:58:12 PM UTC-6, Thomas Mueller wrote: > > Hi, > > I think I will remove MVMap.close(). I currently don't see a reason to > support it. For read-only maps, Java garbage coll

Re: [h2] Small MVMap reopen bug?

2013-10-07 Thread Thomas Mueller
Hi, I think I will remove MVMap.close(). I currently don't see a reason to support it. For read-only maps, Java garbage collection should release the memory, and for writable maps, MVMap.close() is problematic. One possible use case is to make the map read-only, but I don't think it's a strong eno

Re: [h2] Small MVMap reopen bug?

2013-10-05 Thread Thomas Mueller
Hi, Yes, this is a bug, I will fix it. Thanks for reporting it! Regards, Thomas On Thu, Oct 3, 2013 at 1:31 AM, Brian Bray wrote: > This test throws a "Map is closed" exception (in 1.3.173) and I don't > believe it should. Looks like MVMap.openMap(...) is not checking for > "!old.isClosed()

[h2] Small MVMap reopen bug?

2013-10-02 Thread Brian Bray
This test throws a "Map is closed" exception (in 1.3.173) and I don't believe it should. Looks like MVMap.openMap(...) is not checking for "!old.isClosed()"? @Test public void testMVMapClearReOpen() { // open MVMap File f = new File(System.getProperty("java.io.tmpdir"), "cache.d