[hackers] [st] Remove strsep() call || Roberto E. Vargas Caballero

2015-03-20 Thread git
commit 288f80cb06b442ef0f55ea62bbceb3260338bf7a Author: Roberto E. Vargas Caballero Date: Fri Mar 20 06:46:59 2015 + Remove strsep() call strsep() is not a POSIX function, and it means that every system needs different defines to expose it. If the prototype of strsep is

Re: [hackers] [st] Remove strsep() call || Roberto E. Vargas Caballero

2015-03-20 Thread Truls Becken
Hi, I think the loop is simpler without the int c variable. Cheers, Truls --- st.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/st.c b/st.c index 39d3fee..9f29130 100644 --- a/st.c +++ b/st.c @@ -2272,20 +2272,16 @@ strhandle(void) { void strparse(void) { -

Re: [hackers] [st] Remove strsep() call || Roberto E. Vargas Caballero

2015-03-20 Thread Roberto E. Vargas Caballero
first your loop is wrong. See what happens with the string ";", how many fields do you have there? 2, your code will return only 1. Second, to use directly the pointer or a variable is only a style question, and don't modify the simplicity of the loop. Regards,

Re: [hackers] [st] Remove strsep() call || Roberto E. Vargas Caballero

2015-03-20 Thread Truls Becken
Ah yes, I didn't think the piggybacked "while(*p &&" part through, sorry!! The variable elimination suggestion stands, although it's just a style change like you said. -Truls

[hackers] [sbase] nl: UTF-8 support and removed the two characters limit for delimiter || Quentin Rameau

2015-03-20 Thread git
commit 9a399db38f5c71257dca2eb9668234bb0206548f Author: Quentin Rameau Date: Fri Mar 20 18:09:23 2015 +0100 nl: UTF-8 support and removed the two characters limit for delimiter diff --git a/README b/README index ac44696..f6c7fe5 100644 --- a/README +++ b/README @@ -49,7 +49,7 @@ The follow

[hackers] [sbase] Reorder variables in seq(1) || FRIGN

2015-03-20 Thread git
commit 79b2275545ca0ac2f2544eeb942fd1704729aa8c Author: FRIGN Date: Fri Mar 20 16:37:29 2015 +0100 Reorder variables in seq(1) diff --git a/seq.c b/seq.c index 9e1f87b..5a306ea 100644 --- a/seq.c +++ b/seq.c @@ -8,8 +8,8 @@ static int digitsleft(const char *d) { - char *exp;

[hackers] [sbase] Audit seq(1) || FRIGN

2015-03-20 Thread git
commit f1e865df061826182aade770cad5edc1638283bd Author: FRIGN Date: Fri Mar 20 16:04:23 2015 +0100 Audit seq(1) Mostly manpage-stuff and style-changes in the code. diff --git a/README b/README index 8033776..ac44696 100644 --- a/README +++ b/README @@ -60,7 +60,7 @@ The following

[hackers] [sbase] Update README on feature-list || FRIGN

2015-03-20 Thread git
commit 97ae78ef38f89058c22d753c9d93d32b7b44c8b8 Author: FRIGN Date: Fri Mar 20 15:17:18 2015 +0100 Update README on feature-list Add "none" to ls, as all pending flags are optional. sed is feature-complete, so I marked it like that. It needs an audit though. seq is impl

[hackers] [sbase] Audit cp() in libutil || FRIGN

2015-03-20 Thread git
commit d823ce2a0fce46428fcbffec6f93eca93479ac15 Author: FRIGN Date: Thu Mar 19 17:45:30 2015 +0100 Audit cp() in libutil 1) Rename cp_HLPflag -> cp_follow for consistency. 2) Use function-pointers for stat to clear up the code. 3) BUGFIX: TERMINATE THE RESULT BUFFER OF READ