[hackers] od: added options -b and -d; bug fix affecting size C

2015-10-02 Thread Greg Reagle
Trying again. -- "No data yet," he answered. "It is a capital mistake to theorize before you have all the evidence. It biases the judgement." by Arthur Conan Doyle via his character Sherlock Holmes >From 1050d721f389146fe8b02eb1da9ff5dd8594ef97 Mon Sep 17 00:00:00 2001 From: Greg Reagle Date

Re: [hackers] od: added options -b and -d; bug fix affecting size C

2015-10-02 Thread FRIGN
On Fri, 2 Oct 2015 03:07:00 -0400 Greg Reagle wrote: Hey Greg, > Trying again. keep in mind that these flags are XSI-extensions, which we generally don't include in sbase. Let's discuss this on IRC, given the code-changes are not that drastic. Cheers FRIGN -- FRIGN

Re: [hackers] od: added options -b and -d; bug fix affecting size C

2015-10-02 Thread Greg Reagle
On 10/02/2015 03:11 AM, FRIGN wrote: On Fri, 2 Oct 2015 03:07:00 -0400 Greg Reagle wrote: Hey Greg, Trying again. keep in mind that these flags are XSI-extensions, which we generally don't include in sbase. Let's discuss this on IRC, given the code-changes are not that drastic. Cheers FRI

Re: [hackers] od: added options -b and -d; bug fix affecting size C

2015-10-02 Thread FRIGN
On Fri, 2 Oct 2015 03:28:34 -0400 Greg Reagle wrote: Hey Greg, > I am not inclined to join in the IRC because of the large time difference. > It > is 3:30 AM here and I am awake only because I have insomnia and I'll be back > in > bed soon. How about discussing it in d...@suckless.org? Or

Re: [hackers] od: added options -b and -d; bug fix affecting size C

2015-10-02 Thread Dimitris Papastamos
On Fri, Oct 02, 2015 at 09:44:37AM +0200, FRIGN wrote: > On Fri, 2 Oct 2015 03:28:34 -0400 > Greg Reagle wrote: > > Hey Greg, > > > I am not inclined to join in the IRC because of the large time difference. > > It > > is 3:30 AM here and I am awake only because I have insomnia and I'll be >

Re: [hackers] od: added options -b and -d; bug fix affecting size C

2015-10-02 Thread Dimitris Papastamos
On Fri, Oct 02, 2015 at 09:57:17AM +0100, Dimitris Papastamos wrote: > On Fri, Oct 02, 2015 at 09:44:37AM +0200, FRIGN wrote: > > On Fri, 2 Oct 2015 03:28:34 -0400 > > Greg Reagle wrote: > > > > Hey Greg, > > > > > I am not inclined to join in the IRC because of the large time > > > difference.

Re: [hackers] od: added support for different size values

2015-10-02 Thread FRIGN
On Thu, 1 Oct 2015 14:10:39 -0400 Greg Reagle wrote: Hey Greg, > See attached. I honestly do not like this patch. This will make it very difficult to add variable integer lengths later on. What I can think of is approaching this issue by emalloc'ing (BUFSIZ * size) bytes and use the fact that r

[hackers] sbase: od: bugfix: "\v" was omitted from output of type 'c'

2015-10-02 Thread Greg Reagle
This is relative to master >From 6a836ec2bf1f46dce7d129a0ea7991710494ca12 Mon Sep 17 00:00:00 2001 From: Greg Reagle Date: Fri, 2 Oct 2015 09:29:38 -0400 Subject: [PATCH] od: bugfix: "\v" was omitted from output of type 'c' --- od.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Re: [hackers] sbase: od: bugfix: "\v" was omitted from output of type 'c'

2015-10-02 Thread FRIGN
On Fri, 2 Oct 2015 09:32:01 -0400 Greg Reagle wrote: Hey Greg, > This is relative to master ah yeah, good find! You left in the double \b though. I made a custom commit, crediting you of course, which fixes the bug without duplicates. Cheers FRIGN -- FRIGN

[hackers] [sbase] Match \v as escaped character || FRIGN

2015-10-02 Thread git
commit ea986ea50489969a0c4201a0c4e56efeef214914 Author: FRIGN AuthorDate: Fri Oct 2 15:43:17 2015 +0200 Commit: sin CommitDate: Fri Oct 2 14:48:21 2015 +0100 Match \v as escaped character Thanks Greg for noticing this! diff --git a/od.c b/od.c index 9521605..31f8179 100644

[hackers] sbase: od: properly concatenate multiple file arguments

2015-10-02 Thread Greg Reagle
Relative to master. >From 475f7b2f33e8e4a4b9ec06a455a1e970f21e99b8 Mon Sep 17 00:00:00 2001 From: Greg Reagle Date: Fri, 2 Oct 2015 10:26:04 -0400 Subject: [PATCH] od: properly concatenate multiple file arguments --- od.c | 22 -- 1 file changed, 12 insertions(+), 10 deleti

Re: [hackers] sbase: od: properly concatenate multiple file arguments

2015-10-02 Thread FRIGN
On Fri, 2 Oct 2015 10:40:12 -0400 Greg Reagle wrote: > Relative to master. Better rename it to "lastfile". Then it's clearer ;) Also: - off_t addr; + static off_t addr = 0; please just keep the initialization inside the for-loop. It's a slightly better style than setting the variab

Re: [hackers] sbase: od: properly concatenate multiple file arguments

2015-10-02 Thread Greg Reagle
On 10/02/2015 11:03 AM, FRIGN wrote: Also: - off_t addr; + static off_t addr = 0; please just keep the initialization inside the for-loop. It's a slightly better style than setting the variable directly at the declaration block. But I don't want it initialized every time the for lo

Re: [hackers] sbase: od: properly concatenate multiple file arguments

2015-10-02 Thread FRIGN
On Fri, 2 Oct 2015 11:16:24 -0400 Greg Reagle wrote: > But I don't want it initialized every time the for loop is entered. > That's why I made it static. It needs to preserve its value between calls. Ah yeah, of course. Sorry, I overlooked that. Let's focus one one single thing first, or you

Re: [hackers] sbase: od: properly concatenate multiple file arguments

2015-10-02 Thread Greg Reagle
On 10/02/2015 11:35 AM, FRIGN wrote: On Fri, 2 Oct 2015 11:16:24 -0400 Greg Reagle wrote: But I don't want it initialized every time the for loop is entered. That's why I made it static. It needs to preserve its value between calls. Ah yeah, of course. Sorry, I overlooked that. No problem

[hackers] [dvtm] Command keys in status bar patch

2015-10-02 Thread Ross Mohn
The attached patch is to display command keypresses in the status bar while a multiple keypress command is being entered. Almost all commands in dvtm begin with MOD, so require multiple keypresses. Command keys are displayed as they are pressed, and appear between the layout symbol and the status t

Re: [hackers] [dvtm] Command keys in status bar patch

2015-10-02 Thread Greg Reagle
I like it. I haven't reviewed the code, but I compiled it and am using it. -- "No data yet," he answered. "It is a capital mistake to theorize before you have all the evidence. It biases the judgement." by Arthur Conan Doyle via his character Sherlock Holmes

[hackers] [dmenu] paste fix

2015-10-02 Thread shua lloret
attached is a small patch to enable pasting from clipboard, as well as primary. It seems like there was already code in there to allow this, but since there was never any case to match the upper case 'Y', that inline if would always evaluate to false. -Joshua Lloret diff --git a/dmenu.c b/dmenu.c