[hackers] [sxiv] Add build options for optional dependencies || Vlad Glagolev

2016-12-28 Thread git
commit 22436f747d05e99d17bfc05a9d2892cc2ba579af Author: Vlad Glagolev AuthorDate: Mon Dec 26 19:20:59 2016 -0500 Commit: Vlad Glagolev CommitDate: Mon Dec 26 19:20:59 2016 -0500 Add build options for optional dependencies diff --git a/Makefile b/Makefile index 9caa9ca..b4d4f75 10064

[hackers] [sxiv] Fix unused-variable warnings in conditionally compiled code || Bert Münnich

2016-12-28 Thread git
3ec9ccf..3d7834e 100644 --- a/Makefile +++ b/Makefile @@ -1,4 +1,4 @@ -VERSION := git-20161201 +VERSION := git-20161228 PREFIX:= /usr/local MANPREFIX := $(PREFIX)/share/man diff --git a/thumbs.c b/thumbs.c index 43bb50c..4f6c181 100644 --- a/thumbs.c +++ b/thumbs.c @@ -232,11 +232,9

[hackers] [sbase] ls: print filenames on the fly rather than in a buffer || Quentin Rameau

2016-12-28 Thread git
commit 441f73a518f0fead0a541195a50a7dd71db4fcfe Author: Quentin Rameau AuthorDate: Thu Oct 6 11:16:32 2016 +0200 Commit: Evan Gates CommitDate: Wed Dec 28 12:23:03 2016 -0800 ls: print filenames on the fly rather than in a buffer diff --git a/ls.c b/ls.c index eeac64c..5080c8f 10064

Re: [hackers] [sbase] ls: print filenames on the fly rather than in a buffer

2016-12-28 Thread Evan Gates
Thanks. Changed to const as discussed on IRC and applied.

Re: [hackers] [sbase] ls: print filenames on the fly rather than in a buffer

2016-12-28 Thread Quentin Rameau
> Thanks. Changed to const as discussed on IRC and applied. Thank you!

Re: [hackers] [sbase][Patch] date: add date/time setting capability

2016-12-28 Thread John Vogel
On Tue, 27 Dec 2016 17:34:02 -0800 Michael Forney wrote: > One suggestion I can think of, since the date format is simple and > uses fixed sizes, it to just parse into struct tm manually rather than > restructuring the date string into a new buffer with spaces. > > For example (untested): > stat

Re: [hackers] [sbase][Patch] date: add date/time setting capability

2016-12-28 Thread Michael Forney
On 12/28/16, John Vogel wrote: > Thanks for the help, Michael. I made a couple adjustments to > account for tm_year needing to be 'years since 1900'. Tests > fine here. Cool. Thanks for the new patch. I just have a few style nits. > -- > date.1 | 46 -

Re: [hackers] [sbase][Patch] date: add date/time setting capability

2016-12-28 Thread John Vogel
On Wed, 28 Dec 2016 17:42:39 -0800 Michael Forney wrote: > Cool. Thanks for the new patch. I just have a few style nits. > > eprintf("usage: %s [-u] [-d time] [+format]\n", argv0); > > Let's update this usage message. Oops, I think I missed bringing that forward from my original patch. >

Re: [hackers] [sbase][Patch] date: add date/time setting capability

2016-12-28 Thread Evan Gates
On Dec 28, 2016 19:09, "John Vogel" wrote: On Wed, 28 Dec 2016 17:42:39 -0800 Michael Forney wrote: > Apart from these nits, this looks good to me. > Your help is greatly appreciated, thank you. Revised patch below. For future reference, could I request use of scissors for this? Git am[0] h

Re: [hackers] [sbase][Patch] date: add date/time setting capability

2016-12-28 Thread John Vogel
On Wed, 28 Dec 2016 20:01:38 -0800 Evan Gates wrote: > For future reference, could I request use of scissors for this? Git am[0] > has a feature to cut off everything above a line containing only 8< (looks > like scissors) and dashes. e.g. > > 8<8< > > Keeping conversation above th

Re: [hackers] [sbase][Patch] date: add date/time setting capability

2016-12-28 Thread Michael Forney
On 12/28/16, John Vogel wrote: > + t = time(NULL); > + if (t == (time_t)-1) > + eprintf("time failed: %s\n", strerror(errno)); eprintf will print the error message and a newline if the format string ends in ':'. So you can just do `eprintf("time:")`, which seems to be the con