On Sun, May 7, 2017 at 8:28 PM, Quentin Rameau wrote:
> I'd prefer to check against sel rather than nclients, as it's already
> done throughout the rest of the code.
>
> I'll apply your patch with those changes if that's ok with you.
Sounds good to me.
Hi Caleb,
good catch and thanks for the patch!
> + if (nclients == 0)
> + return;
> +
I'd prefer to check against sel rather than nclients, as it's already
done throughout the rest of the code.
I'll apply your patch with those changes if that's ok with you.
---
tabbed.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tabbed.c b/tabbed.c
index 6321575..23c3b47 100644
--- a/tabbed.c
+++ b/tabbed.c
@@ -502,6 +502,9 @@ focusurgent(const Arg *arg)
{
int c;
+ if (nclients == 0)
+ return;
+
for (c = (sel + 1)
Heyho
On Sun, May 07, 2017 at 01:54:42PM +0200, Hiltjo Posthuma wrote:
> I think there are some cases where libutil/cp.c can leak file descriptors.
> It is a warning case, but the descriptors are not closed.
>
> I think only `mv` is affected.
>
> Patch below:
>
>
> From af392d1a764d7420c7b05bb
commit 4df594b3f48679f594e6f738981cb3baca8a42d9
Author: Mattias Andrée
AuthorDate: Sun May 7 16:11:31 2017 +0200
Commit: Mattias Andrée
CommitDate: Sun May 7 16:11:31 2017 +0200
Add support for floats
Signed-off-by: Mattias Andrée
diff --git a/README b/README
index 1437
commit 878849c465604d90d236b3c8766bf75a4b6836d2
Author: Mattias Andrée
AuthorDate: Sun May 7 16:48:25 2017 +0200
Commit: Mattias Andrée
CommitDate: Sun May 7 17:10:45 2017 +0200
Add blind-convert
Signed-off-by: Mattias Andrée
diff --git a/Makefile b/Makefile
index 3bdd7
Hey,
I think there are some cases where libutil/cp.c can leak file descriptors.
It is a warning case, but the descriptors are not closed.
I think only `mv` is affected.
Patch below:
>From af392d1a764d7420c7b05bb9e13d7766a5979894 Mon Sep 17 00:00:00 2001
From: Hiltjo Posthuma
Date: Sun, 7 May
