Re: [hackers] [sbase] [PATCH] ls: allow listing contents of directories with +r-x

On Fri, Oct 20, 2017 at 01:28:30PM -0700, Michael Forney wrote: > Hi David, Hi Michael > > Can you explain the reasoning behind this? Is this behavior > standardized, or consistent with other ls(1) implementations? > The purpose for this behaviour was to allow stat to fail when it is used to f

Re: [hackers] [sbase] [PATCH] which: absolute path not handled

On 2017-10-11, Pieter Kockx wrote: > I used fstatat(AT_FDCWD, ...) instead of stat to deal with the case of > relative paths. > I generalized the error message to "external command": > "external" to differentiate from builtin shell commands > "command" since which essentially tries to mimic a typi

Re: [hackers] [sbase][PATCH] tr gets stuck in infinite loop

On 2017-10-05, Laslo Hunhold wrote: > I checked Pieter's fix and it is correct. You can merge it, as it does > indeed fix the problem. Thanks for reviewing, Laslo. I applied the patch.

[hackers] [sbase] which: handle relative/absolute pathnames || Pieter Kockx

commit 5b66e55a83fd9b7bceabbc043e50f77cfe048c35 Author: Pieter Kockx AuthorDate: Wed Oct 11 03:12:31 2017 +0200 Commit: Michael Forney CommitDate: Sat Oct 21 12:44:09 2017 -0700 which: handle relative/absolute pathnames diff --git a/which.c b/which.c index ce312ae..dfc1551 100644 --

[hackers] [sbase] which: Minor simplification || Michael Forney

commit 38cc01b8874900eab684d70847b8ca3a3e580a0f Author: Michael Forney AuthorDate: Fri Oct 20 22:26:30 2017 -0700 Commit: Michael Forney CommitDate: Sat Oct 21 12:44:09 2017 -0700 which: Minor simplification diff --git a/which.c b/which.c index 1e64452..cc93361 100644 --- a/which.c

[hackers] [sbase] which: Don't look for paths with slashes in $PATH || Michael Forney

commit 3b604b179c501257b50baadbc8700895a66dc876 Author: Michael Forney AuthorDate: Fri Oct 20 12:31:27 2017 -0700 Commit: Michael Forney CommitDate: Sat Oct 21 12:44:09 2017 -0700 which: Don't look for paths with slashes in $PATH diff --git a/which.c b/which.c index e47aa63..1e64452

[hackers] [sbase] which: fix whitespace || Pieter Kockx

commit d15f49e71539eca632e9c27c78a7f8582879c060 Author: Pieter Kockx AuthorDate: Thu Oct 12 00:17:26 2017 +0200 Commit: Michael Forney CommitDate: Sat Oct 21 12:44:09 2017 -0700 which: fix whitespace diff --git a/which.c b/which.c index 1975710..ce312ae 100644 --- a/which.c +++ b/wh

[hackers] [sbase] tr: Fix infinite loop || Pieter Kockx

commit 6eec2eb3b48870435c9d729e8cf6dac44e2c3744 Author: Pieter Kockx AuthorDate: Wed Oct 4 02:25:41 2017 +0200 Commit: Michael Forney CommitDate: Sat Oct 21 12:44:09 2017 -0700 tr: Fix infinite loop When `makeset` got a string containing square brackets followed by at le

[hackers] [sbase] which: Move executable check to helper function || Michael Forney

commit 44265b29ce2da27a525c72e3e9b48f3233535ec1 Author: Michael Forney AuthorDate: Fri Oct 20 12:30:20 2017 -0700 Commit: Michael Forney CommitDate: Sat Oct 21 12:44:09 2017 -0700 which: Move executable check to helper function diff --git a/which.c b/which.c index dfc1551..e47aa63 1

Re: [hackers] [sbase] [PATCH] ls: allow listing contents of directories with +r-x

On Sat, 21 Oct 2017 14:17:25 +0100 Richard Ipsum wrote: Hey Richard, > Please correct me if I'm wrong but I'm given to understand that > PATH_MAX is not a safe value to use here.[1] > > [1]: > http://insanecoding.blogspot.co.uk/2007/11/pathmax-simply-isnt.html yeah you're right, but the altern

Re: [hackers] [sbase] [PATCH] ls: allow listing contents of directories with +r-x

On Tue, Oct 17, 2017 at 10:27:44PM +1300, David Phillips wrote: > chdir()ing into a directory with +r-x fails, so we should manually use the > directory name as a prefix rather than chdir()ing into it. > > Also adds new parameters to mkent for the prefix, and for dictating whether > or not a permi