Re: [hackers] [sbase][PATCH v2] Add tests for some utilities

2018-08-03 Thread Silvan Jegen
Hi Roberto On Fri, Aug 3, 2018 at 8:32 AM, Roberto E. Vargas Caballero wrote: > On Wed, Aug 01, 2018 at 04:36:35PM +0200, Silvan Jegen wrote: >> I definitely think we should have unit tests for sbase (and other >> projects?) as soon as possible. What concerns me with your approach is >> that we h

Re: [hackers] [sbase][PATCH v2] Add tests for some utilities

2018-08-03 Thread Dimitris Papastamos
On Fri, Aug 03, 2018 at 11:36:10AM +0200, Silvan Jegen wrote: > Hi Roberto > > On Fri, Aug 3, 2018 at 8:37 AM, Roberto E. Vargas Caballero > wrote: > > Hi, > > > > On Wed, Aug 01, 2018 at 09:16:26PM +0200, Silvan Jegen wrote: > >> > * `echo` is unportable and `printf` should be used instead. > >>

Re: [hackers] [sbase][PATCH v2] Add tests for some utilities

2018-08-03 Thread Silvan Jegen
Hi Roberto On Fri, Aug 3, 2018 at 8:37 AM, Roberto E. Vargas Caballero wrote: > Hi, > > On Wed, Aug 01, 2018 at 09:16:26PM +0200, Silvan Jegen wrote: >> > * `echo` is unportable and `printf` should be used instead. >> >> Didn't know that echo was not portable. Thought it was just a builtin >> tha