Re: [hackers] [sbase] [PATCH] *sum: Ignore -b and -t flags

2020-01-02 Thread Michael Forney
On 2020-01-02, Laslo Hunhold wrote: > I would print something on stderr. POSIX is ignored often enough and a > ton of scripts are using the cancerous GNU extensions and other > extensions. If we just "ignore" them, there is no learning effect or > push for change for script writers, so maybe we

Re: [hackers] [sbase] [PATCH] *sum: Ignore -b and -t flags

2020-01-02 Thread Michael Forney
On 2020-01-02, Quentin Rameau wrote: > I agree in that silently ignoring commands from the user is bad, as it > breaks expectations. Well, in this case ignoring them is a valid implementation, since on POSIX there is no distinction between opening a file as text or binary mode. So it will return

[hackers] Unsubscribe

2020-01-02 Thread Abdullah
unsubscribe signature.asc Description: PGP signature

Re: [hackers] [sbase] [PATCH] *sum: Ignore -b and -t flags

2020-01-02 Thread Quentin Rameau
Hi Laslo, > > These tools are not standardized, but these flags are supported in all > > implementations I'm aware of (coreutils, busybox), and are > > occasionally used in scripts. > > > > These flags are only meaningful on operating systems which > > differentiate between text and binary

Re: [hackers] [sbase] [PATCH] *sum: Ignore -b and -t flags

2020-01-02 Thread Laslo Hunhold
On Wed, 1 Jan 2020 22:04:47 -0800 Michael Forney wrote: Dear Michael, > These tools are not standardized, but these flags are supported in all > implementations I'm aware of (coreutils, busybox), and are > occasionally used in scripts. > > These flags are only meaningful on operating systems

Re: [hackers] [PATCH][sbase] sort: Don't do top-level sort when -c is used with -k

2020-01-02 Thread Richard Ipsum
On Wed, Jan 01, 2020 at 09:39:18PM -0800, Michael Forney wrote: > On 2020-01-01, Richard Ipsum wrote: [snip] > > I think the following diff should cover those cases as well: > > diff --git a/sort.c b/sort.c > index a51997f..fbb1abf 100644 > --- a/sort.c > +++ b/sort.c > @@ -385,7 +385,8 @@

Re: [hackers] [sbase] ed: Use reallocarray || Michael Forney

2020-01-02 Thread Hiltjo Posthuma
On Thu, Jan 02, 2020 at 08:28:40AM +, k0ga wrote: > Hi, > > > On Tue, Dec 31, 2019 at 10:47:28PM +0100, g...@suckless.org wrote: > > diff --git a/ed.c b/ed.c > > index b844e86..e998e81 100644 > > --- a/ed.c > > +++ b/ed.c > > @@ -204,7 +204,7 @@ makeline(char *s, int *off) > > if

[hackers] [dmenu] [PATCH] Fix GCC warning about using '*' in boolean context

2020-01-02 Thread Samee Zahur
Tested on gcc --version: gcc (Ubuntu 9.2.1-9ubuntu2) 9.2.1 20191008 Was getting the following warning: dmenu.c: In function ‘setup’: dmenu.c:24:30: warning: ‘*’ in boolean context, suggest ‘&&’ instead [-Wint-in-bool-context] [...] dmenu.c:637:9: note: in expansion of macro ‘INTERSECT’

Re: [hackers] [sbase] ed: Use reallocarray || Michael Forney

2020-01-02 Thread k0ga
Hi, On Tue, Dec 31, 2019 at 10:47:28PM +0100, g...@suckless.org wrote: > diff --git a/ed.c b/ed.c > index b844e86..e998e81 100644 > --- a/ed.c > +++ b/ed.c > @@ -204,7 +204,7 @@ makeline(char *s, int *off) > if (lastidx >= idxsize) { > lp = NULL; > if (idxsize