[hackers] [st][PATCH 2/3] Reuse deltatime to reduce calculation

2020-03-18 Thread Ivan Tham
The deltatime variable is not used later so it can be reused for calculations. --- x.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/x.c b/x.c index 03f397f..0d9f48f 100644 --- a/x.c +++ b/x.c @@ -1936,16 +1936,11 @@ run(void) xev--;

[hackers] [st][PATCH 1/3] Rearrange run with fast exit

2020-03-18 Thread Ivan Tham
Quickly swap out of loop to reduce indentation. --- x.c | 55 +++ 1 file changed, 27 insertions(+), 28 deletions(-) diff --git a/x.c b/x.c index 48a6676..03f397f 100644 --- a/x.c +++ b/x.c @@ -1919,37 +1919,36 @@ run(void)

[hackers] [st][PATCH 3/3] Assign dodraw at the end of block

2020-03-18 Thread Ivan Tham
Keep congruency with the previous block. --- x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x.c b/x.c index 0d9f48f..01fd62a 100644 --- a/x.c +++ b/x.c @@ -1915,8 +1915,8 @@ run(void) } deltatime = TIMEDIFF(now, last); if (de

Re: [hackers] [st][PATCH] Rearrange x run with fast exit

2020-03-18 Thread Ivan Tham
On Wed, Mar 18, 2020 at 02:10:36PM +0100, Quentin Rameau wrote: >> Quickly swap out of loop to reduce indentation needed. >> Reuse deltatime variable to reuse calculation. > >Don't be afraid to separate unrelated modifications into separate >commits! > On Wed, Mar 18, 2020 at 09:41:14PM +0100, Que

Re: [hackers] [st][PATCH] Rearrange x run with fast exit

2020-03-18 Thread Quentin Rameau
> I separate unrelated modifications into unrelated commits but this is > still related, I think it also belongs under reorderings. That was the polite way of saying “They're unrelated, separate them in two commits”, apparently polite messages don't convey the meaning. > On Wed, Mar 18, 2020 at 0

Re: [hackers] [st][PATCH] Rearrange x run with fast exit

2020-03-18 Thread Ivan Tham
I separate unrelated modifications into unrelated commits but this is still related, I think it also belongs under reorderings. On Wed, Mar 18, 2020 at 02:10:36PM +0100, Quentin Rameau wrote: Quickly swap out of loop to reduce indentation needed. Reuse deltatime variable to reuse calculation.

Re: [hackers] [st][PATCH] Rearrange x run with fast exit

2020-03-18 Thread Quentin Rameau
> Quickly swap out of loop to reduce indentation needed. > Reuse deltatime variable to reuse calculation. Don't be afraid to separate unrelated modifications into separate commits!