Re: [hackers] [quark][PATCH] Don't erase response on http_send_error_response

2020-10-25 Thread Laslo Hunhold
On Sat, 24 Oct 2020 16:19:13 + José Miguel Sánchez García wrote: Dear José, thanks for taking your time reading the code and reporting this! > The comment before the offending line indicated it was intended to > only erase the fields, but it erased the whole response. It was most > likely a

Re: [hackers] [quark][PATCH] Don't erase response on http_send_error_response

2020-10-25 Thread José Miguel Sánchez García
On 10/25/2020 8:39 AM, Laslo Hunhold wrote: Dear Laslo, No, this is supposed to be like this. I agree that the comment is a bit misleading, but http_parse_header() really builds a request from scratch and first sets it all to zero. With "fields" I'm referring to the struct fields in request, an

Re: [hackers] [quark] Thoughts on CGI and authentication?

2020-10-25 Thread Platon Ryzhikov
On Thu, 22 Oct 2020 20:52:27 +0200 José Miguel Sánchez García wrote: > Hello, > > I'm currently serving my static webpage with quark. I want to add some > CGI, but the opinion here about CGI support in the server is pretty > low. I'm trying to update the basecgi patch, but the latest changes > a