[hackers] [PATCH svkbd 2/4] Added a util function estrdup() to check all memory allocations

2021-03-27 Thread Maarten van Gompel
--- svkbd.c | 61 + 1 file changed, 35 insertions(+), 26 deletions(-) diff --git a/svkbd.c b/svkbd.c index 2bc6d17..0390e13 100644 --- a/svkbd.c +++ b/svkbd.c @@ -11,6 +11,7 @@ #include #include #include +#include #include

[hackers] [PATCH svkbd 4/4] Various indentation fixes for a more consistent style

2021-03-27 Thread Maarten van Gompel
--- layout.en.h |7 +- layout.mobile-intl.h | 1047 - layout.mobile-plain.h | 142 +++--- svkbd.c | 45 +- 4 files changed, 619 insertions(+), 622 deletions(-) diff --git a/layout.en.h b/layout.en.h index c39698c..957a251

[hackers] [PATCH svkbd 3/4] ternary operator was used in the wrong order

2021-03-27 Thread Maarten van Gompel
--- svkbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/svkbd.c b/svkbd.c index 0390e13..16072f3 100644 --- a/svkbd.c +++ b/svkbd.c @@ -504,7 +504,7 @@ printkey(Key *k, KeySym mod) { XKeyPressedEvent event; event.type = KeyPress; event.display =

[hackers] [PATCH svkbd 1/4] removed debugging flag

2021-03-27 Thread Maarten van Gompel
This patch series is to be applied on top of the 24 I already sent and addressed the feedback received thus-far. --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 7890619..82057d3 100644 --- a/Makefile +++ b/Makefile @@ -27,12 +27,12

Re: [hackers] [svkbd] [merge request] various patches for svkbd

2021-03-27 Thread Maarten van Gompel
Hi Hiltjo, > They arrived properly. I've read most of the patches. It's a bulk of patches > so please give me some time to review it. Sure, no problem! > Some quick notes (will write it more detailed later): Thanks, I already picked these up, I'll submit 4 new patches that address these (on

Re: [hackers] [svkbd] [merge request] various patches for svkbd

2021-03-27 Thread Hiltjo Posthuma
On Sat, Mar 27, 2021 at 02:03:05PM +0100, Maarten van Gompel wrote: > On 21-03-19 09:23, Maarten van Gompel wrote: > > > Thanks for the work. > > > > > > I've reviewed the patches. In general it looks good, but I've found a few > > > issues. Can you resend them to the mailinglist, then me (and

Re: [hackers] [svkbd] [merge request] various patches for svkbd

2021-03-27 Thread Laslo Hunhold
On Sat, 27 Mar 2021 14:03:05 +0100 Maarten van Gompel wrote: Dear Maarten, > I wonder if the svkbd patches I submitted last week arrived properly > and if you have the opportunity to look at them soon? > > (I only see 2 of the 24(!) patches in the mailing list archives, there > may be some

Re: [hackers] [svkbd] [merge request] various patches for svkbd

2021-03-27 Thread Maarten van Gompel
On 21-03-19 09:23, Maarten van Gompel wrote: > > Thanks for the work. > > > > I've reviewed the patches. In general it looks good, but I've found a few > > issues. Can you resend them to the mailinglist, then me (and possibly others > > too of course) can respond inline which is the way we like to