Re: [hackers] [tabbed][PATCH] Remove quotes around variables in Makefile

2021-04-02 Thread Sebastian LaVine
On 4/2/21 9:12 AM, Hiltjo Posthuma wrote: On Fri, Apr 02, 2021 at 02:05:05PM +0200, Laslo Hunhold wrote: aren't the quotes also necessary in case one of the variables (DESTDIR, MANPREFIX, etc.) contains spaces? Myes I see, thank you for the correction. Should quotes be *added* to the

Re: [hackers] [tabbed][PATCH] Remove quotes around variables in Makefile

2021-04-02 Thread Hiltjo Posthuma
On Fri, Apr 02, 2021 at 02:05:05PM +0200, Laslo Hunhold wrote: > On Fri, 2 Apr 2021 11:03:05 +0200 > Hiltjo Posthuma wrote: > > Dear Hiltjo, > > > I prefer with quotes. You can still do make PREFIX=~/.local or > > whatever. Otherwise you could use $HOME. > > aren't the quotes also necessary in

Re: [hackers] [st][PATCH] Set custom environment variables in config.h

2021-04-02 Thread Laslo Hunhold
On Fri, 2 Apr 2021 07:42:24 + Subhaditya Nath wrote: Dear Subhaditya, > From 79e69338725563e1bdba32e856726e8fa5151e4c Mon Sep 17 00:00:00 2001 > From: Subhaditya Nath > Date: Thu, 1 Apr 2021 19:42:51 +0530 > Subject: [PATCH] Set custom environment variables in config.h > > This patch

Re: [hackers] [tabbed][PATCH] Remove quotes around variables in Makefile

2021-04-02 Thread Laslo Hunhold
On Fri, 2 Apr 2021 11:03:05 +0200 Hiltjo Posthuma wrote: Dear Hiltjo, > I prefer with quotes. You can still do make PREFIX=~/.local or > whatever. Otherwise you could use $HOME. aren't the quotes also necessary in case one of the variables (DESTDIR, MANPREFIX, etc.) contains spaces? With best

Re: [hackers] [tabbed][PATCH] Remove quotes around variables in Makefile

2021-04-02 Thread Hiltjo Posthuma
On Thu, Apr 01, 2021 at 08:53:35PM -0400, Sebastian LaVine wrote: > Previously, if you had changed your PREFIX in config.mk to something > like ~/.local, then instead of installing to /home/user/.local, a > directory called '~' would be created in the project directory. Commands > are also

Re: [hackers] [st][PATCH] Set custom environment variables in config.h

2021-04-02 Thread Hiltjo Posthuma
On Fri, Apr 02, 2021 at 07:42:24AM +, Subhaditya Nath wrote: > From 79e69338725563e1bdba32e856726e8fa5151e4c Mon Sep 17 00:00:00 2001 > From: Subhaditya Nath > Date: Thu, 1 Apr 2021 19:42:51 +0530 > Subject: [PATCH] Set custom environment variables in config.h > > This patch enables setting

[hackers] [st][PATCH] Set custom environment variables in config.h

2021-04-02 Thread Subhaditya Nath
>From 79e69338725563e1bdba32e856726e8fa5151e4c Mon Sep 17 00:00:00 2001 From: Subhaditya Nath Date: Thu, 1 Apr 2021 19:42:51 +0530 Subject: [PATCH] Set custom environment variables in config.h This patch enables setting custom environment variables in config.h. This patch changes config.def.h,

[hackers] [st][PATCH] Set custom environment variables in config.h

2021-04-02 Thread Subhaditya Nath
>From e611d6f4a1250d36d6bd9245c21c08cc9dccb942 Mon Sep 17 00:00:00 2001 From: Subhaditya Nath Date: Thu, 1 Apr 2021 19:42:51 +0530 Subject: [PATCH] Set custom environment variables in config.h This patch enables setting custom environment variables in config.h This patch changes the