Re: [hackers] [dmenu][PATCH] turn -b into a toggle

2021-08-16 Thread Laslo Hunhold
On Mon, 16 Aug 2021 19:30:03 +0600 NRK wrote: Dear NRK, > Fair enough. I suppose it should be better fit as a user patch in the > wiki then? I personally don't think that this makes sense as a user-patch, given there's maintenance involved and such a change usually just leads to failed hunks

Re: [hackers] [dmenu][PATCH] turn -b into a toggle

2021-08-16 Thread NRK
On Mon, Aug 16, 2021 at 10:28:36AM +0200, Hiltjo Posthuma wrote: > Thanks for the patch. I'd rather not add another option for it. > > I think if the default is not changed it still makes sense. Either way the > option works as documented. Fair enough. I suppose it should be better fit as a user

Re: [hackers] [dmenu][PATCH] turn -b into a toggle

2021-08-16 Thread Laslo Hunhold
On Mon, 16 Aug 2021 10:28:36 +0200 Hiltjo Posthuma wrote: Dear Hiltjo, > Thanks for the patch. I'd rather not add another option for it. > > I think if the default is not changed it still makes sense. Either > way the option works as documented. I understand, it's your call as the maintainer.

Re: [hackers] [dmenu][PATCH] turn -b into a toggle

2021-08-16 Thread Hiltjo Posthuma
On Sun, Aug 15, 2021 at 11:44:58PM +0600, NRK wrote: > currently config.h allows users to set the value of topbar to 0. > however if one does that, there's no way for him to get a topbar again. > it makes more sense to have -b as a toggle instead. > > - NRK Hi, Thanks for the patch. I'd rather

Re: [hackers] [dmenu][PATCH] turn -b into a toggle

2021-08-16 Thread Laslo Hunhold
On Sun, 15 Aug 2021 23:44:58 +0600 NRK wrote: Dear NRK, > currently config.h allows users to set the value of topbar to 0. > however if one does that, there's no way for him to get a topbar > again. it makes more sense to have -b as a toggle instead. this trades one problem for another given