Re: [hackers][st][PATCH] Add support for OSC color sequences.

2021-12-11 Thread Hiltjo Posthuma
Hi, Some comments below: On Fri, Dec 10, 2021 at 05:53:40PM -0500, Raheman Vaiya wrote: > The attached patch adds full support for the OSC 10/11/12/4 control > sequences. > These are used by programs like vim and theme.sh to query and set terminal > colours and are supported by most major termina

[hackers] [libgrapheme] Refine types (uint8_t -> char, uint32_t -> uint_least32_t) || Laslo Hunhold

2021-12-11 Thread git
commit c0e14c9b89c1ac78b72b7d8840261fbb7285d07a Author: Laslo Hunhold AuthorDate: Sat Dec 11 14:17:39 2021 +0100 Commit: Laslo Hunhold CommitDate: Sat Dec 11 14:17:39 2021 +0100 Refine types (uint8_t -> char, uint32_t -> uint_least32_t) The type uint32_t is not guaranteed by

Re: [hackers] [libgrapheme] Refine types (uint8_t -> char, uint32_t -> uint_least32_t) || Laslo Hunhold

2021-12-11 Thread Michael Forney
On 2021-12-11, g...@suckless.org wrote: > The type uint32_t is not guaranteed by the standard to be present, > but it guarantees uint_least32_t. If a libgrapheme-user passes a > pointer > to an uint32_t (instead of uint_least32_t) there will be no problem, > as the presence of uint

Re: [hackers] [libgrapheme] Refine types (uint8_t -> char, uint32_t -> uint_least32_t) || Laslo Hunhold

2021-12-11 Thread Laslo Hunhold
On Sat, 11 Dec 2021 12:24:10 -0800 Michael Forney wrote: Dear Michael, thanks for your input. You really know the intrinsics much better than I do. > It is true that the existence of uint32_t implies that uint_least32_t > also has exactly 32 bits and no padding bits, but they could still be > d

Re: [hackers] [libgrapheme] Refine types (uint8_t -> char, uint32_t -> uint_least32_t) || Laslo Hunhold

2021-12-11 Thread Michael Forney
Just want to mention up front that all of below is what I believe to be true from my interpretation of the standard. I'm happy to be corrected if I am wrong about any of this. On 2021-12-11, Laslo Hunhold wrote: > Okay, maybe I misunderstood something here, but from what I understand > casting be

Re: [hackers] [libgrapheme] Refine types (uint8_t -> char, uint32_t -> uint_least32_t) || Laslo Hunhold

2021-12-11 Thread Michael Forney
On 2021-12-11, Michael Forney wrote: > Conversion of unsigned char values outside the range of char is > implementation defined by C99 6.3.1.3p3: > >> Otherwise, the new type is signed and the value cannot be represented >> in it; either the result is implementation-defined or an >> implementation

Re: [hackers] [libgrapheme] Refine types (uint8_t -> char, uint32_t -> uint_least32_t) || Laslo Hunhold

2021-12-11 Thread Laslo Hunhold
On Sat, 11 Dec 2021 15:18:56 -0800 Michael Forney wrote: Dear Michael, > Just want to mention up front that all of below is what I believe to > be true from my interpretation of the standard. I'm happy to be > corrected if I am wrong about any of this. thanks again for your elaborate response!