Re: [hackers] [sbase][PATCH] flock: call exec without forking

2022-03-06 Thread Michael Forney
On 2022-03-06, Arthur Williams wrote: > Yeah I noticed that it wasn't defined in POSIX (which makes me wounder > why it is here in sbase and not ubase). To clarify what I meant, there > are popular implementations that don't have the '-F' flag (like busybox) > and adding it would just encourage

Re: [hackers] [sbase][PATCH] flock: call exec without forking

2022-03-06 Thread Arthur Williams
On Sun, Mar 06, 2022 at 09:00:25PM +0100, Quentin Rameau wrote: > > Don't believe the '-F' flag is portable so avoided trying to add > > it. > > flock(1) itself isn't portable, so none of its flag are. > Yeah I noticed that it wasn't defined in POSIX (which makes me wounder why it is here in

Re: [hackers] [sbase][PATCH] flock: call exec without forking

2022-03-06 Thread Quentin Rameau
> Don't believe the '-F' flag is portable so avoided trying to add > it. flock(1) itself isn't portable, so none of its flag are.

Re: [hackers] [sbase][PATCH] flock: call exec without forking

2022-03-06 Thread Arthur Williams
On Sun, Mar 06, 2022 at 10:40:51PM +0600, NRK wrote: > On Fri, Mar 04, 2022 at 01:11:00AM -0600, Arthur Williams wrote: > > Previously the code forked, waited for the child to exit and then > > returned the child's exit code. It is simpler to just skip fork and call > > exec directly. > > Hi

Re: [hackers] [sbase][PATCH] flock: call exec without forking

2022-03-06 Thread NRK
On Fri, Mar 04, 2022 at 01:11:00AM -0600, Arthur Williams wrote: > Previously the code forked, waited for the child to exit and then > returned the child's exit code. It is simpler to just skip fork and call > exec directly. Hi Arthur, I didn't comment on this the last time, as I'm not entirely

Re: [hackers] [st][PATCH] Fix truecolor being slightly inaccurate

2022-03-06 Thread Quentin Rameau
Hi Yutao, > The displayed color in truecolor mode is sometimes darker than > requested. The inaccuracy can be verified with the following example, > which should paint a white block but instead produces color #fefefe. > > printf '\e[38;2;255;255;255m\u2588\u2588\u2588\n' I get #ff on

[hackers] [st][PATCH] Fix truecolor being slightly inaccurate

2022-03-06 Thread Yutao Yuan
The displayed color in truecolor mode is sometimes darker than requested. The inaccuracy can be verified with the following example, which should paint a white block but instead produces color #fefefe. printf '\e[38;2;255;255;255m\u2588\u2588\u2588\n' The truecolor code uses 8-bit color