sock_same_addr() is supposed to return 0 if sa1 and sa2 are different addresses.
Since memcmp() returns 0 if its arguments are equal, we need to flip the return
value by comparing it to 0.
---
sock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sock.c b/sock.c
index ecb73ef.
On Tue, Apr 19, 2022 at 11:18:07AM +0100, big toaster wrote:
> Hi,
>
> Looks like you're right. It occurs on lwm, but not dwm.
>
> I'm using the unpatched latest git version.
>
> I've also found that sometimes with surf I'll have to move my mouse
> off the window and back on to get text boxes to
When comparing IPv4 addresses in sock_same_addr() we don't need
to correct their byteorder just to see if they are equal or not.
Byte swapping would only be needed if we needed to know
which address had the greater value.
---
sock.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -
Hi,
Looks like you're right. It occurs on lwm, but not dwm.
I'm using the unpatched latest git version.
I've also found that sometimes with surf I'll have to move my mouse
off the window and back on to get text boxes to work, so I think we
should just stop it from calling itself rather than not
When comparing IPv4 addresses in sock_same_addr() we don't need
to correct their byteorder just to see if they are equal or not.
Byte swapping would only be needed if we needed to know
which address had the greater value.
---
sock.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -
Yes I don't think this is correct.
All tabbed is doing here is receiving a FocusIn event for the main (parent)
window and giving focus to the window on the currently selected tab.
I believe this is more of an edge case that is specifically related to dwm
in relation to using tabbed and having tab
On Tue, Apr 19, 2022 at 08:06:19AM +0600, NRK wrote:
> Hi,
>
> Any remaining problem with the patch?
>
> Assuming it just fell off the radar :)
>
> - NRK
>
Hi,
Thanks for the reminder and the patch. It indeed fell off my radar, sorry about
that.
I pushed the patch now,
--
Kind regards,
Hil
commit 8629d9a1da72cc18568a8f146307b0e939b77ebf
Author: NRK
AuthorDate: Fri Jan 7 23:21:04 2022 +0600
Commit: Hiltjo Posthuma
CommitDate: Tue Apr 19 11:43:37 2022 +0200
code-golfing: cleanup osc color related code
* adds missing function prototype
* move xgetcolor() prot
On Mon, Apr 18, 2022 at 05:12:35PM +0100, bolshoytoster wrote:
> In the focusin function, it calls focus, which calls
> XSetInputFocus, which sends the focusin event.
>
> This can cause consistent ~90% cpu usage fo Xorg while the mouse
> is over the window.
>
> This patch just gets rid of the cal