On Sun, Dec 12, 2021 at 01:29:32AM -0500, Raheman Vaiya wrote:
> > -static unsigned int defaultcs = 256;
> >> +unsigned int defaultfg = 255;
> >> +unsigned int defaultbg = 254;
> >> +unsigned int defaultcs = 256;
>
> > The values in the config are changed here. Is it intended? If so, why?
>
>
Hi Raheman,
Just from a coding standpoint,
> diff --git a/config.def.h b/config.def.h
> index 6f05dce..91ab8ca 100644
> --- a/config.def.h
> +++ b/config.def.h
> @@ -120,6 +120,8 @@ static const char *colorname[] = {
> /* more colors can be added after 255 to use with DefaultXX */
>
> -static unsigned int defaultcs = 256;
>> +unsigned int defaultfg = 255;
>> +unsigned int defaultbg = 254;
>> +unsigned int defaultcs = 256;
> The values in the config are changed here. Is it intended? If so, why?
The colours 0 and 7 are distinct and can be set independently from the
foreground
Hi,
Some comments below:
On Fri, Dec 10, 2021 at 05:53:40PM -0500, Raheman Vaiya wrote:
> The attached patch adds full support for the OSC 10/11/12/4 control
> sequences.
> These are used by programs like vim and theme.sh to query and set terminal
> colours and are supported by most major
The attached patch adds full support for the OSC 10/11/12/4 control
sequences.
These are used by programs like vim and theme.sh to query and set terminal
colours and are supported by most major terminals (e.g alacrittty, kitty,
libvte). I submitted a patch to the wiki some time ago, but it didn't
