Re: [hackers] [dmenu] follow-up fix: add -D_GNU_SOURCE for strcasestr for some systems || Hiltjo Posthuma

2022-02-07 Thread Hiltjo Posthuma
On Mon, Feb 07, 2022 at 02:31:24PM +0100, Quentin Rameau wrote: > Hola, > > Here are my two cents, > > > On Mon, Feb 07, 2022 at 10:41:58AM +0100, Laslo Hunhold wrote: > > > On Mon, 7 Feb 2022 10:36:46 +0100 (CET) > > > g...@suckless.org wrote: > > > > > > Dear Hiltjo, > > > > > > >

Re: [hackers] [dmenu] follow-up fix: add -D_GNU_SOURCE for strcasestr for some systems || Hiltjo Posthuma

2022-02-07 Thread Quentin Rameau
Hola, Here are my two cents, > On Mon, Feb 07, 2022 at 10:41:58AM +0100, Laslo Hunhold wrote: > > On Mon, 7 Feb 2022 10:36:46 +0100 (CET) > > g...@suckless.org wrote: > > > > Dear Hiltjo, > > > > > follow-up fix: add -D_GNU_SOURCE for strcasestr for some systems > > > > wouldn't it be

Re: [hackers] [dmenu] follow-up fix: add -D_GNU_SOURCE for strcasestr for some systems || Hiltjo Posthuma

2022-02-07 Thread NRK
On Mon, Feb 07, 2022 at 01:36:24PM +0100, Hiltjo Posthuma wrote: > glibc 2.1 was released in 1999: > https://sourceware.org/glibc/wiki/Glibc%20Timeline > > OpenBSD 3.8 was released in 2005. The function is also available on musl and uclibc. Although on musl the implementation[0] is same as

Re: [hackers] [dmenu] follow-up fix: add -D_GNU_SOURCE for strcasestr for some systems || Hiltjo Posthuma

2022-02-07 Thread Laslo Hunhold
On Mon, 7 Feb 2022 13:36:24 +0100 Hiltjo Posthuma wrote: Dear Hiltjo, > I kindof expected a reply like this. In general I don't disagree. > > This function is available on many systems for decades. > > On some systems like OpenBSD the -D_GNU_SOURCE is not needed. > It's man page says: > >

Re: [hackers] [dmenu] follow-up fix: add -D_GNU_SOURCE for strcasestr for some systems || Hiltjo Posthuma

2022-02-07 Thread Hiltjo Posthuma
On Mon, Feb 07, 2022 at 10:41:58AM +0100, Laslo Hunhold wrote: > On Mon, 7 Feb 2022 10:36:46 +0100 (CET) > g...@suckless.org wrote: > > Dear Hiltjo, > > > follow-up fix: add -D_GNU_SOURCE for strcasestr for some systems > > wouldn't it be better to avoid GNU-extensions in code? > > With

Re: [hackers] [dmenu] follow-up fix: add -D_GNU_SOURCE for strcasestr for some systems || Hiltjo Posthuma

2022-02-07 Thread Laslo Hunhold
On Mon, 7 Feb 2022 10:36:46 +0100 (CET) g...@suckless.org wrote: Dear Hiltjo, > follow-up fix: add -D_GNU_SOURCE for strcasestr for some systems wouldn't it be better to avoid GNU-extensions in code? With best regards Laslo

[hackers] [dmenu] follow-up fix: add -D_GNU_SOURCE for strcasestr for some systems || Hiltjo Posthuma

2022-02-07 Thread git
commit a9a3836861bd23387b5a51d6f6ac23377e98e26f Author: Hiltjo Posthuma AuthorDate: Mon Feb 7 10:36:13 2022 +0100 Commit: Hiltjo Posthuma CommitDate: Mon Feb 7 10:36:13 2022 +0100 follow-up fix: add -D_GNU_SOURCE for strcasestr for some systems diff --git a/config.mk b/config.mk