Re: [hackers] [dwm][patch] Make EWMH windows float

This hasn't been included in the mainline yet, but I have been trying it out for the past couple of weeks. One implication of these changes that I have found is that dialog boxes may be marked with the WM_TRANSIENT_FOR hint, indicating to the window manager that it is a transient top-level window.

Re: [hackers] [dwm][patch] Make EWMH windows float

Hi, Attached patch with commit message. Br, Jakub Leszczak On Thu, Jun 11, 2020 at 6:32 PM Hiltjo Posthuma wrote: > > On Sun, Jun 07, 2020 at 08:36:57PM +0200, Jakub Leszczak wrote: > > Hi, > > > > What is the status of this patch? I do not see it being added to the > > mainline, nor any new m

Re: [hackers] [dwm][patch] Make EWMH windows float

On Sun, Jun 07, 2020 at 08:36:57PM +0200, Jakub Leszczak wrote: > Hi, > > What is the status of this patch? I do not see it being added to the > mainline, nor any new messages for some time. > > Br, > Jakub Leszczak > Hi Jakub, Can you send the last version one more time? The last sent versio

Re: [hackers] [dwm][patch] Make EWMH windows float

Hi, What is the status of this patch? I do not see it being added to the mainline, nor any new messages for some time. Br, Jakub Leszczak

Re: [hackers] [dwm][patch] Make EWMH windows float

Hi there, I like this updated patch and the overall direction taken here. Go for it to mainline. Thanks, Anselm PS: @Hiltjo you have my approval ,) On Tue, 19 May 2020 at 06:00, Jakub Leszczak wrote: > > Hi, > > Updated patch. Removed updatewindowtype() and integrated it into > applyrules().

Re: [hackers] [dwm][patch] Make EWMH windows float

Hi, Updated patch. Removed updatewindowtype() and integrated it into applyrules(). Since updatewindowtype() also run setfullscreen() I extracted it and put directly into manage(). But I am not sure whether it is necessary at all. If I remove setfullscreen() from manage() it still can be set via

Re: [hackers] [dwm][patch] Make EWMH windows float

On Mon, May 18, 2020 at 11:28:51AM +0200, Jakub Leszczak wrote: > Hi, > > > It's been only 4 days since the last reply. > > Sorry. Maybe I am just to eager for reply, I thought you might have > forgotten about this thread. > > > Does removing the updatewindowtype() call cause any regressions? >

Re: [hackers] [dwm][patch] Make EWMH windows float

Hi, > It's been only 4 days since the last reply. Sorry. Maybe I am just to eager for reply, I thought you might have forgotten about this thread. > Does removing the updatewindowtype() call cause any regressions? Do you mean removing updatewindowtype() call from propertynotify()? In theory it

Re: [hackers] [dwm][patch] Make EWMH windows float

On Mon, May 18, 2020 at 09:05:01AM +0200, Jakub Leszczak wrote: > Hi, > > Thread went silent. Do you have any more comments or suggestions? I > don't know whether you are interested in making such change into > mainline or not. > > Br, > Jakub Leszczak > Hi Jakub, It's been only 4 days since

Re: [hackers] [dwm][patch] Make EWMH windows float

Hi, Thread went silent. Do you have any more comments or suggestions? I don't know whether you are interested in making such change into mainline or not. Br, Jakub Leszczak

Re: [hackers] [dwm][patch] Make EWMH windows float

> (...) except that it would be better to handle this before rules get applied > (...) updatewindowtype() also handles fullscreen and runs setfullscreen(). setfullscreen() in turn sets `c->isfloating = 1`, and oldx, oldbw etc. And so setfullscreen() cannot be moved before applyrules(), setting of

Re: [hackers] [dwm][patch] Make EWMH windows float

For what it is worth I created a windowrolerule patch a while ago that lets you apply rules based on the WM_WINDOW_ROLE string. One would typically use something like this to avoid having browser preferences windows,

Re: [hackers] [dwm][patch] Make EWMH windows float

Just to clarify. I don't mean "example" diff as the final thing that should be a part of mainline. It is just a draft so you could take a look and let me know if this is a direction you would like to go with. Since like I wrote applyrules() is not run on propertynotify() like updatewindowtype() i

Re: [hackers] [dwm][patch] Make EWMH windows float

Hi, > Gimp also sets a WM_WINDOW_ROLE string: > > WM_WINDOW_ROLE(STRING) = "gimp-toolbox-1" Depends on which tools/window, each has different string. For example "brushes" is WM_WINDOW_ROLE(STRING) = "gimp-dock-6". > As a workaround for Gimp (...) Gimp was just an example from my side.

Re: [hackers] [dwm][patch] Make EWMH windows float

On Tue, May 12, 2020 at 11:07:31AM +0200, Jakub Leszczak wrote: > Hi, > > Commit `8262d9e663a98ab74b938bb5cdf0ddfd733bc5df` added logic to dwm > to make dialog windows float. I think that natural extension of that > commit is to also make a couple other window types float as well. > Types of wind

Re: [hackers] [dwm][patch] Make EWMH windows float

Jakub, nice. is it possible/easy'ish to make the selection of the window types to float user configurable in config.h? cheers, Greg

[hackers] [dwm][patch] Make EWMH windows float

Hi, Commit `8262d9e663a98ab74b938bb5cdf0ddfd733bc5df` added logic to dwm to make dialog windows float. I think that natural extension of that commit is to also make a couple other window types float as well. Types of windows that should(?) float: dialog, utility, toolbar, splash and modal. By sh