Re: [hackers] [sbase][PATCH] od: Fix argument parsing for -t flag

2020-03-03 Thread Michael Forney
On 2020-02-16, Quentin Rameau wrote: > I think something like that is better, what do you think? Thanks, this looks good to me. Please resend with a commit message. > diff --git a/od.c b/od.c > index 0b1c5c6..9ff8ff2 100644 > --- a/od.c > +++ b/od.c > @@ -212,7 +212,7 @@ main(int argc, char *arg

Re: [hackers] [sbase][PATCH] od: Fix argument parsing for -t flag

2020-02-16 Thread prez
On Sun Feb 16, 2020 at 10:36 PM, Quentin Rameau wrote: > I think something like that is better, what do you think? > > > diff --git a/od.c b/od.c > index 0b1c5c6..9ff8ff2 100644 > --- a/od.c > +++ b/od.c > @@ -212,7 +212,7 @@ main(int argc, char *argv[]) > { > int fd; > struct type *t; > - int ret

Re: [hackers] [sbase][PATCH] od: Fix argument parsing for -t flag

2020-02-16 Thread Quentin Rameau
Hi prez, > when the -t flag is used without a number of bytes, od exits with > usage(). 'od -tx foo' should behave like 'od -tx4 foo'. Indeed, > --- > od.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/od.c b/od.c > index 0b1c5c6..1780710 100644 > --- a/od.c

[hackers] [sbase][PATCH] od: Fix argument parsing for -t flag

2020-02-16 Thread prez
when the -t flag is used without a number of bytes, od exits with usage(). 'od -tx foo' should behave like 'od -tx4 foo'. --- od.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/od.c b/od.c index 0b1c5c6..1780710 100644 --- a/od.c +++ b/od.c @@ -250,6 +250,7 @@ main(