Re: [hackers] [sbase] [PATCH v2] mount: fix mount helper fs option handling

2016-02-11 Thread Dimitris Papastamos
On Thu, Feb 11, 2016 at 12:41:33AM -0600, Brad Barden wrote: > + if (strlcat(fsopts, EARGF(usage()), sizeof(fsopts)) > > sizeof(fsopts)) > + eprintf("option string too long\n"); Thanks for the patch. The conditional should be >= sizeof(fsopts). Can you resend

Re: [hackers] [sbase] [PATCH v2] mount: fix mount helper fs option handling

2016-02-11 Thread Dimitris Papastamos
On Thu, Feb 11, 2016 at 04:11:27AM -0600, Brad Barden wrote: > > The conditional should be >= sizeof(fsopts). Can you resend with the > > updated code? > > Good catch, thank you. Updated patch on the way. I'll get the hang of > threading these things one day. :\ Thanks, applied with a minor

Re: [hackers] [sbase] [PATCH v2] mount: fix mount helper fs option handling

2016-02-11 Thread Brad Barden
> The conditional should be >= sizeof(fsopts). Can you resend with the > updated code? Good catch, thank you. Updated patch on the way. I'll get the hang of threading these things one day. :\