Re: [hackers] [sbase] [PATCH v2] mount: fix mount helper fs option handling

2016-02-11 Thread Dimitris Papastamos
On Thu, Feb 11, 2016 at 04:11:27AM -0600, Brad Barden wrote: > > The conditional should be >= sizeof(fsopts). Can you resend with the > > updated code? > > Good catch, thank you. Updated patch on the way. I'll get the hang of > threading these things one day. :\ Thanks, applied with a minor styl

Re: [hackers] [sbase] [PATCH v2] mount: fix mount helper fs option handling

2016-02-11 Thread Brad Barden
> The conditional should be >= sizeof(fsopts). Can you resend with the > updated code? Good catch, thank you. Updated patch on the way. I'll get the hang of threading these things one day. :\

Re: [hackers] [sbase] [PATCH v2] mount: fix mount helper fs option handling

2016-02-11 Thread Dimitris Papastamos
On Thu, Feb 11, 2016 at 12:41:33AM -0600, Brad Barden wrote: > + if (strlcat(fsopts, EARGF(usage()), sizeof(fsopts)) > > sizeof(fsopts)) > + eprintf("option string too long\n"); Thanks for the patch. The conditional should be >= sizeof(fsopts). Can you resend wit

Re: [hackers] [sbase] [PATCH v2] mount: fix mount helper fs option handling

2016-02-10 Thread Brad Barden
Sorry for the excessive noise, I'm not paying close enough attention. That was supposed to read *fsopts = '\0'; On Thu Feb 11, 2016 at 12:41:33AM -0600, Brad Barden wrote: > If a mount helper is used, only argopts (given on commandline) are > passed to the helper via -o parameter. Option strings f

[hackers] [sbase] [PATCH v2] mount: fix mount helper fs option handling

2016-02-10 Thread Brad Barden
If a mount helper is used, only argopts (given on commandline) are passed to the helper via -o parameter. Option strings from fstab are ignored. This patch replaces global argopts pointer with a character array fsopts. A maximum length for filesytem options is #defined (used by fsopts and data), a