Re: [hackers] [sbase] [patch] cp: add -i flag

2016-12-27 Thread Laslo Hunhold
On Sun, 9 Oct 2016 13:22:32 + Thomas Mannay wrote: Hey Thomas, > Ah, I had forgotten to add fs.h to the commit. Added it in this time. > > I fixed the behaviour of newline as you pointed out. Should all be in > order. we generally frown upon interactive modes for these tools. Does your ham

Re: [hackers] [sbase] [patch] cp: add -i flag

2016-10-09 Thread Thomas Mannay
Ah, I had forgotten to add fs.h to the commit. Added it in this time. I fixed the behaviour of newline as you pointed out. Should all be in order. -- Thomas Mannay >From c809e44cc83eb2b494b9c4e052506e47785f11e3 Mon Sep 17 00:00:00 2001 From: Thomas Mannay Date: Sun, 9 Oct 2016 13:05:53 + Su

Re: [hackers] [sbase] [patch] cp: add -i flag

2016-10-09 Thread Hiltjo Posthuma
Two things I noticed: It does not seem to compile, it requires cp_iflag in fs.h: diff --git a/fs.h b/fs.h index 15ae5f4..36b9cb3 100644 --- a/fs.h +++ b/fs.h @@ -25,6 +25,7 @@ enum { extern int cp_aflag; extern int cp_fflag; +extern int cp_iflag; extern int cp_pflag; extern int cp_rflag; e

[hackers] [sbase] [patch] cp: add -i flag

2016-10-09 Thread Thomas Mannay
--- cp.1 | 22 -- cp.c | 7 ++- libutil/cp.c | 18 ++ 3 files changed, 40 insertions(+), 7 deletions(-) diff --git a/cp.1 b/cp.1 index 54126e2..4bbe4d0 100644 --- a/cp.1 +++ b/cp.1 @@ -6,7 +6,7 @@ .Nd copy files and directories .Sh SYNOPS