Re: [hackers] [sbase] [patch] ed: standards compliance, manpage, double free and infinite loop fix

On Sun, 9 Oct 2016 23:20:20 + Thomas Mannay wrote: Hey Thomas, > It took a while longer than I'd planned, but I've gone through and > redone my patches. I found a second source of an infinite loop to do > with joining where a variable would be -1 and the

Re: [hackers] [sbase] [patch] ed: standards compliance, manpage, double free and infinite loop fix

It took a while longer than I'd planned, but I've gone through and redone my patches. I found a second source of an infinite loop to do with joining where a variable would be -1 and the counter started at 0, so could never equal it. I also added a safety guard on j to prevent someone passing it a

Re: [hackers] [sbase] [patch] ed: standards compliance, manpage, double free and infinite loop fix

On Sun, 9 Oct 2016 21:40:55 + Thomas Mannay wrote: Hey Thomas, > > - the code within join() is not tab- but space-indented > And here I thought I had set my editor to indent tabs... this can happen, no problem. > > - can getindex(curln-1) underflow? (if curln

Re: [hackers] [sbase] [patch] ed: standards compliance, manpage, double free and infinite loop fix

I only went and forgot to attach the patch to ed.1... --- ed.1 | 5 + 1 file changed, 5 insertions(+) diff --git a/ed.1 b/ed.1 index c9f8a68..50351e2 100644 --- a/ed.1 +++ b/ed.1 @@ -205,6 +205,11 @@ characters. When returns a '!' is printed. The dot is unchanged. .El .Sh STANDARDS +The

Re: [hackers] [sbase] [patch] ed: standards compliance, manpage, double free and infinite loop fix

Thank you for the feedback. > - change the name to "ed: place newly-joined lines correctly" Will bear in mind for future patches that I should use more active descriptions. > - the code within join() is not tab- but space-indented And here I thought I had set my editor to indent tabs... > - can

Re: [hackers] [sbase] [patch] ed: standards compliance, manpage, double free and infinite loop fix

On Thu, 6 Oct 2016 11:04:17 + Thomas Mannay wrote: Hey Thomas, > Resubmission of my patchset for ed, albeit much better formatted so > as to ease reading them. as promised, I will give you some feedback on your patches you sent in. ###

Re: [hackers] [sbase] [patch] ed: standards compliance, manpage, double free and infinite loop fix

On Fri, Oct 7, 2016, at 09:43, Laslo Hunhold wrote: > one thing that has caught my attention is the titling of the patches. > It is better to use the active form rather than passive form, so my > suggestions for renaming would be > > "ed: newly joined lines are placed correctly" > -> "ed: place

Re: [hackers] [sbase] [patch] ed: standards compliance, manpage, double free and infinite loop fix

On Thu, 6 Oct 2016 11:04:17 + Thomas Mannay wrote: Hey Thomas, > one thing that has caught my attention is the titling of the patches. It is better to use the active form rather than passive form, so my suggestions for renaming would be "ed: newly joined

Re: [hackers] [sbase] [patch] ed: standards compliance, manpage, double free and infinite loop fix

On Thu, 6 Oct 2016 11:04:17 + Thomas Mannay wrote: Hey Thomas, > Resubmission of my patchset for ed, albeit much better formatted so > as to ease reading them. thank you very much for your patches! I'll take a look at them Sunday evening and give you some

[hackers] [sbase] [patch] ed: standards compliance, manpage, double free and infinite loop fix

Resubmission of my patchset for ed, albeit much better formatted so as to ease reading them. -- Thomas Mannay >From 14cb79fbab41b96ca3f4fcd85e178f38561e9211 Mon Sep 17 00:00:00 2001 From: Thomas Mannay Date: Thu, 6 Oct 2016 10:46:14