Re: [hackers] [st][PATCH] Rearrange x run with fast exit

2020-03-18 Thread Ivan Tham
On Wed, Mar 18, 2020 at 02:10:36PM +0100, Quentin Rameau wrote: >> Quickly swap out of loop to reduce indentation needed. >> Reuse deltatime variable to reuse calculation. > >Don't be afraid to separate unrelated modifications into separate >commits! > On Wed, Mar 18, 2020 at 09:41:14PM +0100, Que

Re: [hackers] [st][PATCH] Rearrange x run with fast exit

2020-03-18 Thread Quentin Rameau
> I separate unrelated modifications into unrelated commits but this is > still related, I think it also belongs under reorderings. That was the polite way of saying “They're unrelated, separate them in two commits”, apparently polite messages don't convey the meaning. > On Wed, Mar 18, 2020 at 0

Re: [hackers] [st][PATCH] Rearrange x run with fast exit

2020-03-18 Thread Ivan Tham
I separate unrelated modifications into unrelated commits but this is still related, I think it also belongs under reorderings. On Wed, Mar 18, 2020 at 02:10:36PM +0100, Quentin Rameau wrote: Quickly swap out of loop to reduce indentation needed. Reuse deltatime variable to reuse calculation.

Re: [hackers] [st][PATCH] Rearrange x run with fast exit

2020-03-18 Thread Quentin Rameau
> Quickly swap out of loop to reduce indentation needed. > Reuse deltatime variable to reuse calculation. Don't be afraid to separate unrelated modifications into separate commits!

[hackers] [st][PATCH] Rearrange x run with fast exit

2020-03-17 Thread Ivan Tham
Quickly swap out of loop to reduce indentation needed. Reuse deltatime variable to reuse calculation. --- x.c | 56 +--- 1 file changed, 25 insertions(+), 31 deletions(-) diff --git a/x.c b/x.c index 48a6676..01fd62a 100644 --- a/x.c +++ b/x.c @