Hi Hiltjo,
> layout.mobile-intl.h:387: warning: 'keys_functions' defined but not used
>
> Should it be added to the layer definitions, removed or left as-is for now?
That can be left as-is for now yes, I took the layer out of the defaults as it
didn't add much, but perhaps someone
still wants
Hi Maarten,
Thanks for the patch and the work on svkbd and sxmo.
I have a question about a warning in the code (gcc with compiled with CFLAGS
-Wall):
layout.mobile-intl.h:387: warning: 'keys_functions' defined but not used
Should it be added to the layer definitions, removed or left as-is for
Hi Hiltjo,
Thanks for the merge and the extra cleanup you did, looks good! I just
submitted one
last patch (a modification to one of the other layouts, fell outside
the earlier batch) and then I think we're good to go for release of
svkbd 0.3.0 if you're satisfied too.
Regards,
--
Maarten van
Hi Hiltjo,
> They arrived properly. I've read most of the patches. It's a bulk of patches
> so please give me some time to review it.
Sure, no problem!
> Some quick notes (will write it more detailed later):
Thanks, I already picked these up, I'll submit 4 new patches that
address these (on
On Sat, Mar 27, 2021 at 02:03:05PM +0100, Maarten van Gompel wrote:
> On 21-03-19 09:23, Maarten van Gompel wrote:
> > > Thanks for the work.
> > >
> > > I've reviewed the patches. In general it looks good, but I've found a few
> > > issues. Can you resend them to the mailinglist, then me (and
On Sat, 27 Mar 2021 14:03:05 +0100
Maarten van Gompel wrote:
Dear Maarten,
> I wonder if the svkbd patches I submitted last week arrived properly
> and if you have the opportunity to look at them soon?
>
> (I only see 2 of the 24(!) patches in the mailing list archives, there
> may be some
On 21-03-19 09:23, Maarten van Gompel wrote:
> > Thanks for the work.
> >
> > I've reviewed the patches. In general it looks good, but I've found a few
> > issues. Can you resend them to the mailinglist, then me (and possibly others
> > too of course) can respond inline which is the way we like to
> Thanks for the work.
>
> I've reviewed the patches. In general it looks good, but I've found a few
> issues. Can you resend them to the mailinglist, then me (and possibly others
> too of course) can respond inline which is the way we like to manage and
> review
Thanks! Sure, no problem. I'll
On Mon, Mar 15, 2021 at 05:46:32PM +0100, Maarten van Gompel wrote:
> Hi,
>
> We have done some considerable work on svkbd in the scope of the sxmo
> project and would like to again merge these changes upstream to
> suckless, like before. Before I inundate your mailing list with a series
> of 22
Hi,
We have done some considerable work on svkbd in the scope of the sxmo
project and would like to again merge these changes upstream to
suckless, like before. Before I inundate your mailing list with a series
of 22 patches (after I already did some commit squashing), I'd first
like to get your
10 matches
Mail list logo
