Re: [hackers] [tabbed][PATCH] Remove quotes around variables in Makefile

2021-04-02 Thread Sebastian LaVine
On 4/2/21 9:12 AM, Hiltjo Posthuma wrote: On Fri, Apr 02, 2021 at 02:05:05PM +0200, Laslo Hunhold wrote: aren't the quotes also necessary in case one of the variables (DESTDIR, MANPREFIX, etc.) contains spaces? Myes I see, thank you for the correction. Should quotes be *added* to the Makef

Re: [hackers] [tabbed][PATCH] Remove quotes around variables in Makefile

2021-04-02 Thread Hiltjo Posthuma
On Fri, Apr 02, 2021 at 02:05:05PM +0200, Laslo Hunhold wrote: > On Fri, 2 Apr 2021 11:03:05 +0200 > Hiltjo Posthuma wrote: > > Dear Hiltjo, > > > I prefer with quotes. You can still do make PREFIX=~/.local or > > whatever. Otherwise you could use $HOME. > > aren't the quotes also necessary in

Re: [hackers] [tabbed][PATCH] Remove quotes around variables in Makefile

2021-04-02 Thread Laslo Hunhold
On Fri, 2 Apr 2021 11:03:05 +0200 Hiltjo Posthuma wrote: Dear Hiltjo, > I prefer with quotes. You can still do make PREFIX=~/.local or > whatever. Otherwise you could use $HOME. aren't the quotes also necessary in case one of the variables (DESTDIR, MANPREFIX, etc.) contains spaces? With best

Re: [hackers] [tabbed][PATCH] Remove quotes around variables in Makefile

2021-04-02 Thread Hiltjo Posthuma
On Thu, Apr 01, 2021 at 08:53:35PM -0400, Sebastian LaVine wrote: > Previously, if you had changed your PREFIX in config.mk to something > like ~/.local, then instead of installing to /home/user/.local, a > directory called '~' would be created in the project directory. Commands > are also performe

[hackers] [tabbed][PATCH] Remove quotes around variables in Makefile

2021-04-01 Thread Sebastian LaVine
Previously, if you had changed your PREFIX in config.mk to something like ~/.local, then instead of installing to /home/user/.local, a directory called '~' would be created in the project directory. Commands are also performed without quotes in the Makefiles of other suckless projects, like st or d