Re: [hackers] Re: [dwm][PATCH v3] manage: For isfloating/oldstate check/set, ensure trans client actually exists

2022-03-23 Thread Miles Alan
On Mon, Mar 21, 2022, at 10:19 AM, Chris Down wrote: > WM_TRANSIENT_FOR is set to the root window in the pinentry's case: > > % xprop | grep TRANSIENT > WM_TRANSIENT_FOR(WINDOW): window id # 0x523 > % xwininfo -root -tree | grep 0x523 > xwininfo: Window id: 0x523 (the root

Re: [hackers] Re: [dwm][PATCH v3] manage: For isfloating/oldstate check/set, ensure trans client actually exists

2022-03-22 Thread Chris Down
Hi Miles, Miles Alan writes: Interesting - thanks for reporting. I'd be curious what WM_TRANSIENT_FOR is set to in pinentry's case. The case I'm trying to address is resizable SDL applications which, as mentioned earlier, wholesale set WM_TRANSIENT_FOR to the root window. I'm not sure on the

Re: [hackers] Re: [dwm][PATCH v3] manage: For isfloating/oldstate check/set, ensure trans client actually exists

2022-03-18 Thread Miles Alan
On Fri, Mar 18, 2022, at 6:19 PM, Chris Down wrote: > Hey folks, > > This patch causes a regression for GPG's default pinentry. Previously the > window floats as it is supposed to, but now it doesn't float at all. > > To reproduce, you can clear your agent credentials with `gpg-connect-agent >

Re: [hackers] Re: [dwm][PATCH v3] manage: For isfloating/oldstate check/set, ensure trans client actually exists

2022-03-18 Thread Chris Down
Hey folks, This patch causes a regression for GPG's default pinentry. Previously the window floats as it is supposed to, but now it doesn't float at all. To reproduce, you can clear your agent credentials with `gpg-connect-agent <<< RELOADAGENT`, and then request decryption. Attached are

Re: [hackers] Re: [dwm][PATCH v3] manage: For isfloating/oldstate check/set, ensure trans client actually exists

2022-03-14 Thread Miles Alan
On Sun, Mar 13, 2022, at 12:35 PM, Hiltjo Posthuma wrote: > On Fri, Mar 11, 2022 at 11:25:18AM -0500, Miles Alan wrote: >> On Fri, Mar 11, 2022, at 9:11 AM, sir fish wrote: >> > Miles Alan wrote: >> >> On Mon, Feb 21, 2022, at 1:10 AM, m...@milesalan.com wrote: >> >> > From: Miles Alan >> >> >

Re: [hackers] Re: [dwm][PATCH v3] manage: For isfloating/oldstate check/set, ensure trans client actually exists

2022-03-13 Thread Hiltjo Posthuma
On Fri, Mar 11, 2022 at 11:25:18AM -0500, Miles Alan wrote: > On Fri, Mar 11, 2022, at 9:11 AM, sir fish wrote: > > Miles Alan wrote: > >> On Mon, Feb 21, 2022, at 1:10 AM, m...@milesalan.com wrote: > >> > From: Miles Alan > >> > > >> > In certain instances trans may be set to a window that

Re: [hackers] Re: [dwm][PATCH v3] manage: For isfloating/oldstate check/set, ensure trans client actually exists

2022-03-11 Thread Miles Alan
On Fri, Mar 11, 2022, at 9:11 AM, sir fish wrote: > Miles Alan wrote: >> On Mon, Feb 21, 2022, at 1:10 AM, m...@milesalan.com wrote: >> > From: Miles Alan >> > >> > In certain instances trans may be set to a window that doesn't actually >> > map to a client via wintoclient; in this case it

Re: [hackers] Re: [dwm][PATCH v3] manage: For isfloating/oldstate check/set, ensure trans client actually exists

2022-03-11 Thread sir fish
Miles Alan wrote: > On Mon, Feb 21, 2022, at 1:10 AM, m...@milesalan.com wrote: > > From: Miles Alan > > > > In certain instances trans may be set to a window that doesn't actually > > map to a client via wintoclient; in this case it doesn't make sense > > to set isfloating/oldstate since trans

Re: [hackers] Re: [dwm][PATCH v3] manage: For isfloating/oldstate check/set, ensure trans client actually exists

2022-03-08 Thread Hiltjo Posthuma
On Tue, Mar 08, 2022 at 12:56:27PM -0500, Miles Alan wrote: > On Mon, Feb 21, 2022, at 1:10 AM, m...@milesalan.com wrote: > > From: Miles Alan > > > > In certain instances trans may be set to a window that doesn't actually > > map to a client via wintoclient; in this case it doesn't make sense >

[hackers] Re: [dwm][PATCH v3] manage: For isfloating/oldstate check/set, ensure trans client actually exists

2022-03-08 Thread Miles Alan
On Mon, Feb 21, 2022, at 1:10 AM, m...@milesalan.com wrote: > From: Miles Alan > > In certain instances trans may be set to a window that doesn't actually > map to a client via wintoclient; in this case it doesn't make sense > to set isfloating/oldstate since trans is essentially invalid in that