[hackers] sbase: od: properly concatenate multiple file arguments

Relative to master. >From 475f7b2f33e8e4a4b9ec06a455a1e970f21e99b8 Mon Sep 17 00:00:00 2001 From: Greg Reagle Date: Fri, 2 Oct 2015 10:26:04 -0400 Subject: [PATCH] od: properly concatenate multiple file arguments --- od.c | 22 -- 1 file changed, 12

Re: [hackers] sbase: od: properly concatenate multiple file arguments

On 10/02/2015 11:35 AM, FRIGN wrote: On Fri, 2 Oct 2015 11:16:24 -0400 Greg Reagle wrote: But I don't want it initialized every time the for loop is entered. That's why I made it static. It needs to preserve its value between calls. Ah yeah, of course. Sorry, I

Re: [hackers] sbase: od: properly concatenate multiple file arguments

On Fri, 2 Oct 2015 10:40:12 -0400 Greg Reagle wrote: > Relative to master. Better rename it to "lastfile". Then it's clearer ;) Also: - off_t addr; + static off_t addr = 0; please just keep the initialization inside the for-loop. It's a slightly better style

Re: [hackers] sbase: od: properly concatenate multiple file arguments

On Fri, 2 Oct 2015 11:16:24 -0400 Greg Reagle wrote: > But I don't want it initialized every time the for loop is entered. > That's why I made it static. It needs to preserve its value between calls. Ah yeah, of course. Sorry, I overlooked that. Let's focus one one

Re: [hackers] sbase: od: properly concatenate multiple file arguments

On 10/02/2015 11:03 AM, FRIGN wrote: Also: - off_t addr; + static off_t addr = 0; please just keep the initialization inside the for-loop. It's a slightly better style than setting the variable directly at the declaration block. But I don't want it initialized every time the for