Re: Opening HRegionServer/HMaster/HClient for extension

2007-06-20 Thread James Kennedy
Hi Michael, I'll create a Jira task and fix the patch spacing. I can't really talk too much about the HRegionServer/HClient extension i'm developing but I do think that there could be a general purpose need. For example, HBase let's you filter a scan by rowkey and column key. But what about

Re: Opening HRegionServer/HMaster/HClient for extension

2007-06-20 Thread Michael Stack
The patch looks like an improvement to me. Whats the rationale for needing to extend client/server? Do you think it of general applicability? I'd suggest making an issue and attaching a patch (file against hbase component and it looks like your tabs are not the hadoop two spaces convention

Opening HRegionServer/HMaster/HClient for extension

2007-06-20 Thread James Kennedy
For what i'm doing I found it necessary to extend HRegionServer/HRegion/HClient for some custom functionality. Following good Java practice I see that the HBase code as been programmed defensively, keeping stuff private as much as possible. However, for extensibility it would be nice if the s