[PATCH 0/8 v3] logging refactoring

This patch series creates some logging macros in hail_log.h and modifies cld to use them. It also converts chunkd and tabled to use the new cld API. version 3: * move logging macros out of common.h and into hail_log.h * add patches for chunkd and tabled version 2: * Rename CLD_DEBUG, etc. to

[PATCH 1/8 v3] cld: Declare common.c functions in common.h

Signed-off-by: Colin McCabe cmcc...@alumni.cmu.edu --- include/cld_msg.h | 10 -- include/cldc.h|1 + include/common.h | 11 +++ 3 files changed, 12 insertions(+), 10 deletions(-) create mode 100644 include/common.h diff --git a/include/cld_msg.h b/include/cld_msg.h

[PATCH 2/8 v3] cld: create logging macros

Signed-off-by: Colin McCabe cmcc...@alumni.cmu.edu --- include/hail_log.h | 31 +++ 1 files changed, 31 insertions(+), 0 deletions(-) create mode 100644 include/hail_log.h diff --git a/include/hail_log.h b/include/hail_log.h new file mode 100644 index

[PATCH 4/8 v3] cld: modify server code to use logging macros

Signed-off-by: Colin McCabe cmcc...@alumni.cmu.edu --- server/cld.h |4 +- server/cldb.c|7 ++-- server/msg.c | 50 +- server/server.c | 87 - server/session.c | 58

[PATCH 5/8 v3] cld: modify cld-dns to use logging macros

Signed-off-by: Colin McCabe cmcc...@alumni.cmu.edu --- include/cldc.h |7 ++--- lib/cldc-dns.c | 80 +--- tools/cldcli.c | 12 +--- 3 files changed, 41 insertions(+), 58 deletions(-) diff --git a/include/cldc.h b/include/cldc.h

[PATCH 6/8 v3] cld: Tweak some log levels in cldc dns

Signed-off-by: Colin McCabe cmcc...@alumni.cmu.edu --- lib/cldc-dns.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/cldc-dns.c b/lib/cldc-dns.c index d58a8ba..1bf6355 100644 --- a/lib/cldc-dns.c +++ b/lib/cldc-dns.c @@ -46,7 +46,7 @@ int

[PATCH 8/8 v3] tabled: Use hail_log API to call libcldc

Signed-off-by: Colin McCabe cmcc...@alumni.cmu.edu --- server/cldu.c | 14 -- server/tabled.h |1 + 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/server/cldu.c b/server/cldu.c index e66ec02..e256e6a 100644 --- a/server/cldu.c +++ b/server/cldu.c @@ -918,6

[PATCH 9/8 v3] cld: Export hail_log.h to the include directory

I almost forgot-- Makefile.am needs to change. Signed-off-by: Colin McCabe cmcc...@alumni.cmu.edu --- include/Makefile.am |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/Makefile.am b/include/Makefile.am index f7539dd..4ea11c4 100644 --- a/include/Makefile.am

Re: [PATCH 0/6 v2] logging refactoring

On Mon, 14 Dec 2009 18:18:47 -0800 Colin McCabe cmcc...@alumni.cmu.edu wrote: Also my new patch creates a hail_log.h. It didn't really seem right to force everyone who wanted to use HAIL_LOG to include cldc.h. I'll convert over the rest of chunkd and tabled to the new macros if this patch

Re: [PATCH 1/8 v3] cld: Declare common.c functions in common.h

On 12/14/2009 07:32 PM, Colin McCabe wrote: Signed-off-by: Colin McCabecmcc...@alumni.cmu.edu applied, after fixing two problems: * did not survive 'make distcheck'. common.h was needed in include/Makefile.am. * introduced build warnings in the server. added #include in server/cld.h.

Re: [PATCH 2/8 v3] cld: create logging macros

On 12/14/2009 07:32 PM, Colin McCabe wrote: Signed-off-by: Colin McCabecmcc...@alumni.cmu.edu applied, after fixing two minor problems: * added to include/Makefile.am * #include'd stdbool.h -- To unsubscribe from this list: send the line unsubscribe hail-devel in the body of a message to

Re: [PATCH 3/8 v3] cld: modify client code to use logging macros

On 12/14/2009 07:32 PM, Colin McCabe wrote: Signed-off-by: Colin McCabecmcc...@alumni.cmu.edu --- include/cldc.h |5 +-- lib/cldc.c | 98 +++- tools/cldcli.c |2 +- 3 files changed, 43 insertions(+), 62 deletions(-) applied

Re: [PATCH 4/8 v3] cld: modify server code to use logging macros

On 12/14/2009 07:32 PM, Colin McCabe wrote: Signed-off-by: Colin McCabecmcc...@alumni.cmu.edu applied, with minor changes: * include hail_log.h from server/cld.h, the header file common to all server code. remove individual #include's in each .c file. * fixed up #include of

Re: [PATCH 5/8 v3] cld: modify cld-dns to use logging macros

On 12/14/2009 07:32 PM, Colin McCabe wrote: Signed-off-by: Colin McCabecmcc...@alumni.cmu.edu --- include/cldc.h |7 ++--- lib/cldc-dns.c | 80 +--- tools/cldcli.c | 12 +--- 3 files changed, 41 insertions(+), 58 deletions(-)

Re: [PATCH 9/8 v3] cld: Export hail_log.h to the include directory

On 12/14/2009 07:55 PM, Colin McCabe wrote: I almost forgot-- Makefile.am needs to change. Signed-off-by: Colin McCabecmcc...@alumni.cmu.edu --- include/Makefile.am |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/Makefile.am b/include/Makefile.am index

Re: [PATCH 8/8 v3] tabled: Use hail_log API to call libcldc

On 12/14/2009 07:32 PM, Colin McCabe wrote: Signed-off-by: Colin McCabecmcc...@alumni.cmu.edu --- server/cldu.c | 14 -- server/tabled.h |1 + 2 files changed, 13 insertions(+), 2 deletions(-) ditto last message, for tabled -- To unsubscribe from this list: send the

[Patch 1/3] tabled: drop commented messages

Less clutter is good. Signed-off-by: Pete Zaitcev zait...@redhat.com --- server/cldu.c |3 --- server/storage.c | 16 server/storparse.c |1 - 3 files changed, 20 deletions(-) Jeff, if you recall, I promised to do this as a condition for a past merge. commit

[Patch 2/3] tabled: use argument of a thread

We replace a comment with code to better show the intent. Once we have several threads, we can plug TLS easier into this. Signed-off-by: Pete Zaitcev zait...@redhat.com --- server/replica.c | 69 ++--- 1 file changed, 41 insertions(+), 28 deletions(-)

Re: [Patch 3/3] tabled: drop addr_af

On 12/16/2009 12:10 AM, Pete Zaitcev wrote: This flag was is a useless duplication and a fiction prompted by getaddrinfo(). In reality it's not useful even if we decide to run CLD over DCCP. Signed-off-by: Pete Zaitcevzait...@redhat.com --- server/storage.c |8 server/tabled.h

Fedora SRPMs for Hail

zaitcev and I typically maintain recent versions of cld/chunkd/tabled in Fedora rawhide. This can be a useful source of SRPMs for Fedora 10/11/12, if people find those useful. Usually it takes a few days for the built [S]RPMs to trickle out to the Fedora mirrors. Since we just committed