On Wed, Jan 13, 2010 at 4:10 PM, Jeff Garzik wrote:
> OK, final review. Please fix these problems and resend (some of these
> repeated from other emails; putting here to consolidate):
>
> * needs to build patch builds and runs against a fresh git repo clone +
> ./autogen.sh + ./configure + make
On 01/10/2010 10:00 AM, Colin McCabe wrote:
This patch moves CLD from using manual data serialization to using XDR (via
rpcgen). Both the packet header and the message body are now serialized and
deserialized using XDR. This makes it easy to have a variable-length packet
header, as well as a vari
On 01/13/2010 04:38 PM, Pete Zaitcev wrote:
On Wed, 13 Jan 2010 16:03:45 -0500
Jeff Garzik wrote:
Well, this definitely does not build as-is. lib/Makefile.am needs
BUILT_SOURCES = cld_msg_rpc.h
otherwise nothing builds at all, because cld_msg_rpc.h does not exist.
test/Mak
On Wed, 13 Jan 2010 16:03:45 -0500
Jeff Garzik wrote:
> Well, this definitely does not build as-is. lib/Makefile.am needs
>
> BUILT_SOURCES = cld_msg_rpc.h
>
> otherwise nothing builds at all, because cld_msg_rpc.h does not exist.
> test/Makefile.am and tools/Makefile.am both
On 01/10/2010 10:00 AM, Colin McCabe wrote:
This patch moves CLD from using manual data serialization to using XDR (via
rpcgen). Both the packet header and the message body are now serialized and
deserialized using XDR. This makes it easy to have a variable-length packet
header, as well as a vari
On 01/12/2010 10:50 PM, Akinobu Mita wrote:
This patch makes sense, but it also raises the question of whether or not
we
should move to a two-level directory scheme, eg.
123/456/7890ABCDEF
rather than
123/4567890ABCDEF
to limit the size of the top-level directories. It real
