reqirep crashes in 1.5-dev17

2013-02-19 Thread Nikolas Everett
We're seeing crashes in 15-dev17 that look to be caused by reqirep, reqrep, or reqdel. I haven't make an exhaustive list. Currently we're just seeing them on the devel version from homebrew which is 1.5-dev17. I don't see them on the version provided by ppa:nilya/haproxy-1.5 which is 1.5-dev12.

Re: reqirep crashes in 1.5-dev17

2013-02-19 Thread Nikolas Everett
The same crash does not occur when I build 1.5-dev17 on linux like so: make TARGET=linux2628 CPU=native USE_PCRE=1 USE_OPENSSL=1 USE_ZLIB=1 I imagine this is something I should take to the homebrew folks. On Tue, Feb 19, 2013 at 11:56 AM, Nikolas Everett nik9...@gmail.com wrote: We're seeing

Re: [PATCH] Use PCRE JIT in acl

2013-02-19 Thread Hiroaki Nakamura
Hi, Thank you for your review. Sorry for being late, now I made a new patch. As you suggested, I added struct jit_regex. I also add typedef to avoid #ifdef's scatter here and there. I think the code becomes cleaner. Could you review it? 2013/2/13 Willy Tarreau w...@1wt.eu: Hi, sorry it was

Re: [PATCH 1/7] Correct logic in cut_crlf()

2013-02-19 Thread Krzysztof Olędzki
On 2013-02-13 09:48, Simon Horman wrote: CUT And add: while (*s == '\r' || *s == '\n') before *s++ = '\0'; .. so we properly split line1\r\nline2. I see cut_crlf used to truncate strings at the end of the first line, not split them into multiple lines. So I'm not sure if the while()