[PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

2018-09-14 Thread PiBa-NL
Hi List, Willy, I've created a regtest that checks that when concurrent connections are being handled that the connection counters are kept properly. I think it could be committed as attached. It takes a few seconds to run. It currently fails on 1.9-dev2 (also fails on 1.8.13 with kqueue on

patch to avoid null pointer dereference

2018-09-14 Thread Илья Шипицин
hi, please find attached patch cheers, Ilya Shipitsin From 7961bb27597cf529a88da475d3928d6223a88753 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Sat, 15 Sep 2018 00:50:05 +0500 Subject: [PATCH] MINOR: src/connection.c: avoid null pointer dereference found by coverity ---

Re: PATCH/doc: load-server-state-from-file (was: BUG: changed server IPs do not get restored from saved state)

2018-09-14 Thread Peter Fröhlich
Hi Willy Am Fr., 14. Sep. 2018 um 19:15 Uhr schrieb Willy Tarreau : > On Fri, Sep 14, 2018 at 05:43:14PM +0200, Peter Fröhlich wrote: > > For your consideration, the doc patch with context. > > Please give me feedback if I should incorporate some other aspects. > > Thank you, however as you can

Re: PATCH/doc: load-server-state-from-file (was: BUG: changed server IPs do not get restored from saved state)

2018-09-14 Thread Willy Tarreau
Hi Peter, On Fri, Sep 14, 2018 at 05:43:14PM +0200, Peter Fröhlich wrote: > For your consideration, the doc patch with context. > Please give me feedback if I should incorporate some other aspects. Thank you, however as you can see below, your mailer mangled the patch by wrapping some lines and

PATCH/doc: load-server-state-from-file (was: BUG: changed server IPs do not get restored from saved state)

2018-09-14 Thread Peter Fröhlich
Am Do., 13. Sep. 2018 um 15:23 Uhr schrieb Peter Fröhlich : > > Am Do., 13. Sep. 2018 um 10:06 Uhr schrieb Willy Tarreau : > > On Thu, Sep 13, 2018 at 09:29:42AM +0200, Peter Fröhlich wrote: > > > Would our use case of setting the backend servers only through the socket, > > > and the necessary

Re: [ANNOUNCE] haproxy-1.9-dev2

2018-09-14 Thread Emmanuel Hocdet
Hi, Quick test with 1.9-dev2, and i see latency (in seconds) to connect to haproxy with SSL (tcp mode). It’s ok in master with 9f9b0c6a. No time to investigate more for the moment. ++ Manu

Fix some warnings and a small bug in debug logic

2018-09-14 Thread Dirkjan Bussink
Hi all, While working on the OpenSSL 1.1.1 and TLS 1.3 cipher support issue, I also saw a number of compiler warnings that led me to investigate a bit. It resulted in some small cleanups and also one bug I think in some of the debugging logic for the h2 mux. Hopefully these are useful!

Re: TLS 1.3 options available with OpenSSL 1.1.1

2018-09-14 Thread Dirkjan Bussink
Hi all, > On 14 Sep 2018, at 14:15, Emmanuel Hocdet wrote: > > It’s not necessary, BoringSSL and LibreSSL have, at best, > OPENSSL_VERSION_NUMBER set to 1.1.0 for API compatibilité. Looking at LibreSSL, it’s defining this (in their latest Git code): src/lib/libcrypto/opensslv.h:#define

Re: TLS 1.3 options available with OpenSSL 1.1.1

2018-09-14 Thread Emmanuel Hocdet
> Le 14 sept. 2018 à 14:01, Dirkjan Bussink a écrit : > > Hi all, > >> On 14 Sep 2018, at 12:18, Emmanuel Hocdet wrote: >> >> Same deal with boringssl, TLSv <= 1.2 ciphers configuration and TLSv1.3 >> ciphers are segregated. >>

Re: TLS 1.3 options available with OpenSSL 1.1.1

2018-09-14 Thread Dirkjan Bussink
Hi all, > On 14 Sep 2018, at 12:18, Emmanuel Hocdet wrote: > > Same deal with boringssl, TLSv <= 1.2 ciphers configuration and TLSv1.3 > ciphers are segregated. > https://boringssl.googlesource.com/boringssl/+/abbbee10ad4739648bcbf36a5ac52f23263a67dd%5E!/ This reminded me to double check with

Re: TLS 1.3 options available with OpenSSL 1.1.1

2018-09-14 Thread Emmanuel Hocdet
Hi Emeric, Lukas, Dirkjan > Le 14 sept. 2018 à 11:12, Emeric Brun a écrit : > > Hi Lukas, Dirkjan, > > On 09/13/2018 10:17 PM, Lukas Tribus wrote: >> Hello Dirkjan, >> >> >> On Thu, 13 Sep 2018 at 16:44, Dirkjan Bussink wrote: >>> So with a new API call, does that mean adding for example

Re: TLS 1.3 options available with OpenSSL 1.1.1

2018-09-14 Thread Dirkjan Bussink
Hi all, I took the liberty of writing up a patch with what this could look like. I have named the option `ciphersuites` and also added the documentation for it as well. I have attached the patch to this email. > On 14 Sep 2018, at 11:12, Emeric Brun wrote: > > I think if TLSv <= 1.2 and

Re: TLS 1.3 options available with OpenSSL 1.1.1

2018-09-14 Thread Emeric Brun
Hi Lukas, Dirkjan, On 09/13/2018 10:17 PM, Lukas Tribus wrote: > Hello Dirkjan, > > > On Thu, 13 Sep 2018 at 16:44, Dirkjan Bussink wrote: >> So with a new API call, does that mean adding for example a `ciphersuites` >> option that works similar to `ciphers` today that it accepts a string and

Re: regtest lua/b00002.vtc fails with 1.9-dev2 / master

2018-09-14 Thread Willy Tarreau
Hi Pieter, On Thu, Sep 13, 2018 at 05:13:43PM +0200, PiBa-NL wrote: > Just tried another run of regtests on FreeBSD, and found that lua/b2.vtc > fails (coredump, gdb bt below) with todays snapshot: HA-Proxy version > 1.9-dev2-253006d 2018/09/12 Yesterday we've looked at this with Olivier and

Re: [PATCH] DOC: Fix typos in lua documentation

2018-09-14 Thread Willy Tarreau
On Thu, Sep 13, 2018 at 01:50:29PM +0100, Bertrand Jacquin wrote: > Hi, > > Please find attached a patch to fix some typos in the lua documentation. Applied, thanks Bertrand! Willy