Re: [PATCH] CLEANUP: Consistently `unsigned int` for bitfields

Hi Tim, On Sat, Jan 18, 2020 at 01:32:49AM +0100, Tim Duesterhus wrote: > Willy, > > I did not touch the `struct pat_time` in pattern.h which appears to be > completely unused. Please check whether adjustments should be made there > as well or whether it should simply be removed. Feel free to

Re: [PATCH] BUG/MINOR: cache: Fix leak of cache name in error path

On Sat, Jan 18, 2020 at 01:46:18AM +0100, Tim Duesterhus wrote: > This issue was introduced in commit 99a17a2d91f9044ea20bba6617048488aed80555 > which first appeared in tag v1.9-dev11. This bugfix should be backported > to HAProxy 1.9+. Applied, thanks. Willy

Re: [PATCH] DOC: Fix copy and paste mistake in http-response replace-value doc

On Fri, Jan 17, 2020 at 03:53:18PM +0100, Tim Duesterhus wrote: > This fixes up commit 2252beb8557d73407b8f96eef91d6927fb855685. Applied, thanks. Willy

Re: [PATCH] BUG/MINOR: dns: Make dns_query_id_seed unsigned

On Sat, Jan 18, 2020 at 02:04:12AM +0100, Tim Duesterhus wrote: > Left shifting of large signed values and negative values is undefined. Applied, thanks. Willy

Re: customize format of haproxy X-ForwardedFor ssl_c_s_dn during SSL termination

On Fri, Jan 17, 2020 at 03:09:53PM +0100, Tim Düsterhus wrote: > Elliot, > > Am 17.01.20 um 14:57 schrieb Elliot Otchet: > > Thanks again.  Update provided: - Fixes the issue Tim points out by using > > strcmp. - Corrects the argument spacing - Updates to include my name in the > > patch

Re: ARM(64) builds

On Fri, Jan 17, 2020 at 11:17 PM Martin Grigorov wrote: > > > On Fri, Jan 17, 2020, 23:12 William Lallemand > wrote: > >> On Fri, Jan 17, 2020 at 08:50:27PM +0200, Martin Grigorov wrote: >> > Testing with haproxy version: 2.2-dev0-70c5b0-123 >> >> This binary was built with code from 1 week

[PATCH] BUG/MINOR: dns: Make dns_query_id_seed unsigned

Left shifting of large signed values and negative values is undefined. In a test script clang's ubsan rightfully complains: > runtime error: left shift of 1934242336581872173 by 13 places cannot be > represented in type 'int64_t' (aka 'long') This bug was introduced in the initial version of

[PATCH] BUG/MINOR: cache: Fix leak of cache name in error path

This issue was introduced in commit 99a17a2d91f9044ea20bba6617048488aed80555 which first appeared in tag v1.9-dev11. This bugfix should be backported to HAProxy 1.9+. --- src/cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cache.c b/src/cache.c index

[PATCH] CLEANUP: Consistently `unsigned int` for bitfields

Willy, I did not touch the `struct pat_time` in pattern.h which appears to be completely unused. Please check whether adjustments should be made there as well or whether it should simply be removed. Feel free to amend my patch if necessary. Best regards Tim Düsterhus Apply with `git am

Re: ARM(64) builds

On Fri, Jan 17, 2020, 23:12 William Lallemand wrote: > On Fri, Jan 17, 2020 at 08:50:27PM +0200, Martin Grigorov wrote: > > Testing with haproxy version: 2.2-dev0-70c5b0-123 > > This binary was built with code from 1 week ago, it's normal that the test > does > not work since the fix was made

Re: ARM(64) builds

On Fri, Jan 17, 2020 at 08:50:27PM +0200, Martin Grigorov wrote: > Testing with haproxy version: 2.2-dev0-70c5b0-123 This binary was built with code from 1 week ago, it's normal that the test does not work since the fix was made this week. -- William Lallemand

Re: ARM(64) builds

On Fri, Jan 17, 2020 at 08:50:27PM +0200, Martin Grigorov wrote: > Hi William, > > Please find attached the output. > > this two lines look bad in it: > > *** h1 debug|[ALERT] 016/184150 (7188) : parsing [cur--1:0] : proxy > 'MASTER', another server named 'cur--1' was already defined at line

Re: ARM(64) builds

Hi Илья, On Fri, Jan 17, 2020 at 5:43 PM Илья Шипицин wrote: > > > пт, 17 янв. 2020 г. в 19:33, Martin Grigorov : > >> >> >> On Fri, Jan 17, 2020 at 4:13 PM Martin Grigorov < >> martin.grigo...@gmail.com> wrote: >> >>> Hi all, >>> >>> Today's build consistently fails on my ARM64 VM: >>> >>>

Re: ARM(64) builds

Hi William, On Fri, Jan 17, 2020 at 4:46 PM William Lallemand wrote: > On Fri, Jan 17, 2020 at 04:33:22PM +0200, Martin Grigorov wrote: > > > > git bisect blaims this commit: > > > > 25b569302167e71b32e569a2366027e8e320e80a is the first bad commit > > commit

Re: ARM(64) builds

пт, 17 янв. 2020 г. в 19:33, Martin Grigorov : > > > On Fri, Jan 17, 2020 at 4:13 PM Martin Grigorov > wrote: > >> Hi all, >> >> Today's build consistently fails on my ARM64 VM: >> >> ## Starting vtest ## >> Testing with haproxy version:

[PATCH] DOC: Fix copy and paste mistake in http-response replace-value doc

This fixes up commit 2252beb8557d73407b8f96eef91d6927fb855685. --- doc/configuration.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/configuration.txt b/doc/configuration.txt index 9ac898517..6f59fac3c 100644 --- a/doc/configuration.txt +++ b/doc/configuration.txt @@

Re: ARM(64) builds

On Fri, Jan 17, 2020 at 04:33:22PM +0200, Martin Grigorov wrote: > > git bisect blaims this commit: > > 25b569302167e71b32e569a2366027e8e320e80a is the first bad commit > commit 25b569302167e71b32e569a2366027e8e320e80a > Author: William Lallemand > Date: Tue Jan 14 15:38:43 2020 +0100 > >

Re: ARM(64) builds

On Fri, Jan 17, 2020 at 4:13 PM Martin Grigorov wrote: > Hi all, > > Today's build consistently fails on my ARM64 VM: > > ## Starting vtest ## > Testing with haproxy version: 2.2-dev0-70c5b0-123 > #top TEST reg-tests/mcli/mcli_start_progs.vtc

Re: ARM(64) builds

Hi all, Today's build consistently fails on my ARM64 VM: ## Starting vtest ## Testing with haproxy version: 2.2-dev0-70c5b0-123 #top TEST reg-tests/mcli/mcli_start_progs.vtc FAILED (3.004) exit=2 1 tests failed, 0 tests skipped, 34 tests

Re: customize format of haproxy X-ForwardedFor ssl_c_s_dn during SSL termination

Elliot, Am 17.01.20 um 14:57 schrieb Elliot Otchet: > Thanks again.  Update provided: - Fixes the issue Tim points out by using > strcmp. - Corrects the argument spacing - Updates to include my name in the > patch submission.  Yes, you can use my name. You missed on the commit message

Re: customize format of haproxy X-ForwardedFor ssl_c_s_dn during SSL termination

Tim, Willy, Thanks again.  Update provided: - Fixes the issue Tim points out by using strcmp. - Corrects the argument spacing - Updates to include my name in the patch submission.  Yes, you can use my name. Thanks! -Elliot On Friday, January 17, 2020, 5:58:43 AM EST, Willy Tarreau wrote:

Re: [PATCH v2 0/3] MINOR: lua: Add lua-prepend-path configuration option

Thierry, Am 14.01.20 um 19:37 schrieb Tim Düsterhus: > Willy, > > Am 14.01.20 um 14:53 schrieb Willy Tarreau: >> On Tue, Jan 14, 2020 at 02:04:04PM +0100, Thierry Fournier wrote: >>> Idea 1: >>> >>>lua-prepend-path path /etc/haproxy/lua-modules/?.lua >>>lua-prepend-path cpath

Re: customize format of haproxy X-ForwardedFor ssl_c_s_dn during SSL termination

On Fri, Jan 17, 2020 at 11:45:17AM +0100, Tim Düsterhus wrote: > I did not test, but if I am not mistaken this would allow "rfc2253XXX" > as the format parameter, no? Meaning: It allows one to append arbitrary > garbage to the rfc2253 value. > Judging from `smp_check_const_bool` in sample.c a

Re: customize format of haproxy X-ForwardedFor ssl_c_s_dn during SSL termination

Elliot, Am 17.01.20 um 05:35 schrieb Elliot Otchet: > An updated patch for your consideration.  Let me know what you think. > I have some very minor suggestions: > Subject: [PATCH] MEDIUM: ssl: Add support for returning the dn samples from > ssl_(c|f)_(i|s)_dn in LDAP v3 (RFC2253) format. >