[PATCH 4/4] MINOR: ssl: "show ssl cert" command should print the "Chain filename:"

2020-02-18 Thread Emmanuel Hocdet
Hi,Le 18 févr. 2020 à 11:45, Emmanuel Hocdet a écrit :I think we will probably need more information in the "show ssl cert"output in the future so the users can debug this kind of feature easily.Yes. Show the chain-filename would be very helpful.For that i think a good way would

Re: [PATCH] MINOR: ssl: add "issuers-chain-path" directive.

2020-02-18 Thread Илья Шипицин
вт, 18 февр. 2020 г. в 21:44, Emmanuel Hocdet : > > > Le 18 févr. 2020 à 14:36, William Lallemand a > écrit : > > > > On Tue, Feb 18, 2020 at 01:58:39PM +0100, Emmanuel Hocdet wrote: > >> > >>> Le 18 févr. 2020 à 11:45, Emmanuel Hocdet a écrit : > >>> > Can you add a little bit of

Re: [PATCH] MINOR: ssl: add "issuers-chain-path" directive.

2020-02-18 Thread Emmanuel Hocdet
> Le 18 févr. 2020 à 14:36, William Lallemand a écrit : > > On Tue, Feb 18, 2020 at 01:58:39PM +0100, Emmanuel Hocdet wrote: >> >>> Le 18 févr. 2020 à 11:45, Emmanuel Hocdet a écrit : >>> Can you add a little bit of explanation on how the discovery of the issuer is done in the

Re: [PATCH] compression/lua_validation.vtc depends on "which" utility

2020-02-18 Thread Willy Tarreau
On Tue, Feb 18, 2020 at 06:44:25PM +0500, ??? wrote: > when specifying "shell" in vtc, can we require posix /bin/sh ? or is it by > chance ? I suspect it's by default /bin/sh since not specified. I'm also seeing the string /bin/sh appearing in the vtest binary. Willy

Re: [PATCH] compression/lua_validation.vtc depends on "which" utility

2020-02-18 Thread William Lallemand
On Tue, Feb 18, 2020 at 06:44:25PM +0500, Илья Шипицин wrote: > when specifying "shell" in vtc, can we require posix /bin/sh ? or is it by > chance ? > > shell { > HOST=${h1_fe1_addr} > if [ "${h1_fe1_addr}" = "::1" ] ; then > HOST="\[::1\]" > fi > > md5=$(which md5 ||

Re: [PATCH] compression/lua_validation.vtc depends on "which" utility

2020-02-18 Thread Willy Tarreau
On Tue, Feb 18, 2020 at 02:29:08PM +0100, Tim Düsterhus wrote: > command -v is looking good to me: OK now pushed, thanks! Willy

Re: [PATCH] compression/lua_validation.vtc depends on "which" utility

2020-02-18 Thread Илья Шипицин
when specifying "shell" in vtc, can we require posix /bin/sh ? or is it by chance ? shell { HOST=${h1_fe1_addr} if [ "${h1_fe1_addr}" = "::1" ] ; then HOST="\[::1\]" fi md5=$(which md5 || which md5sum) вт, 18 февр. 2020 г. в 18:24, Willy Tarreau : > On Tue, Feb 18,

Re: [PATCH] MINOR: ssl: add "issuers-chain-path" directive.

2020-02-18 Thread William Lallemand
On Tue, Feb 18, 2020 at 01:58:39PM +0100, Emmanuel Hocdet wrote: > > > Le 18 févr. 2020 à 11:45, Emmanuel Hocdet a écrit : > > > >> Can you add a little bit of explanation on how the discovery of the > >> issuer is done in the documentation? > >> > > ok > > > documentation updated: >

Re: [PATCH] compression/lua_validation.vtc depends on "which" utility

2020-02-18 Thread Tim Düsterhus
Willy, Am 18.02.20 um 14:24 schrieb Willy Tarreau: > So we can only use "type" with no argument and adjust it. Or better, > we can use "command -v" which looks OK: > > bash$ command -v curl > /usr/local/bin/curl > dash$ command -v curl > /usr/local/bin/curl > ksh$ command -v curl >

Re: [PATCH] compression/lua_validation.vtc depends on "which" utility

2020-02-18 Thread Willy Tarreau
On Tue, Feb 18, 2020 at 02:15:18PM +0100, Tim Düsterhus wrote: > Willy, > > Am 18.02.20 um 14:06 schrieb Willy Tarreau: > > I haven't pushed yet Ilya's patch I've just merged, I'm fine with > > applying a change if preferred. Just let me know. > > `type` is required to be a builtin by POSIX [1].

Re: [PATCH] compression/lua_validation.vtc depends on "which" utility

2020-02-18 Thread Tim Düsterhus
Willy, Am 18.02.20 um 14:06 schrieb Willy Tarreau: > I haven't pushed yet Ilya's patch I've just merged, I'm fine with > applying a change if preferred. Just let me know. `type` is required to be a builtin by POSIX [1]. The `-p` parameter does not appear to be standardized, though. Nonetheless I

Re: [PATCH] compression/lua_validation.vtc depends on "which" utility

2020-02-18 Thread Willy Tarreau
On Sun, Feb 16, 2020 at 11:34:28AM +0100, Ionel GARDAIS wrote: > It's here on osx 10.11.6 at least. > Looks like a sh builtin. I haven't pushed yet Ilya's patch I've just merged, I'm fine with applying a change if preferred. Just let me know. Willy

Re: [PATCH] compression/lua_validation.vtc depends on "which" utility

2020-02-18 Thread Willy Tarreau
On Sun, Feb 16, 2020 at 12:38:46AM +0500, ??? wrote: > Hello, > > > that utility is not available by default in Fedora docker image. Not surprized, that's always the fun when relying on external tools. Now merged, thanks Ilya! Willy

Re: dns fails to process response / hold valid? (since commit 2.2-dev0-13a9232)

2020-02-18 Thread Baptiste
Hi guys, Thx Tim for investigating. I'll check the PCAP and see why such behavior happens. Baptiste On Tue, Feb 18, 2020 at 12:09 AM Tim Düsterhus wrote: > Pieter, > > Am 09.02.20 um 15:35 schrieb PiBa-NL: > > Before commit '2.2-dev0-13a9232, released 2020/01/22 (use additional > > records

Re: [PATCH] MINOR: ssl: add "issuers-chain-path" directive.

2020-02-18 Thread Emmanuel Hocdet
Le 18 févr. 2020 à 11:45, Emmanuel Hocdet a écrit :Can you add a little bit of explanation on how the discovery of theissuer is done in the documentation?okdocumentation updated: 0001-MINOR-ssl-add-issuers-chain-path-directive.patch Description: Binary data

Re: [PATCH] MINOR: ssl: add "issuers-chain-path" directive.

2020-02-18 Thread Emmanuel Hocdet
Hi William > Le 14 févr. 2020 à 15:59, William Lallemand a écrit : > > On Fri, Feb 14, 2020 at 03:25:48PM +0100, Emmanuel Hocdet wrote: >> Hi, >> >> Is there any hope that this proposal will be considered before HAproxy 2.2? >> >> ++ >> Manu > > Hello, > > I'm ok with the feature itself.