[PATCH] fix libslz url in travis

2020-05-18 Thread Илья Шипицин
Hello, travis timed out when downloading libslz fatal: unable to access 'http://git.1wt.eu/git/libslz.git/': Failed to connect to git.1wt.eu port 80: Connection timed out The command "git clone http://git.1wt.eu/git/libslz.git/; failed and exited with 128 during . it is something related to

Re: [PR] Add verfied chain

2020-05-18 Thread William Dauchy
Hi Arjen, On Mon, May 18, 2020 at 6:02 PM Arjen Nienhuis wrote: > I used PKCS7 because I did not know how to parse concatenated blobs. Mathilde, how did we planned to use it? :) > I think you should use SSL_get_peer_cert_chain because: > - BoringSSL has no SSL_get0_verified_chain. > - For

Re: [PR] Add verfied chain

2020-05-18 Thread Arjen Nienhuis
On 18-05-2020 15:57, William Lallemand wrote: On Mon, May 18, 2020 at 02:49:28PM +0200, William Dauchy wrote: Hello William L., On Wed, Dec 4, 2019 at 4:24 PM PR Bot wrote: Patch title(s): MINOR: add fetch 'ssl_c_verified_chain' Merge branch 'master' of

Re: [PR] Add verfied chain

2020-05-18 Thread Emeric Brun
Hi All, On 5/18/20 4:32 PM, William Dauchy wrote: > On Mon, May 18, 2020 at 3:58 PM William Lallemand > wrote: >> I suppose it was put in a PKCS7 container to be able to distinguish each >> DER part of the chain easily? So It can be used by an external tool. I'm not >> sure of what is done with

Re: [PR] Add verfied chain

2020-05-18 Thread William Dauchy
On Mon, May 18, 2020 at 3:58 PM William Lallemand wrote: > I suppose it was put in a PKCS7 container to be able to distinguish each > DER part of the chain easily? So It can be used by an external tool. I'm not > sure of what is done with the result of this. > > The two patches seem to have

Re: [PR] Add verfied chain

2020-05-18 Thread William Lallemand
On Mon, May 18, 2020 at 02:49:28PM +0200, William Dauchy wrote: > Hello William L., > > On Wed, Dec 4, 2019 at 4:24 PM PR Bot wrote: > > Patch title(s): > >MINOR: add fetch 'ssl_c_verified_chain' > >Merge branch 'master' of https://github.com/haproxy/haproxy > > Link: > >

Re: [PR] Add verfied chain

2020-05-18 Thread William Dauchy
Hello William L., On Wed, Dec 4, 2019 at 4:24 PM PR Bot wrote: > Patch title(s): >MINOR: add fetch 'ssl_c_verified_chain' >Merge branch 'master' of https://github.com/haproxy/haproxy > Link: >https://github.com/haproxy/haproxy/pull/396 > Edit locally: >wget

Re: [PATCH] DOC/MINOR: halog: Add long help info for ic flag

2020-05-18 Thread William Lallemand
On Fri, May 15, 2020 at 11:05:17PM +0200, Aleksandar Lazic wrote: > Hi. > > attached a patch for halog. > > Regards > > Aleks > From 37ba93a5f29200e34cfb31aacf93ddcd80fca2ab Mon Sep 17 00:00:00 2001 > From: Aleksandar Lazi > Date: Fri, 15 May 2020 22:58:30 +0200 > Subject: [PATCH] DOC/MINOR:

Re: [PATCH] cleanup: remove unused variable assignment (found by Coverity)

2020-05-18 Thread William Lallemand
On Sat, May 16, 2020 at 10:45:24PM +0500, Илья Шипицин wrote: > Hello, > > can we apply that patch ? > it removes single assignment, fixes #593 > > > Cheers, > Ilya Shipitcin > From e922cfb5e6e60f573c8861d3e10e6736be601d47 Mon Sep 17 00:00:00 2001 > From: Ilya Shipitsin > Date: Sat, 16 May

Re: [PATCH] BUILD: ssl: include buffer common headers for ssl_sock_ctx

2020-05-18 Thread William Lallemand
On Sun, May 17, 2020 at 01:41:53PM +0200, William Dauchy wrote: > since commit c0cdaffaa338 ("REORG: ssl: move ssl_sock_ctx and fix > cross-dependencies issues"), `struct ssl_sock_ctx` was moved in > ssl_sock.h. As it contains a `struct buffer`, including > `common/buffer.h` is now mandatory. I