Re: [PATCH] Fix memory leak from used_server_addr during deinit

2021-01-08 Thread Thayne McCombs
After actually reading the full CONTRIBUTING file, I now include my patch with a better commit message. Sorry about that. >From b449379a7b36c213408b1ae28924475c413bd6ba Mon Sep 17 00:00:00 2001 From: Thayne McCombs Date: Thu, 7 Jan 2021 22:11:05 -0700 Subject: [PATCH] BUG/MINOR: server: Memory l

Is it possible to show only sticky-table entries tracked via certain sticky counter number?

2021-01-08 Thread Andriy Raketskiy
Dear Sirs, For example, is it possible to view only entries tracked via sc1 in table 'main_frontend' in the following sample configuration: ... listen main_frontend ... stick-table type ip size 10k expire 30m store conn_cur,conn_rate(60s),http_req_rate(60s),http_err_rate(60s) tcp-request conn

[ANNOUNCE] haproxy-2.0.20

2021-01-08 Thread Willy Tarreau
Hi, HAProxy 2.0.20 was released on 2021/01/08. It added 59 new commits after version 2.0.19. Here come the bugs that were fixed since 2.0.19: - Gilchrist Dadaglo fixed a number of issues in the SPOA Python example, particularly on the error handling path. I seem to understand that most

[ANNOUNCE] haproxy-2.1.11

2021-01-08 Thread Willy Tarreau
Hi, HAProxy 2.1.11 was released on 2021/01/08. It added 65 new commits after version 2.1.10. I'd like to remind everyone that 2.1 is living its last months as its end of life was announced as Q1 2021 as anyone can see by typing "haproxy -v". As long as it doesn't hurt to emit a few more releases,

[ANNOUNCE] haproxy-2.2.7

2021-01-08 Thread Willy Tarreau
Hi, HAProxy 2.2.7 was released on 2021/01/08. It added 60 new commits after version 2.2.6. Here come the bugs that were fixed since 2.2.6: - Gilchrist Dadaglo fixed a number of issues in the SPOA Python example, particularly on the error handling path. I seem to understand that most of

[ANNOUNCE] haproxy-2.3.3

2021-01-08 Thread Willy Tarreau
Hi, HAProxy 2.3.3 was released on 2021/01/08. It added 74 new commits after version 2.3.2. Roughly half of them were bug though not many were that important, but it's nice to see that quite a number of people actually worked on them: - Gilchrist Dadaglo fixed a number of issues in the SPOA Pyth

[PATCH] CLEANUP: sample: remove uneeded check in json validation

2021-01-08 Thread William Dauchy
- check functions are never called with a NULL args list, it is always an array, so first check can be removed - the expression parser guarantees that we can't have anything else, because we mentioned json converter takes a mandatory string argument. Thus test on `ARGT_STR` can be removed as

Great content ideas for your blog

2021-01-08 Thread Stella Evans
Haproxy Editorial Team, My name is Stella & I am reaching out from datadome.co. Today I came across your post "Bot Protection with HAProxy"- https://www.haproxy.com/blog/bot-protection-with-haproxy/, I certainly respect the efforts you put into your content. Your content is engaging and infor

Re: [PATCH] DOC: Add maintainers for the Prometheus exporter

2021-01-08 Thread Willy Tarreau
On Fri, Jan 08, 2021 at 03:06:33PM +0100, Christopher Faulet wrote: > After a discussion with Willy and William about the Prometheus exporter, we > decided to officially introduce William as co-maintainer on this module. He > better knows than me the Prometheus usages and is better placed to discus

Re: [PATCH] A bunch of spelling fixes.

2021-01-08 Thread Willy Tarreau
Hi Thayne, On Thu, Jan 07, 2021 at 09:45:57PM -0700, Thayne McCombs wrote: > Here it is split up into multiple patches. > I also included a patch that adds a few words to the > ignore-words-list in the codespell workflow. Thank you, merged. However I've reworded all commit messages to put all t

[PATCH] DOC: Add maintainers for the Prometheus exporter

2021-01-08 Thread Christopher Faulet
Hi, After a discussion with Willy and William about the Prometheus exporter, we decided to officially introduce William as co-maintainer on this module. He better knows than me the Prometheus usages and is better placed to discuss about features and to decide how the exporter must evolved to b

Re: [PATCH v2] MINOR: contrib/prometheus-exporter: export build_info

2021-01-08 Thread Willy Tarreau
Hi William, On Fri, Jan 08, 2021 at 01:21:13PM +0100, William Dauchy wrote: > On Fri, Jan 8, 2021 at 1:18 PM William Dauchy wrote: > > Even though it is not a bugfix, this patch will make more sense when > > backported up to >= 2.0 > > Hopefully I'm not too late for the next v2.x.y batch release

Re: [PATCH v2] BUG/MINOR: hlua: Fix memory leak in hlua_alloc

2021-01-08 Thread Willy Tarreau
On Fri, Jan 08, 2021 at 10:35:33AM +0100, Tim Duesterhus wrote: > During a configuration check valgrind reports: > > ==14425== 0 bytes in 106 blocks are definitely lost in loss record 1 of > 107 > ==14425==at 0x4C2DB8F: malloc (in > /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so

Re: [PATCH] cleanup: switch to my_realloc2 instead of realloc

2021-01-08 Thread Willy Tarreau
On Thu, Jan 07, 2021 at 10:59:26PM +0500, ??? wrote: > patch resolving #1030 attached. Applied, thanks Ilya! Willy

Re: [PATCH] BUILD: Makefile: exclude broken tests by default

2021-01-08 Thread Willy Tarreau
On Thu, Jan 07, 2021 at 05:10:51PM +0100, William Dauchy wrote: > it could be sometimes a bit confusing to have tests which are known to > be broken executed in the default `make reg-tests` command, especially > for not frequent contributors which are not necessarily aware of all our > quirks. > >

Re: SSL session cache block size documentation

2021-01-08 Thread William Dauchy
Hello Valters, On Wed, Jan 6, 2021 at 4:26 PM Valters Jansons wrote: > There is a global parameter for SSL session cache block count > (tune.ssl.cachesize). Documentation for it currently states: A block > uses approximately 200 bytes of memory. > This estimate of 200B for each block has been the

Re: [PATCH v2] MINOR: contrib/prometheus-exporter: export build_info

2021-01-08 Thread William Dauchy
On Fri, Jan 8, 2021 at 1:18 PM William Dauchy wrote: > Even though it is not a bugfix, this patch will make more sense when > backported up to >= 2.0 Hopefully I'm not too late for the next v2.x.y batch releases, I really would like to include it to unblock some situations in other external tools

[PATCH v2] MINOR: contrib/prometheus-exporter: export build_info

2021-01-08 Thread William Dauchy
commit c55a626217a7e676e1cc ("MINOR: contrib/prometheus-exporter: Add missing global and per-server metrics") is renaming two metrics between v2.2 and v2.3: server_idle_connections_current server_idle_connections_limit It is breaking some tools which are making use of those metrics while suppo

[PATCH v2] BUG/MINOR: hlua: Fix memory leak in hlua_alloc

2021-01-08 Thread Tim Duesterhus
Willy, Thierry, v2 fixes the commit message (adding a missing 'hlua:' after the type and severity) and also reduces the amount of duplicated code. Best regards Tim Düsterhus Apply with `git am --scissors` to automatically cut the commit message. -- >8 -- During a configuration check valgrind re