Re: 'show errors' - logging & reasons

2021-04-03 Thread Robin H. Johnson
On Fri, Apr 02, 2021 at 06:38:35PM +0200, Willy Tarreau wrote: > > This has come out of cases where we upgraded HAProxy 1.8 -> 2.2, and > > $work customers started reporting requests that previously worked fine > > now return 400 Invalid Request errors. > That's never good. Often it indicates that

[PATCH 2/2] CLEANUP: ist: Remove unused `count` argument from `ist2str*`

2021-04-03 Thread Tim Duesterhus
This argument is not being used inside the function (and the functions themselves are unused as well) and not documented. Its purpose is not clear. Just remove it. --- include/import/ist.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/import/ist.h

[PATCH 1/2] CLEANUP: htx: Make http_get_stline take a `const struct`

2021-04-03 Thread Tim Duesterhus
Nothing is being modified there, so this can be `const`. --- include/haproxy/http_htx.h | 2 +- src/http_htx.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/haproxy/http_htx.h b/include/haproxy/http_htx.h index fbd4438de..d807584de 100644 ---