Re: [PATCH 0/1] CI: revert entropy hack

2024-04-12 Thread Willy Tarreau
On Fri, Apr 12, 2024 at 12:42:51PM +0200, ??? wrote: > ping :) Ah thanks for the reminder. I noticed it a few days ago and I wanted to ask you to please include a commit message explaining why it's no longer necessary. We don't need much, just to understand the rationale for the removal.

Re: [PATCH] MINOR: config: rhttp: Downgrade error on attach-srv name parsing

2024-04-12 Thread William Manley
On Fri, Apr 12, 2024, at 4:01 PM, Amaury Denoyelle wrote: > I have a doubt though, will this kind of configuration really works ? I > though that for the moment if name parameter is specified, it is > mandatory to use a server with SSL+SNI. It may be mandatory according to the RFC, but I'm not

Re: [PATCH] MINOR: config: rhttp: Downgrade error on attach-srv name parsing

2024-04-12 Thread Willy Tarreau
On Fri, Apr 12, 2024 at 05:01:07PM +0200, Amaury Denoyelle wrote: > On Fri, Apr 12, 2024 at 03:37:56PM +0200, Willy Tarreau wrote: > > Hi! > > On Fri, Apr 12, 2024 at 02:29:30PM +0100, William Manley wrote: > > > An attach-srv config line usually looks like this: > > > > tcp-request session

Re: [PATCH] MINOR: config: rhttp: Downgrade error on attach-srv name parsing

2024-04-12 Thread William Manley
On Fri, Apr 12, 2024, at 2:37 PM, Willy Tarreau wrote: > Well, I consider that any valid (and useful) configuration must be > writable without a warning. So if you have a valid use case with a > different expression, here you still have no way to express it without > the warning. In this case I'd

[PATCH] MINOR: config: rhttp: Don't require SSL when attach-srv name parsing

2024-04-12 Thread William Manley
An attach-srv config line usually looks like this: tcp-request session attach-srv be/srv name ssl_c_s_dn(CN) while a rhttp server line usually looks like this: server srv rhttp@ sni req.hdr(host) The server sni argument is used as a key for looking up connection in the connection pool.

Re: [PATCH] MINOR: config: rhttp: Downgrade error on attach-srv name parsing

2024-04-12 Thread Amaury Denoyelle
On Fri, Apr 12, 2024 at 03:37:56PM +0200, Willy Tarreau wrote: > Hi! > On Fri, Apr 12, 2024 at 02:29:30PM +0100, William Manley wrote: > > An attach-srv config line usually looks like this: > > > tcp-request session attach-srv be/srv name ssl_c_s_dn(CN) > > > The name is a key that is used

Re: [PATCH] MINOR: config: rhttp: Downgrade error on attach-srv name parsing

2024-04-12 Thread Willy Tarreau
Hi! On Fri, Apr 12, 2024 at 02:29:30PM +0100, William Manley wrote: > An attach-srv config line usually looks like this: > > tcp-request session attach-srv be/srv name ssl_c_s_dn(CN) > > The name is a key that is used when looking up connections in the > connection pool. Without this patch

[PATCH] MINOR: config: rhttp: Downgrade error on attach-srv name parsing

2024-04-12 Thread William Manley
An attach-srv config line usually looks like this: tcp-request session attach-srv be/srv name ssl_c_s_dn(CN) The name is a key that is used when looking up connections in the connection pool. Without this patch you'd get an error if you passed anything other than "ssl_c_s_dn(CN)" as the

Re: [PATCH 0/1] CI: revert entropy hack

2024-04-12 Thread Илья Шипицин
ping :) сб, 6 апр. 2024 г. в 15:38, Ilya Shipitsin : > hack introduced in 3a0fc8641b1549b00cd3125107545b6879677801 might be > reverted > > Ilya Shipitsin (1): > CI: revert kernel entropy introduced in > 3a0fc8641b1549b00cd3125107545b6879677801 > > .github/workflows/vtest.yml | 11

[PR] DOC: management: fix typos

2024-04-12 Thread PR Bot
Dear list! Author: Andrey Lebedev Number of patches: 1 This is an automated relay of the Github pull request: DOC: management: fix typos Patch title(s): DOC: management: fix typos Link: https://github.com/haproxy/haproxy/pull/2528 Edit locally: wget

Re: Changes in HAProxy 3.0's Makefile and build options

2024-04-12 Thread Tristan
Hi Willy, > On 11 Apr 2024, at 18:18, Willy Tarreau wrote: > > Some distros simply found that stuffing their regular CFLAGS into > DEBUG_CFLAGS or CPU_CFLAGS does the trick most of the time. Others use > other combinations depending on the tricks they figured. Good to know I wasn’t alone

Re: Changes in HAProxy 3.0's Makefile and build options

2024-04-12 Thread William Lallemand
On Thu, Apr 11, 2024 at 11:43:14PM +0200, Dinko Korunic wrote: > Subject: Re: Changes in HAProxy 3.0's Makefile and build options > > > On 11.04.2024., at 21:32, William Lallemand wrote: > > > > If I remember correctly github actions VMs only had 2 vCPU in the past, > > I think they upgraded to