Re: cygwin compilation error

2019-05-08 Thread Илья Шипицин
ср, 8 мая 2019 г. в 13:03, Willy Tarreau : > Hi Ilya, > > On Wed, May 08, 2019 at 11:34:57AM +0500, ??? wrote: > > From ad9961e92c692430272c9088a49759c889dac6f1 Mon Sep 17 00:00:00 2001 > > From: Ilya Shipitsin > > Date: Wed, 8 May 2019 11:32:02 +0500 > > Subject: [PATCH] BUILD: do not

Re: haproxy-1.9 sanitizers finding

2019-05-08 Thread Илья Шипицин
I would like to run sanitizers before new 1.9 release is out On Wed, May 8, 2019, 10:54 AM Willy Tarreau wrote: > Hi Ilya, > > On Tue, May 07, 2019 at 11:47:54AM +0500, ??? wrote: > > Hello, > > > > when running regtests against 1.9 branch there are findings (not seen in > > master

Re: cygwin compilation error

2019-05-08 Thread Илья Шипицин
I messed up with commit message. One more try ср, 8 мая 2019 г. в 11:33, Илья Шипицин : > small fix > > ср, 8 мая 2019 г. в 11:12, Willy Tarreau : > >> On Wed, May 08, 2019 at 11:09:04AM +0500, ??? wrote: >> > ??, 8 ??? 2019 ?. ? 11:06, Willy Tarreau : >&

Re: cygwin compilation error

2019-05-08 Thread Илья Шипицин
small fix ср, 8 мая 2019 г. в 11:12, Willy Tarreau : > On Wed, May 08, 2019 at 11:09:04AM +0500, ??? wrote: > > ??, 8 ??? 2019 ?. ? 11:06, Willy Tarreau : > > > > > On Wed, May 08, 2019 at 10:59:20AM +0500, ??? wrote: > > > > travis-ci supports windows builds. > > > > > > cool!

Re: cygwin compilation error

2019-05-08 Thread Илья Шипицин
ср, 8 мая 2019 г. в 11:06, Willy Tarreau : > On Wed, May 08, 2019 at 10:59:20AM +0500, ??? wrote: > > travis-ci supports windows builds. > > cool! > my current roadmap is 1) patch fixes SSL variants (already sent to list). without it we are NOT building LibreSSL at all (i.e. we use

Re: cygwin compilation error

2019-05-08 Thread Илья Шипицин
travis-ci supports windows builds. I will add such build a bit later (after we settle with current travis-ci fixes) ср, 8 мая 2019 г. в 10:52, Willy Tarreau : > Hi, > > On Mon, May 06, 2019 at 12:54:47PM +0300, Gil Bahat wrote: > > Hi, > > > > is cygwin still supported anymore? > > Well, we

haproxy-1.9 sanitizers finding

2019-05-07 Thread Илья Шипицин
Hello, when running regtests against 1.9 branch there are findings (not seen in master branch) *** h10.0 debug|= *** h10.0 debug|==16493==ERROR: AddressSanitizer: heap-use-after-free on address 0x61903c95 at pc

gcc address sanitizer finding

2019-05-06 Thread Илья Шипицин
Hello, I built haproxy using gcc-9 make CC=gcc V=1 TARGET=linux2628 USE_ZLIB=1 USE_PCRE=1 USE_PCRE_JIT=1 USE_LUA=1 USE_OPENSSL=1 DEBUG_CFLAGS="-g -fsanitize=address" LDFLAGS="-lasan" finding is: *** h10.1 debug|==8326==ERROR: LeakSanitizer: detected memory leaks *** h10.1 debug| ***

Re: [PR] BUILD: extend travis-ci matrix

2019-05-06 Thread Илья Шипицин
I have just noticed that "scripts/build-ssl.sh" is missing in .travis.yml so, unfortunately, we are running all builds against xenial openssl-1.0.2 (no openssl-1.1.X, no libressl...) I'm not sure when "scripts/build-ssl.sh" disappeared. I'll send new patch soon пн, 6 мая 2019 г. в 11:05, Willy

Re: reg-tests are broken when running osx + openssl

2019-05-06 Thread Илья Шипицин
surprisingly, LibreSSL builds are green пн, 6 мая 2019 г. в 13:03, Willy Tarreau : > On Mon, May 06, 2019 at 12:54:06PM +0500, ??? wrote: > > there's some random failure > > > > https://travis-ci.com/haproxy/haproxy/jobs/197824840 > > > > looks like test is not stable > > isn't it

Re: reg-tests are broken when running osx + openssl

2019-05-06 Thread Илья Шипицин
there's some random failure https://travis-ci.com/haproxy/haproxy/jobs/197824840 looks like test is not stable пн, 6 мая 2019 г. в 11:11, Willy Tarreau : > On Sun, May 05, 2019 at 10:11:38PM +0200, Frederic Lecaille wrote: > > I had no access to any travis environment when it has been told in

Re: [PR] BUILD: extend travis-ci matrix

2019-05-06 Thread Илья Шипицин
well, I hope travis-ci will be useful (or we will drop it). as for PR, I meant that it should have been sent to list anyway (but it was not sent for some reason). I can send using "git send email" as well пн, 6 мая 2019 г. в 11:05, Willy Tarreau : > Hi Ilya, > > > I made another PR > > > >

recent LibreSSL regressions

2019-05-05 Thread Илья Шипицин
hello, when I first sent LibreSSL patches (it was 27th April 2019), reg-tests were ok. I suspect recent 0RTT patches could break LibreSSL things can someone have a look ? https://travis-ci.org/chipitsine/haproxy-1/builds/528535120 thanks! Ilya Shipitcin

Re: [PR] BUILD: extend travis-ci matrix

2019-05-05 Thread Илья Шипицин
г. в 23:29, Илья Шипицин : > something has changed. build is passing now, reg-tests fail (they used to > work earlier) > > > I'd apply those patches (and we will fix reg-tests later) > > вс, 5 мая 2019 г. в 15:51, Willy Tarreau : > >> On Sun, May 05, 2019 at 02:26:

Re: clang address sanitizer findings

2019-05-05 Thread Илья Шипицин
with sanitizer: $ objdump -h haproxy haproxy: file format elf64-x86-64 Sections: Idx Name Size VMA LMA File off Algn 0 .interp 001c 004002e0 004002e0 02e0 2**0 CONTENTS, ALLOC, LOAD, READONLY,

Re: [PR] BUILD: extend travis-ci matrix

2019-05-05 Thread Илья Шипицин
something has changed. build is passing now, reg-tests fail (they used to work earlier) I'd apply those patches (and we will fix reg-tests later) вс, 5 мая 2019 г. в 15:51, Willy Tarreau : > On Sun, May 05, 2019 at 02:26:11PM +0500, ??? wrote: > > can we also apply patch from > >

clang address sanitizer findings

2019-05-05 Thread Илья Шипицин
Hello, I run fedora 30, it includes clang-8, I built haproxy using make CC=clang V=1 TARGET=$TARGET $FLAGS DEBUG_CFLAGS="-fsanitize=address -ggdb" LDFLAGS="-fsanitize=address" when running reg-tests, the following is caught ==6340==ERROR: AddressSanitizer: global-buffer-overflow on address

Re: [PR] BUILD: extend travis-ci matrix

2019-05-05 Thread Илья Шипицин
can we also apply patch from https://www.mail-archive.com/haproxy@formilux.org/msg33439.html ? it should repair libressl builds вс, 5 мая 2019 г. в 13:25, Willy Tarreau : > On Fri, May 03, 2019 at 10:23:05AM +, PR Bot wrote: > > Description: > >added openssl-1.0.2, 1.1.0, 1.1.1,

Re: findings of gcc address sanitizer

2019-05-05 Thread Илья Шипицин
nice, I will add sanitizers to travis-ci matrix вс, 5 мая 2019 г. в 13:18, Willy Tarreau : > Hi Ilya, > > On Fri, May 03, 2019 at 06:58:19PM +0500, ??? wrote: > > *** h10.1 debug|#0 0x6db986 in update_log_hdr src/log.c:1399 > (...) > > *** h10.1 debug|previously allocated

Re: Zero RTT in backend server side

2019-05-03 Thread Илья Шипицин
libressl is known to present "bigger than openssl-1.1.1" version (while lacking many features) let us wait for libressl+travis-ci patch approval сб, 4 мая 2019 г. в 00:09, Olivier Houchard : > Hi Igor, > > On Fri, May 03, 2019 at 05:21:50PM +0800, Igor Pav wrote: > > Just tested with openssl

Re: reg-tests are broken when running osx + openssl

2019-05-03 Thread Илья Шипицин
I would even use shorter path, i.e. mkdir ~/t пт, 3 мая 2019 г. в 22:27, Frederic Lecaille : > On 5/3/19 5:35 PM, Frederic Lecaille wrote: > > On 5/3/19 3:44 PM, Илья Шипицин wrote: > >> > >> > >> пт, 3 мая 2019 г. в 18:42, Tim Düsterhus >> <m

findings of gcc address sanitizer

2019-05-03 Thread Илья Шипицин
Hello, I run reg-tests on gcc-9 (fedora 30). I built haproxy the following way make CC=gcc V=1 TARGET=$TARGET $FLAGS DEBUG_CFLAGS="-fsanitize=address -ggdb" LDFLAGS="-lasan" asan found couple of things *** h10.1 debug|#0 0x6db986 in update_log_hdr src/log.c:1399 *** h10.1 debug|

Re: reg-tests are broken when running osx + openssl

2019-05-03 Thread Илья Шипицин
пт, 3 мая 2019 г. в 18:42, Tim Düsterhus : > Ilya, > > Am 03.05.19 um 15:39 schrieb Илья Шипицин: > > when I played with enabling travis-ci, I tried to set TMPDIR directly, > > however I was not lucky enough. > > Later Tim added "sed" magic to .travis.yml &g

Re: reg-tests are broken when running osx + openssl

2019-05-03 Thread Илья Шипицин
пт, 3 мая 2019 г. в 18:33, Frederic Lecaille : > On 5/3/19 1:34 PM, Tim Düsterhus wrote: > > Fred, > > Ilya, > > Hello Tim, > > > Am 03.05.19 um 13:20 schrieb Frederic Lecaille: > >> About the test which fail, I would say that such errors are not > >> negligible : > >> > >> Starting frontend

reg-tests are broken when running osx + openssl

2019-05-03 Thread Илья Шипицин
Hello, I'm expanding openssl matrix. here's failing build https://travis-ci.org/chipitsine/haproxy-1/jobs/527683332

PATCH: fix typo

2019-04-30 Thread Илья Шипицин
Hello, typo was found by cppcheck thank! Ilya Shipitsin From 62c6b78843e9c1b6f829872a54175f68332a2859 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Tue, 30 Apr 2019 21:21:28 +0500 Subject: [PATCH] MINOR: fix typo "src" instead of "srv" --- src/server.c | 2 +- 1 file changed, 1

PATCH: enable cirrus-ci (freebsd builds)

2019-04-30 Thread Илья Шипицин
Hello. I enabled basic freebsd CI (yet, it need to be enabled on github.com in few easy steps) thanks! Ilya Shipitcin From c0feb90929b1e8f1987dde27fc9f57c9b6d8fc36 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Tue, 30 Apr 2019 15:33:36 +0500 Subject: [PATCH] BUILD: enable freebsd builds

Re: reg-tests fail on FreeBSD 12.0

2019-04-30 Thread Илья Шипицин
It still fails on 12, I applied patch, run test. So, I suggest to disable it On Tue, Apr 30, 2019, 2:43 PM Frederic Lecaille wrote: > On 4/30/19 11:24 AM, Илья Шипицин wrote: > > you are right. > > > > let us exclude that particular test from freebsd (what your patch >

Re: reg-tests fail on FreeBSD 12.0

2019-04-30 Thread Илья Шипицин
you are right. let us exclude that particular test from freebsd (what your patch exactly does) вт, 30 апр. 2019 г. в 13:57, Илья Шипицин : > > > вт, 30 апр. 2019 г. в 13:32, Frederic Lecaille : > >> On 4/30/19 10:04 AM, Илья Шипицин wrote: >> > Hello, Frederic &g

Re: reg-tests fail on FreeBSD 12.0

2019-04-30 Thread Илья Шипицин
вт, 30 апр. 2019 г. в 13:32, Frederic Lecaille : > On 4/30/19 10:04 AM, Илья Шипицин wrote: > > Hello, Frederic > > > > I have applied only that part > > > > barrier b cond 3 > > @@ -29,7 +30,7 @@ syslog S3 -level notice { > > recv > >

Re: reg-tests fail on FreeBSD 12.0

2019-04-30 Thread Илья Шипицин
1 DOWN." } -start it works, test is green now (on freebsd) https://cirrus-ci.com/task/6252507322908672 пн, 29 апр. 2019 г. в 19:14, Frederic Lecaille : > On 4/29/19 3:56 PM, Илья Шипицин wrote: > > well, in cirrus-ci we can choose several freebsd images. I just picked > > up

Re: reg-tests fail on FreeBSD 12.0

2019-04-29 Thread Илья Шипицин
un freebsd builds in "build only mode", no reg tests 4) ... пн, 29 апр. 2019 г. в 18:36, Frederic Lecaille : > On 4/29/19 2:18 PM, Frederic Lecaille wrote: > > On 4/27/19 1:28 AM, Илья Шипицин wrote: > >> please have a look > >> > >> > >> bu

fix LibreSSL builds

2019-04-27 Thread Илья Шипицин
Hi, I tested the following patch on LibreSSL-2.7.5, 2.8.3, 2.9.1 thanks! Ilya Shipitcin From 12c3a7b0eac4bab73864869bf8fcb365c9ba06ef Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Sun, 28 Apr 2019 00:00:16 +0500 Subject: [PATCH] BUILD: add defines to support LibreSSL tested on

reg-tests fail on FreeBSD 12.0

2019-04-26 Thread Илья Шипицин
please have a look build script: https://github.com/chipitsine/haproxy-1/commit/6739f36463dc9e82eb65a9fa8353a42128403f0c build log (error): https://api.cirrus-ci.com/v1/task/5196617547251712/logs/main.log any idea ? thanks! Ilya Shipicin

Re: [PATCH v2] MINOR: travis: Extend .travis.yml

2019-04-25 Thread Илья Шипицин
Yes, I did have a look as well, those failures did not look like something we would wish to ignore )) Also, I'd suggest to extend osx build to include more features. I will do it soon On Thu, Apr 25, 2019, 12:00 PM Willy Tarreau wrote: > On Thu, Apr 25, 2019 at 08:26:37AM +0200, Willy Tarreau

Re: [PATCH v2] MINOR: travis: Extend .travis.yml

2019-04-24 Thread Илья Шипицин
gh tons of logs. The > details can then be found collapsed at the bottom. > > Best regards > Tim Düsterhus > > Am 24.04.2019 16:59 schrieb Илья Шипицин : > > Tim, I'm bit curious about > > after_failure: > - | > for folder in ${TMPDIR:-/tmp}/*regtest*/vtc.*; do >

Re: [PATCH v2] MINOR: travis: Extend .travis.yml

2019-04-24 Thread Илья Шипицин
, 24 апр. 2019 г. в 19:21, Илья Шипицин : > here's "v2" > > ср, 24 апр. 2019 г. в 18:56, Илья Шипицин : > >> I can test myself and send "v2" in couple of hours if you do not mind >> >> ср, 24 апр. 2019 г. в 18:48, Tim Düsterhus : >> >>

Re: [PATCH v2] MINOR: travis: Extend .travis.yml

2019-04-24 Thread Илья Шипицин
here's "v2" ср, 24 апр. 2019 г. в 18:56, Илья Шипицин : > I can test myself and send "v2" in couple of hours if you do not mind > > ср, 24 апр. 2019 г. в 18:48, Tim Düsterhus : > >> Willy, >> Ilya, >> >> I'm not in the office today and can

Re: how to specify CFLAGS ?

2019-04-24 Thread Илья Шипицин
I've managed to pass sanitizer flags )) I will add something like that to travis-ci later *** h10.1 debug|==19083==ERROR: AddressSanitizer: global-buffer-overflow on address 0x00a8cda8 at pc 0x006efec0 bp 0x7ffc78cfc990 sp 0x7ffc78cfc988 *** h10.1 debug|READ of size 8 at

Re: [PATCH v2] MINOR: travis: Extend .travis.yml

2019-04-24 Thread Илья Шипицин
I'd accept "Extend .travis.yml" patch except "allow_failures" Tim, do you mind to send "v2" ? ср, 24 апр. 2019 г. в 17:45, Willy Tarreau : > Hi Ilya, > > On Tue, Apr 23, 2019 at 09:37:27PM +0200, Willy Tarreau wrote: > > On Wed, Apr 24, 2019 at 12:30:36AM +0500, ??? wrote: > > > > >

how to specify CFLAGS ?

2019-04-24 Thread Илья Шипицин
Hello, I'm going to use various sanitizers, for example CFLAGS="-fsanitize=address" I'm looking for preferred way to set additional CFLAGS, am I right that it is something like ADDINC="-fsanitize=address" ? any other way ? thanks! Ilya Shipitsin

Re: [PATCH v2] MINOR: travis: Extend .travis.yml

2019-04-23 Thread Илья Шипицин
вт, 23 апр. 2019 г. в 23:25, Willy Tarreau : > On Tue, Apr 23, 2019 at 10:31:05PM +0500, ??? wrote: > > Hello, Baptise! > > > > we have enabled travis-ci builds on haproxy master branch. seems we have > a > > regression here: > > > > >

Re: [PATCH v2] MINOR: travis: Extend .travis.yml

2019-04-23 Thread Илья Шипицин
yep, I'm going to invest some time in building openssl matrix on travis-ci, i.e. openssl-1.0, 1.0.2, 1.1.1, libressl, ... вт, 23 апр. 2019 г. в 22:31, Willy Tarreau : > On Tue, Apr 23, 2019 at 10:11:09PM +0500, ??? wrote: > > I want to bisect in order to find offending commit. > > we've

Re: [PATCH v2] MINOR: travis: Extend .travis.yml

2019-04-23 Thread Илья Шипицин
this particular regression is reproduced on my fedora laptop, which is openssl-1.1.X вт, 23 апр. 2019 г. в 22:31, Willy Tarreau : > On Tue, Apr 23, 2019 at 10:11:09PM +0500, ??? wrote: > > I want to bisect in order to find offending commit. > > we've got regression. it need to be fixed,

Re: [PATCH v2] MINOR: travis: Extend .travis.yml

2019-04-23 Thread Илья Шипицин
-ci.com/haproxy/haproxy/builds/109289462 вт, 23 апр. 2019 г. в 22:11, Илья Шипицин : > I want to bisect in order to find offending commit. > we've got regression. it need to be fixed, no need to mark it as "allowed > failure" > > вт, 23 апр. 2019 г. в 22:00, Willy Tarr

Re: [PATCH v2] MINOR: travis: Extend .travis.yml

2019-04-23 Thread Илья Шипицин
I want to bisect in order to find offending commit. we've got regression. it need to be fixed, no need to mark it as "allowed failure" вт, 23 апр. 2019 г. в 22:00, Willy Tarreau : > On Tue, Apr 23, 2019 at 09:20:52PM +0500, ??? wrote: > > let us wait for a while and do not enable "allow

Re: [PATCH v2] MINOR: travis: Extend .travis.yml

2019-04-23 Thread Илья Шипицин
let us wait for a while and do not enable "allow failures". вт, 23 апр. 2019 г. в 20:24, Willy Tarreau : > On Tue, Apr 23, 2019 at 04:41:44PM +0200, Tim Düsterhus wrote: > > List, > > > > Am 23.04.19 um 16:40 schrieb Tim Duesterhus: > > > [...] > > > > Sorry for the noise. This v2 only differs

Re: [PATCH] FEATURE/MEDIUM: enable travis-ci builds

2019-04-23 Thread Илья Шипицин
вт, 23 апр. 2019 г. в 14:50, Willy Tarreau : > Hi Tim, > > On Tue, Apr 23, 2019 at 11:28:22AM +0200, Tim Düsterhus wrote: > > No real management necessary. > (...) > > Ideally you should not notice anything: It means no one commited bad > > code. It might need some adjustments in the beginning,

Re: [PATCH] FEATURE/MEDIUM: enable travis-ci builds

2019-04-22 Thread Илья Шипицин
I can enable travis-ci by myself if you can temporarily grant me an access to github repo пт, 19 апр. 2019 г. в 01:03, Илья Шипицин : > > > чт, 18 апр. 2019 г. в 21:51, Илья Шипицин : > >> >> >> чт, 18 апр. 2019 г. в 21:45, Willy Tarreau : >> >>> H

Re: [PATCH] FEATURE/MEDIUM: enable travis-ci builds

2019-04-18 Thread Илья Шипицин
чт, 18 апр. 2019 г. в 21:51, Илья Шипицин : > > > чт, 18 апр. 2019 г. в 21:45, Willy Tarreau : > >> Hi Ilya, >> >> On Wed, Apr 17, 2019 at 01:06:11PM +0500, ??? wrote: >> > btw, we can run lua tests >> > >> > https://travis-ci.com/

Re: [PATCH] FEATURE/MEDIUM: enable travis-ci builds

2019-04-18 Thread Илья Шипицин
чт, 18 апр. 2019 г. в 21:45, Willy Tarreau : > Hi Ilya, > > On Wed, Apr 17, 2019 at 01:06:11PM +0500, ??? wrote: > > btw, we can run lua tests > > > > https://travis-ci.com/chipitsine/haproxy-1/builds/108641032 > > > > so... how do we want to run lua ? always enabled ? or two builds

Re: [PATCH] FEATURE/MEDIUM: enable travis-ci builds

2019-04-17 Thread Илья Шипицин
btw, we can run lua tests https://travis-ci.com/chipitsine/haproxy-1/builds/108641032 so... how do we want to run lua ? always enabled ? or two builds (with and without lua) ? ср, 17 апр. 2019 г. в 12:43, Илья Шипицин : > I attached v2 patch > > ср, 17 апр. 2019 г. в 12:25, Иль

Re: [PATCH] FEATURE/MEDIUM: enable travis-ci builds

2019-04-17 Thread Илья Шипицин
I attached v2 patch ср, 17 апр. 2019 г. в 12:25, Илья Шипицин : > > > ср, 17 апр. 2019 г. в 12:18, Frederic Lecaille : > >> On 4/16/19 8:17 PM, Илья Шипицин wrote: >> > + - make CC=$CC V=1 TARGET=$TARGET >> > + - export PATH=${PATH}:${PWD}/VTest >> &

Re: running reg-test when haproxy is built without USE_OPENSSL

2019-04-17 Thread Илья Шипицин
ср, 17 апр. 2019 г. в 12:14, Frederic Lecaille : > On 4/17/19 9:01 AM, Илья Шипицин wrote: > > Hello, > > Hi, > > > when playing with travis-ci build matrix, I see that the following tests > > fail > > > > reg-tests/ssl/* > > > > if hapro

Re: [PATCH] FEATURE/MEDIUM: enable travis-ci builds

2019-04-17 Thread Илья Шипицин
ср, 17 апр. 2019 г. в 12:18, Frederic Lecaille : > On 4/16/19 8:17 PM, Илья Шипицин wrote: > > + - make CC=$CC V=1 TARGET=$TARGET > > + - export PATH=${PATH}:${PWD}/VTest > > + - export VTEST_PROGRAM="VTest/vtest -v" # "VTest/vtest -v" > &g

exclude some reg-tests if no ssl or pcre is enabled

2019-04-17 Thread Илья Шипицин
hello, when playing with travis-ci, I've found that ssl, pcre tests are executed even if haproxy is built without such features. thanks! Ilya Shipitcin From 5e786e8bc2a12ad4b53e3fdbfc3464738fd4e6df Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Wed, 17 Apr 2019 12:19:56 +0500 Subject:

running reg-test when haproxy is built without USE_OPENSSL

2019-04-17 Thread Илья Шипицин
Hello, when playing with travis-ci build matrix, I see that the following tests fail reg-tests/ssl/* if haproxy is built without ssl. also, I've found that lua tests are guarded with #REQUIRE_OPTIONS=LUA should we guard ssl test in the same way ? thank! Ilya Shipitcin

Re: [PATCH] FEATURE/MEDIUM: enable travis-ci builds

2019-04-17 Thread Илья Шипицин
ср, 17 апр. 2019 г. в 07:29, Willy Tarreau : > Hi Ilya, > > On Tue, Apr 16, 2019 at 11:17:49PM +0500, ??? wrote: > > +env: > > + global: > > +- USE_THREAD=1 > > +- USE_OPENSSL=1 > > +- USE_PCRE=1 > > +- USE_ZLIB=1 > > +- USE_GETADDRINFO=1 > > It's unclear to me how

Re: [PATCH] FEATURE/MEDIUM: enable travis-ci builds

2019-04-17 Thread Илья Шипицин
ср, 17 апр. 2019 г. в 07:14, Willy Tarreau : > On Tue, Apr 16, 2019 at 08:31:04PM +0200, Lukas Tribus wrote: > > Hello Ilya , > > > > On Tue, 16 Apr 2019 at 20:18, ??? wrote: > > > > > > Hello, > > > > > > let us enable travis-ci on https://github.com/haproxy/haproxy > > > (more builds

[PATCH] FEATURE/MEDIUM: enable travis-ci builds

2019-04-16 Thread Илья Шипицин
Hello, let us enable travis-ci on https://github.com/haproxy/haproxy (more builds will be added later) thanks! Ilya Shipitcin From 0eebbedaef858267b637fd0d05751f1e212eae61 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Tue, 16 Apr 2019 23:08:14 +0500 Subject: [PATCH] FEATURE/MEDIUM:

Re: how does ./reg-tests/seamless-reload/b00000.vtc should work ?

2019-04-16 Thread Илья Шипицин
red/green build: https://travis-ci.com/chipitsine/haproxy-1/builds/108555034 вт, 16 апр. 2019 г. в 21:16, Willy Tarreau : > On Tue, Apr 16, 2019 at 05:42:41PM +0200, William Lallemand wrote: > > Hi Ilya, > > > > This is a regression due to recent changes in the master-worker. > > I also found a

bad guarding of reg-tests

2019-04-16 Thread Илья Шипицин
hello, when I played with travis-ci, I've found the following 1) travis-ci uses ubuntu trusty, which comes with openssl-1.0.1, obviously no ALPN. some reg-tests expect ALPN in curl 2) tests do not check whether haproxy is built with USE_PCRE=1 (but they assume that) thanks, Ilya Shipitcin

how does ./reg-tests/seamless-reload/b00000.vtc should work ?

2019-04-16 Thread Илья Шипицин
Hello, I'm trying to get travis-ci working. currently I stuck with https://travis-ci.com/chipitsine/haproxy-1/jobs/193239855 can you help me with that issue ? Thanks, Ilya Shipitcin

Re: who controls https://github.com/haproxy/haproxy ?

2019-04-12 Thread Илья Шипицин
yep, I'm going to play in my own fork as well. I will show something soon пт, 12 апр. 2019 г. в 16:50, Tim Düsterhus : > Ilya, > > Am 12.04.19 um 10:54 schrieb Илья Шипицин: > > I wish to enable travis-ci, cirrus-ci builds for github repo > > I do not see any public memb

who controls https://github.com/haproxy/haproxy ?

2019-04-12 Thread Илья Шипицин
hello, I wish to enable travis-ci, cirrus-ci builds for github repo I do not see any public member there. who does control it ? thanks!

Re: Few problems seen in haproxy? (threads, connections).

2018-10-04 Thread Илья Шипицин
> 5. dmesg: no messages. > > With the same system and settings, threads gives 18x lesser RPS than > processes, along with > the other 2 issues given in my mail today. > > > On Thu, Oct 4, 2018 at 12:09 PM Илья Шипицин wrote: > >> haproxy config, nginx config >> non de

Re: Few problems seen in haproxy? (threads, connections).

2018-10-04 Thread Илья Шипицин
with > haproxy configuration file as given in my first mail. Around 60 > backend servers are configured in haproxy. > > 3. Backend servers are 2 core VM's running nginx and serving > a file called "/128", which is 128 bytes in size. > > Let me know if yo

Re: Few problems seen in haproxy? (threads, connections).

2018-10-03 Thread Илья Шипицин
load testing is somewhat good. can you describe an overall setup ? (I want to reproduce and play with it) чт, 4 окт. 2018 г. в 8:16, Krishna Kumar (Engineering) < krishna...@flipkart.com>: > Re-sending in case this mail was missed. To summarise the 3 issues seen: > > 1. Performance drops 18x

Re: patch to avoid null pointer dereference

2018-10-01 Thread Илья Шипицин
вт, 2 окт. 2018 г. в 7:06, Willy Tarreau : > Hi Ilya, > > On Sat, Sep 15, 2018 at 12:55:07AM +0500, ??? wrote: > > hi, > > > > please find attached patch > > > > cheers, > > Ilya Shipitsin > > > From 7961bb27597cf529a88da475d3928d6223a88753 Mon Sep 17 00:00:00 2001 > > From: Ilya

patch to avoid null pointer dereference

2018-09-14 Thread Илья Шипицин
hi, please find attached patch cheers, Ilya Shipitsin From 7961bb27597cf529a88da475d3928d6223a88753 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Sat, 15 Sep 2018 00:50:05 +0500 Subject: [PATCH] MINOR: src/connection.c: avoid null pointer dereference found by coverity ---

Re: patch for enabling gitlab-ci

2018-07-14 Thread Илья Шипицин
No interest? On Fri, Jul 13, 2018, 2:58 PM Илья Шипицин wrote: > Hello, > > I created a patch which will allow anyone to build CI > using "CI for external repo" + mirroring on https://gitlab.com > > Cheers, > Ilya Shipitsin >

patch for enabling gitlab-ci

2018-07-13 Thread Илья Шипицин
Hello, I created a patch which will allow anyone to build CI using "CI for external repo" + mirroring on https://gitlab.com Cheers, Ilya Shipitsin commit c75028307a55636f5530671bfcd936162059beed Author: Ilya Shipitsin Date: Fri Jul 13 14:36:55 2018 +0500 FEATURE: gitlab-ci enabled reg

Re: [PATCH] REGTEST/MINOR: Wrong URI syntax.

2018-07-13 Thread Илья Шипицин
пт, 13 июл. 2018 г. в 13:08, Frederic Lecaille : > On 07/13/2018 09:53 AM, Илья Шипицин wrote: > > sorry, I did not test it on centos 7 > > > > https://gitlab.com/chipitsine/haproxy/-/jobs/81501288 > > > > > > (I could not find out what's t

Re: [PATCH] REGTEST/MINOR: Wrong URI syntax.

2018-07-13 Thread Илья Шипицин
sorry, I did not test it on centos 7 https://gitlab.com/chipitsine/haproxy/-/jobs/81501288 (I could not find out what's that, error message is strange, I'll try to investigate on separate vm) чт, 12 июл. 2018 г. в 14:08, Frederic Lecaille : > This is a patch to fix the issue reported by Ilya

haproxy ci (again), gitlab.com ?

2018-07-12 Thread Илья Шипицин
hello, I have the following suggestion 1) I will add .gitlab-ci.yml to the haproxy repo (it will include "centos 7" and "fedora 28" builds, just to cover openssl-1.0.2 and openssl-1.1.0) 2) that .gitlab-ci.yml will run reg tests 3) anyone can follow to https://gitlab.com --> new --> CI for

Re: how h1_frt_addr is defined during reg tests?

2018-07-12 Thread Илья Шипицин
yes, it fixed build: https://gitlab.com/chipitsine/haproxy/-/jobs/81225803 чт, 12 июл. 2018 г. в 13:28, Frederic Lecaille : > On 07/11/2018 09:12 PM, Илья Шипицин wrote: > > Hello, > > > > I'm playing with reg tests. Sometimes they fail for weird reasons. > > (for e

how h1_frt_addr is defined during reg tests?

2018-07-11 Thread Илья Шипицин
Hello, I'm playing with reg tests. Sometimes they fail for weird reasons. (for example, fedora 28 on gitlab ci) https://gitlab.com/chipitsine/haproxy/-/jobs/81106855 curl -i -k https://${h1_frt_addr}:${h1_frt_port} became curl -i -k https://::1:38627 which is not correct. but I could not

Re: haproxy tests with sanitizers: bug found ? https://gitlab.com/chipitsine/haproxy/-/jobs/80667862

2018-07-11 Thread Илья Шипицин
Thanks, I'll check it out. ср, 11 июл. 2018 г. в 18:20, Frederic Lecaille : > On 07/11/2018 10:41 AM, Frederic Lecaille wrote: > > On 07/10/2018 01:35 PM, Илья Шипицин wrote: > >> Hello, > > > > Hello Ilya, > > > >> I had an idea, what if

Re: haproxy tests with sanitizers: bug found ? https://gitlab.com/chipitsine/haproxy/-/jobs/80667862

2018-07-10 Thread Илья Шипицин
just for the record, asan was very easy to enable: https://gitlab.com/chipitsine/haproxy/blob/master/.gitlab-ci.yml вт, 10 июл. 2018 г. в 16:35, Илья Шипицин : > Hello, > > I had an idea, what if we will run reg-tests with various sanitizers ? > > for example, > > https://

haproxy tests with sanitizers: bug found ? https://gitlab.com/chipitsine/haproxy/-/jobs/80667862

2018-07-10 Thread Илья Шипицин
Hello, I had an idea, what if we will run reg-tests with various sanitizers ? for example, https://gitlab.com/chipitsine/haproxy/-/jobs/80667862 (gcc + sanitize-address). can someone confirm a bug there ? "AddressSanitizer: heap-use-after-free on" I'll add more sanitizers later. thanks for

Re: how to run reg-tests ?

2018-07-10 Thread Илья Шипицин
yahoo! green tests https://gitlab.com/chipitsine/haproxy/-/jobs/80660454 вт, 10 июл. 2018 г. в 15:15, Frederic Lecaille : > Hi, > > > On 07/10/2018 12:02 PM, Илья Шипицин wrote: > > I use Fedora 28 if that matters. > > varnishtest installed from repo (dnf install var

Re: how to run reg-tests ?

2018-07-10 Thread Илья Шипицин
nice :) вт, 10 июл. 2018 г. в 15:15, Frederic Lecaille : > Hi, > > > On 07/10/2018 12:02 PM, Илья Шипицин wrote: > > I use Fedora 28 if that matters. > > varnishtest installed from repo (dnf install varnish), it is > > varnish-5.2.1-4.fc28.x86_64 > > >

Re: how to run reg-tests ?

2018-07-10 Thread Илья Шипицин
I use Fedora 28 if that matters. varnishtest installed from repo (dnf install varnish), it is varnish-5.2.1-4.fc28.x86_64 вт, 10 июл. 2018 г. в 14:58, Илья Шипицин : > HI, > > I cloned haproxy. > built it using: > > make TARGET=generic USE_OPENSSL=1 > > when I run te

how to run reg-tests ?

2018-07-10 Thread Илья Шипицин
HI, I cloned haproxy. built it using: make TARGET=generic USE_OPENSSL=1 when I run tests, it fails: [root@pf0sqjlx haproxy]# VARNISHTEST_PROGRAM=`which varnishtest` HAPROXY_PROGRAM=`pwd`/haproxy make reg-tests top 0.0 extmacro def pwd=/home/ilia/xxx/haproxy top 0.0 extmacro def

how to run vtc files?

2018-06-20 Thread Илья Шипицин
hi [ilia@localhost haproxy]$ HAPROXY_PROGRAM=./haproxy varnishtest reg-tests/ssl/h0.vtc top 0.0 extmacro def pwd=/home/ilia/xxx/haproxy top 0.0 extmacro def localhost=127.0.0.1 top 0.0 extmacro def bad_backend=127.0.0.1 36769 top 0.0 extmacro def

Re: Haproxy 1.8.4 crashing workers and increased memory usage

2018-04-09 Thread Илья Шипицин
can you try thread sanitizer (in real time)? https://github.com/google/sanitizers/wiki#threadsanitizer I'd like to try myself, however, we do not observe bad things in our environment 2018-04-09 13:24 GMT+05:00 Robin Geuze : > Hey Willy, > > So I made a build this morning

Re: format warning cleanup (patch attached)

2018-04-06 Thread Илья Шипицин
well, I was not sure whether to split into several files or not. ok, will split next time :) 2018-04-06 17:32 GMT+05:00 Willy Tarreau : > Hi Ilya, > > On Fri, Apr 06, 2018 at 05:08:20PM +0500, ??? wrote: > > Hello, > > > > please review the attached patch > > thank you,

format warning cleanup (patch attached)

2018-04-06 Thread Илья Шипицин
Hello, please review the attached patch Ilya Shipitsin From a7f2e5a064c40a5842decc7e053a6e4a4291df33 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Fri, 6 Apr 2018 17:06:10 +0500 Subject: [PATCH] MINOR: format warnings cleanup issue detected by cppcheck

patch (cleanup unused labels)

2018-03-29 Thread Илья Шипицин
please review the patch attached cheers, Ilya Shipitsin From 4ca8083844bc6fa1f06d3e8b85158dba64372f5c Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Thu, 29 Mar 2018 15:09:05 +0500 Subject: [PATCH] MINOR / CLEANUP: src/h1.c: remove unused labels issue detected by

Re: patch: fix build when USE_THREAD is not defined

2018-03-26 Thread Илья Шипицин
ok, let's use your approach 2018-03-25 16:52 GMT+05:00 Tim Düsterhus <t...@bastelstu.be>: > Илья, > > Am 24.03.2018 um 19:42 schrieb Илья Шипицин: > > in your patch comparision + empty loop will be executed even if > USE_THREADS > > is not defined. > > not ve

Re: patch: fix build when USE_THREAD is not defined

2018-03-24 Thread Илья Шипицин
in your patch comparision + empty loop will be executed even if USE_THREADS is not defined. not very big performance overhead actually. 2018-03-24 23:02 GMT+05:00 Christopher Faulet <cfau...@haproxy.com>: > Le 24/03/2018 à 13:19, Илья Шипицин a écrit : > >> please rev

patch: fix build when USE_THREAD is not defined

2018-03-24 Thread Илья Шипицин
please review attached patch From ec9cdfa848d438378919d4f8f2b1cba2a16f3eaa Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Sat, 24 Mar 2018 17:17:32 +0500 Subject: [PATCH] MINOR: fix build when USE_THREAD is not defined src/queue.o: In function `pendconn_redistribute':

compilation is broken without USE_THREAD=1

2018-03-24 Thread Илья Шипицин
hi, src/queue.o: In function `pendconn_redistribute': /home/ilia/haproxy/src/queue.c:272: undefined reference to `thread_want_sync' src/queue.o: In function `pendconn_grab_from_px': /home/ilia/haproxy/src/queue.c:311: undefined reference to `thread_want_sync' src/queue.o: In function

cleanup patch submission

2018-03-23 Thread Илья Шипицин
please review attached patch From 7f31259bfc6a86a1beae56c612984c1d4c6b7569 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Fri, 23 Mar 2018 17:41:48 +0500 Subject: [PATCH] CLEANUP: map, stream: remove duplicate code in src/map.c, src/stream.c issue was identified by

Re: strange cppcheck finding

2018-03-20 Thread Илья Шипицин
"UB" stands for undefined behaviour. that's the reason why cppcheck is unhappy. how do that properly - that's the question :) 2018-03-20 10:48 GMT+05:00 Willy Tarreau : > On Mon, Mar 19, 2018 at 06:55:46PM +0500, ??? wrote: > > (it's master) > > > > is it in purpose ? > > >

strange cppcheck finding

2018-03-19 Thread Илья Шипицин
(it's master) is it in purpose ? [src/ssl_sock.c:1553]: (warning) Invalid test for overflow 'msg+rec_len

small cleanup of src/dns.c

2018-03-15 Thread Илья Шипицин
Hello, small issue (no real impact) identified by cppcheck From 733d99f42d93898232bb8c3c953b662ee889c034 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Thu, 15 Mar 2018 16:38:38 +0500 Subject: [PATCH] CLEANUP: remove duplicate code in src/dns.c issue was identified by

cppcheck finding

2018-03-15 Thread Илья Шипицин
Hi, [src/51d.c:373]: (error) Invalid number of character '{' when no macros are defined. ?

Re: cppcheck finding

2018-03-14 Thread Илья Шипицин
any action on that ? 2018-03-08 22:29 GMT+05:00 Olivier Houchard : > Hi, > > On Thu, Mar 08, 2018 at 05:44:31PM +0100, Willy Tarreau wrote: > > Hi, > > > > On Wed, Mar 07, 2018 at 03:26:25PM +0500, ??? wrote: > > > Hello, > > > > > > [src/proto_uxst.c:160]:

cppcheck finding

2018-03-07 Thread Илья Шипицин
Hello, [src/proto_uxst.c:160]: (warning) Redundant assignment of 'xfer_sock->next->prev' to itself. is it in purpose ?

<    6   7   8   9   10   11   12   >