On Mon, Aug 26, 2024 at 11:40:15PM +0200, Ilya Shipitsin wrote:
> This is 43rd iteration of typo fixes
Merged, thank you Ilya!
Willy
Hi Nicolas,
On Tue, Aug 27, 2024 at 10:18:51PM +0200, Nicolas CARPi wrote:
> Found these two typos while browsing the code :)
(...)
> Found this typo in macro name :)
Thank you, both patches applied.
> BTW, in mqtt.c mqtt_read_varint(), "off" is initialized to 0, but
> initialized again in the
wanted to bring attention to it,
in case it is not something wanted.
Cheers,
~Nicolas
>From 1c7694831f5d0a89d3250e6c9872b68ddc170a72 Mon Sep 17 00:00:00 2001
From: Nicolas CARPi
Date: Tue, 27 Aug 2024 21:51:26 +0200
Subject: [PATCH] CLEANUP: mqtt: fix typo in MQTT_REMAINING_LENGHT_MAX_SIZE
T
las CARPi
Date: Tue, 27 Aug 2024 22:02:17 +0200
Subject: [PATCH] CLEANUP: haproxy: fix typos in code comment
Use "from" instead of "form" in ha_random_boot function code comments.
---
src/haproxy.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/ha
This is 43rd iteration of typo fixes
---
admin/release-estimator/README.md | 2 +-
doc/configuration.txt | 14 +++---
doc/management.txt| 2 +-
include/haproxy/channel.h | 2 +-
include/haproxy/fcgi-app-t.h | 6 +++---
include/haproxy/mux_spop-t
On Thu, Feb 22, 2024 at 10:12:27AM +0100, Ilya Shipitsin wrote:
> This is 39th iteration of typo fixes
Now merged, thank you! I split it in two because the one on
resolvers and stick-tables directly affects the code (it renames
a function argument) and I want to make it easy to drop it in case
bac
This is 39th iteration of typo fixes
---
addons/promex/README | 4 ++--
addons/promex/include/promex/promex.h | 4 ++--
doc/DeviceAtlas-device-detection.txt | 2 +-
doc/configuration.txt | 2 +-
reg-tests/ssl/ocsp_auto_update.vtc| 10 +-
src/mux_qu
Hi Miroslav,
On Tue, Jan 30, 2024 at 03:42:20AM +0100, Miroslav Zagorac wrote:
> Hello all,
>
> In several places in the source, there was the same block of code that was
> used to deinitialize the log buffer. There were even two functions that
> did this, but they were called only from the code
52ef575d77a47ef7338004fbad31d8199e59c752 Mon Sep 17 00:00:00 2001
From: Miroslav Zagorac
Date: Tue, 30 Jan 2024 03:14:09 +0100
Subject: [PATCH] CLEANUP: log: deinitialization of the log buffer in one
function
In several places in the source, there was the same block of code that was
used to deinitialize the log
On Sun, Nov 05, 2023 at 08:02:37PM +0100, Tim Duesterhus wrote:
> This reapplies the xalloc_size.cocci patch across the whole `src/` tree.
Applied, thank you Tim!
Willy
This reapplies the xalloc_size.cocci patch across the whole `src/` tree.
see 16cc16dd8235e7eb6c38b7abd210bd1e1d96b1d9
see 63ee0e4c01b94aee5fc6c6dd98cfc4480ae5ea46
see 9fb57e8c175a0b852b06a0780f48eb8eaf321a47
---
src/log.c| 3 ++-
src/proto_quic.c | 2 +-
src/server.c | 4 ++--
src/tcp
On Wed, May 10, 2023 at 04:30:58PM +0200, ??? wrote:
> Hello,
>
> small clean patch.
> mutes coverity finding.
Thanks Ilya, now merged in dev11.
Willy
Hello,
small clean patch.
mutes coverity finding.
Ilya
From 4fdccb44933c2a91c7d6711bf821cc8b1d4c6d30 Mon Sep 17 00:00:00 2001
From: Ilya Shipitsin
Date: Wed, 26 Apr 2023 21:05:12 +0200
Subject: [PATCH 1/2] CLEANUP: src/listener.c: remove redundant NULL check
fixes #2031
quoting Willy Tarreau:
Hi Ilya,
On Sat, Apr 15, 2023 at 11:55:14PM +0200, ??? wrote:
> From: Ilya Shipitsin
> Date: Sat, 15 Apr 2023 23:39:43 +0200
> Subject: [PATCH] CLEANUP: use "offsetof" where appropriate
>
> let's use the C library macro "offsetof"
Good point.
Hello,
small cleanup patch attached.
Ilya
From 77babd04c417709bb41c951701d62dec0574eb35 Mon Sep 17 00:00:00 2001
From: Ilya Shipitsin
Date: Sat, 15 Apr 2023 23:39:43 +0200
Subject: [PATCH] CLEANUP: use "offsetof" where appropriate
let's use the C library macro "offset
On Mon, Jan 09, 2023 at 01:31:06AM +, Manu Nicolas wrote:
> This fixes a typo in an error message about headers in the
> http_str_to_htx function.
Applied, thank you Manu!
Willy
This fixes a typo in an error message about headers in the
http_str_to_htx function.
---
src/http_htx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/http_htx.c b/src/http_htx.c
index 2978f2eb4..58b24183f 100644
--- a/src/http_htx.c
+++ b/src/http_htx.c
@@ -924,7 +924,7 @
Le 6/1/22 à 21:58, Tim Duesterhus a écrit :
This reapplies the xalloc_size.cocci patch across the whole `src/` tree.
Merged. Thanks !
--
Christopher Faulet
On Wed, Jun 01, 2022 at 09:58:37PM +0200, Tim Duesterhus wrote:
> This reapplies the xalloc_size.cocci patch across the whole `src/` tree.
> see 16cc16dd8235e7eb6c38b7abd210bd1e1d96b1d9
> see 63ee0e4c01b94aee5fc6c6dd98cfc4480ae5ea46
> ---
> src/ncbuf.c | 2 +-
> src/proto_quic.c | 2 +-
> src
This reapplies the xalloc_size.cocci patch across the whole `src/` tree.
see 16cc16dd8235e7eb6c38b7abd210bd1e1d96b1d9
see 63ee0e4c01b94aee5fc6c6dd98cfc4480ae5ea46
---
src/ncbuf.c | 2 +-
src/proto_quic.c | 2 +-
src/quic_sock.c | 3 ++-
3 files changed, 4 insertions(+), 3 deletions(-)
diff
On Sun, May 22, 2022 at 12:40:58PM +0200, Tim Duesterhus wrote:
> If QUIC support is enabled both branches of the ternary conditional are
> identical, upsetting Coverity. Move the full conditional into the non-QUIC
> preprocessor branch to make the code more clear.
>
> This resolves GitHub issue #
If QUIC support is enabled both branches of the ternary conditional are
identical, upsetting Coverity. Move the full conditional into the non-QUIC
preprocessor branch to make the code more clear.
This resolves GitHub issue #1710.
---
src/tools.c | 7 ---
1 file changed, 4 insertions(+), 3 del
On Wed, May 18, 2022 at 12:22:15AM +0200, Tim Duesterhus wrote:
> Even if `unique_id` and `s->unique_id` are identical it is a bit odd to
> `isttest()` `unique_id` and then use `s->unique_id` in the call to
> `http_add_header()`.
Agreed, better be consistent. Now applied, thank you Tim!
Willy
Even if `unique_id` and `s->unique_id` are identical it is a bit odd to
`isttest()` `unique_id` and then use `s->unique_id` in the call to
`http_add_header()`.
This "issue" was introduced in a17e66289c08a5bfadc1bb5b5f2c618c9299fe1b,
because before that commit the function returned the length of t
Hi Tim,
On Tue, Apr 26, 2022 at 11:35:07PM +0200, Tim Duesterhus wrote:
> To make the deinit function a proper inverse of the init function we need to
> free the `http_err_chunks`:
>
> ==252081== 311,296 bytes in 19 blocks are still reachable in loss record
> 50 of 50
> ==252081==at
To make the deinit function a proper inverse of the init function we need to
free the `http_err_chunks`:
==252081== 311,296 bytes in 19 blocks are still reachable in loss record 50
of 50
==252081==at 0x483B7F3: malloc (in
/usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-li
This makes it clear to static analysis tools that this assignment is
intentional and not a mistyped comparison.
---
src/sock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/sock.c b/src/sock.c
index e3d4a6e4c..f11c5b0c4 100644
--- a/src/sock.c
+++ b/src/sock.c
@@ -74,7 +7
Willy,
On 11/5/21 4:43 PM, Willy Tarreau wrote:
Yes, sorry, but I will really deal with that stuff *after* we're done
with haproxy's release.
Yes, absolutely.
I just came across this point on my list while I was double-checking
whether I had anything important / any loose ends for 2.5 and th
On Fri, Nov 05, 2021 at 02:17:51PM +0100, Tim Düsterhus wrote:
> Willy,
>
> On 10/11/21 5:15 PM, Tim Düsterhus wrote:
> > > > > > please also apply to https://github.com/wtarreau/libslz/.
> > > > > > [...]
> > > > >
> > > > > Now applied, thanks!
> > > >
> > > > Not seeing anything in the libslz
Willy,
On 10/11/21 5:15 PM, Tim Düsterhus wrote:
please also apply to https://github.com/wtarreau/libslz/.
[...]
Now applied, thanks!
Not seeing anything in the libslz repository yet. Did you forget to push?
:-)
No, I've applied to the haproxy copy only for now, will do slz later,
and afte
Hi Tim,
On Thu, Nov 04, 2021 at 09:04:24PM +0100, Tim Duesterhus wrote:
> Found using clang's scan-build.
(...)
This and your 4 other cleanup patches applied now, thank you!
Willy
Found using clang's scan-build.
---
admin/halog/halog.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/admin/halog/halog.c b/admin/halog/halog.c
index 900cf5d46..f368c1c6f 100644
--- a/admin/halog/halog.c
+++ b/admin/halog/halog.c
@@ -551,7 +551,8 @@ int convert_date_to_
On Fri, Oct 29, 2021 at 05:20:23PM +0200, Remi Tricot-Le Breton wrote:
> > > Rémi, am I missing something or is it just that this code snippet indeed
> > > has a bug that was not spotted by the regtests (which I'm fine with,
> > > they're regression tests, not unit tests seeking 100% coverage) ?
>
Hello Tim,
On 29/10/2021 16:57, Tim Düsterhus wrote:
Willy,
On 10/29/21 8:50 AM, Willy Tarreau wrote:
I don't see how this can ever match:
- we search for a space in the first characters starting at
- if we find one such space, we check if these characters are exactly
equal to
Willy,
On 10/29/21 8:50 AM, Willy Tarreau wrote:
I don't see how this can ever match:
- we search for a space in the first characters starting at
- if we find one such space, we check if these characters are exactly
equal to the string "Bearer" (modulo the case), and if so we take
On Thu, Oct 14, 2021 at 07:48:08PM +0200, Tim Duesterhus wrote:
> Remi,
>
> please find a suggested cleanup for your JWT patch series. I think that
> using the ist functions results in easier to understand code, because you
> don't need to manually calculate lengths and offsets.
>
> Apply with `g
Willy,
On 10/14/21 7:48 PM, Tim Duesterhus wrote:
please find a suggested cleanup for your JWT patch series. I think that
using the ist functions results in easier to understand code, because you
don't need to manually calculate lengths and offsets.
Here's another patch that did not receive a
This branch is no longer required, because the `!nsize` case is handled for any
value of `ptr` now.
see 22586524e32f14c44239063088a38ccea8abc9b7
see a5efdff93c36f75345a2a18f18bffee9b602bc7b
---
src/hlua.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/hlua.c b/src/hlua.c
index ac61a317
Willy,
On 10/18/21 10:51 AM, Willy Tarreau wrote:
On Mon, Oct 18, 2021 at 09:18:12AM +0200, Tim Düsterhus wrote:
Hu, interesting. Is the GitHub Mirror Sync broken? I'm seeing changes in
https://git.haproxy.org/?p=haproxy.git, but not in GitHub.
So it was in relation with the Painful Access To
On Mon, Oct 18, 2021 at 09:18:12AM +0200, Tim Düsterhus wrote:
> Hu, interesting. Is the GitHub Mirror Sync broken? I'm seeing changes in
> https://git.haproxy.org/?p=haproxy.git, but not in GitHub.
So it was in relation with the Painful Access Token apparently. The
mirror user was not allowed any
On Mon, Oct 18, 2021 at 09:18:12AM +0200, Tim Düsterhus wrote:
> Willy,
>
> On 10/18/21 9:15 AM, Willy Tarreau wrote:
> > On Mon, Oct 18, 2021 at 09:09:01AM +0200, Tim Düsterhus wrote:
> > > Feel free to replace 'unsigned int' with 'uint' and reformat the struct as
> > > needed.
> >
> > Done an p
Willy,
On 10/18/21 9:15 AM, Willy Tarreau wrote:
On Mon, Oct 18, 2021 at 09:09:01AM +0200, Tim Düsterhus wrote:
Feel free to replace 'unsigned int' with 'uint' and reformat the struct as
needed.
Done an pushed, thank you!
Willy
Hu, interesting. Is the GitHub Mirror Sync broken? I'm seeing
On Mon, Oct 18, 2021 at 09:09:01AM +0200, Tim Düsterhus wrote:
> Feel free to replace 'unsigned int' with 'uint' and reformat the struct as
> needed.
Done an pushed, thank you!
Willy
Willy,
On 10/18/21 7:22 AM, Willy Tarreau wrote:
On Sat, Oct 16, 2021 at 06:24:18PM +0200, Tim Duesterhus wrote:
see 6a0dd733906611dea958cf74b9f51bb16028ae20
Found using GitHub's CodeQL scan.
---
include/haproxy/stick_table-t.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
On Fri, Oct 15, 2021 at 04:18:21PM +0500, Ilya Shipitsin wrote:
> This is 27th iteration of typo fixes
Merged, thanks Ilya!
Willy
On Sat, Oct 16, 2021 at 06:24:18PM +0200, Tim Duesterhus wrote:
> see 6a0dd733906611dea958cf74b9f51bb16028ae20
>
> Found using GitHub's CodeQL scan.
> ---
> include/haproxy/stick_table-t.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/haproxy/stick_table-t.
see 6a0dd733906611dea958cf74b9f51bb16028ae20
Found using GitHub's CodeQL scan.
---
include/haproxy/stick_table-t.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/haproxy/stick_table-t.h b/include/haproxy/stick_table-t.h
index 3b1f2b3ef..133f992b5 100644
--- a/incl
This is 27th iteration of typo fixes
---
doc/configuration.txt| 2 +-
include/haproxy/h3.h | 2 +-
include/haproxy/mux_quic-t.h | 2 +-
include/haproxy/mux_quic.h | 2 +-
include/haproxy/qpack-t.h
Remi,
please find a suggested cleanup for your JWT patch series. I think that
using the ist functions results in easier to understand code, because you
don't need to manually calculate lengths and offsets.
Apply with `git am --scissors` to automatically cut the commit message.
-- >8 --
Using the
Willy,
On 9/24/21 3:36 PM, Willy Tarreau wrote:
On Fri, Sep 24, 2021 at 03:33:14PM +0200, Tim Düsterhus wrote:
Willy,
On 9/24/21 3:09 PM, Willy Tarreau wrote:
please also apply to https://github.com/wtarreau/libslz/.
[...]
Now applied, thanks!
Not seeing anything in the libslz repository
On Fri, Sep 24, 2021 at 03:33:14PM +0200, Tim Düsterhus wrote:
> Willy,
>
> On 9/24/21 3:09 PM, Willy Tarreau wrote:
> > > please also apply to https://github.com/wtarreau/libslz/.
> > > [...]
> >
> > Now applied, thanks!
>
> Not seeing anything in the libslz repository yet. Did you forget to pu
Willy,
On 9/24/21 3:09 PM, Willy Tarreau wrote:
please also apply to https://github.com/wtarreau/libslz/.
[...]
Now applied, thanks!
Not seeing anything in the libslz repository yet. Did you forget to
push? :-)
Best regards
Tim Düsterhus
Hi Tim,
On Mon, Sep 20, 2021 at 07:59:42PM +0200, Tim Duesterhus wrote:
> Willy,
>
> please also apply to https://github.com/wtarreau/libslz/.
> Best regards
> Tim Düsterhus
>
> Apply with `git am --scissors` to automatically cut the commit message.
>
> -- >8 --
> This function has no prototype
Willy,
please also apply to https://github.com/wtarreau/libslz/.
Best regards
Tim Düsterhus
Apply with `git am --scissors` to automatically cut the commit message.
-- >8 --
This function has no prototype and is not used outside of slz.c.
---
src/slz.c | 2 +-
1 file changed, 1 insertion(+), 1
This moves all the xxhash functionality into a single location.
see d5fc8fcb86eb99831626051b3055bea7ca93a074
---
include/haproxy/compat.h | 7 ---
include/haproxy/xxhash.h | 7 +++
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/include/haproxy/compat.h b/include/haproxy/co
On Sat, Sep 11, 2021 at 08:29:46PM +0200, Tim Duesterhus wrote:
> This moves all the xxhash functionality into a single location.
Wow that was fast, now merged, thanks!
Willy
On Sat, Sep 11, 2021 at 08:06:01PM +0200, Dragan Dosen wrote:
> Hi Tim,
>
> On 11. 09. 2021. 17:51, Tim Duesterhus wrote:
> > This solves setting XXH_INLINE_ALL in a cleaner way, because the imported
> > header is not modified, easing future updates.
> >
> > see 6f7cc11e6dd0f01b437fba893da2edd236
Hi Tim,
On 11. 09. 2021. 17:51, Tim Duesterhus wrote:
This solves setting XXH_INLINE_ALL in a cleaner way, because the imported
header is not modified, easing future updates.
see 6f7cc11e6dd0f01b437fba893da2edd2362660a2
---
(...)
Thanks!
We might also want to move the "XXH3" defined in
incl
Hi Tim,
On Sat, Sep 11, 2021 at 05:51:13PM +0200, Tim Duesterhus wrote:
> This solves setting XXH_INLINE_ALL in a cleaner way, because the imported
> header is not modified, easing future updates.
Excellent idea, I like this. It's indeed much cleaner and more logical
this way. This may also serve
This solves setting XXH_INLINE_ALL in a cleaner way, because the imported
header is not modified, easing future updates.
see 6f7cc11e6dd0f01b437fba893da2edd2362660a2
---
addons/51degrees/51d.c | 2 +-
admin/dyncookie/dyncookie.c| 3 ++-
include/haproxy/activity.h | 2 +-
includ
On Wed, Sep 01, 2021 at 09:23:25PM +0200, Tim Duesterhus wrote:
> Willy,
>
> this also affects include/import/lru.h, include/import/xxhash.h, and
> include/import/sha1.h. But I did not touch these, as they are within import/*
Yes, good point, I also prefer to really limit the amount of changes
th
Willy,
this also affects include/import/lru.h, include/import/xxhash.h, and
include/import/sha1.h. But I did not touch these, as they are within import/*
Best regards
Tim Düsterhus
Apply with `git am --scissors` to automatically cut the commit message.
-- >8 --
Found using GitHub's CodeQL scan.
Willy,
On 6/20/21 11:49 AM, Willy Tarreau wrote:
Well, I would say that this heuristic is totally broken because it should at
least ensure there's no more word before a brace on the line. However I agree
that usually we prefer to respect the comment format starting with an asterisk
at the beginn
Hi Tim,
On Sat, Jun 19, 2021 at 04:56:30PM +0200, Tim Duesterhus wrote:
> GitHub uses github/linguist to determine the programming language used for
> each
> source file to show statistics and to power the search. In cases of unique
> file
> extensions this is easy, but for `.h` files the situat
GitHub uses github/linguist to determine the programming language used for each
source file to show statistics and to power the search. In cases of unique file
extensions this is easy, but for `.h` files the situation is less clear as they
are used for C, C++, Objective C and more. In these cases l
Hi Miroslav,
On Tue, Jun 15, 2021 at 03:53:39PM +0200, Miroslav Zagorac wrote:
> Hello all,
>
> To avoid repeating the same source code, allocating memory and
> initializing the per_thr field from the server structure is
> transferred to a separate function.
Makes sense, indeed. Now merged, than
can change the nature of a man?
>From 81ec1afe2a7da947952deedb394970248df6cd8b Mon Sep 17 00:00:00 2001
From: Miroslav Zagorac
Date: Tue, 15 Jun 2021 15:33:20 +0200
Subject: [PATCH] CLEANUP: server: a separate function for initializing the
per_thr field
To avoid repeating the same source c
On Mon, May 31, 2021 at 11:07:29PM +0200, Tim Duesterhus wrote:
> The legacy HTTP subsystem has been removed. HTX is always enabled.
Now merged, thank you Tim!
Willy
The legacy HTTP subsystem has been removed. HTX is always enabled.
---
reg-tests/README | 2 +-
reg-tests/cache/basic.vtc | 1 -
reg-tests/cache/caching_rules.vtc | 1 -
reg-tests/cache/expires.vtc | 1 -
reg-tests/
On Mon, May 10, 2021 at 03:52:26PM -0400, Daniel Corbett wrote:
> It was found that when viewing the help output from the CLI that
> "set profiling" had 2 spaces in it, which was pushing it out from
> the rest of similar commands.
>
> i.e. it looked like this:
> prepare acl
> prepare map
>
Hello,
It was found that when viewing the help output from the CLI that
"set profiling" had 2 spaces in it, which was pushing it out from
the rest of similar commands.
i.e. it looked like this:
prepare acl
prepare map
set profiling{auto|on|off}
set dynamic-cookie-key
On Thu, Apr 08, 2021 at 08:05:23PM +0200, Tim Duesterhus wrote:
> Willy,
>
> apparently I still had this one lying around. Found it while cleaning up local
> branches :-)
Ah yes that's indeed cleaner this way. Applied, thank you!
Willy
Willy,
apparently I still had this one lying around. Found it while cleaning up local
branches :-)
Best regards
Tim Düsterhus
Apply with `git am --scissors` to automatically cut the commit message.
-- >8 --
This is not C++.
---
include/haproxy/chunk.h| 2 +-
include/haproxy/listener.h | 2
ful to fix the subject to mention
> "ssl" in them.
>
> Thanks,
> Willy
>
> - Forwarded message from ??? -
>
> > Date: Wed, 24 Mar 2021 11:29:03 +0500
> > From: ???
> > Subject: Re: [PATCH] cleanup unused definitions
> >
On Wed, Mar 24, 2021 at 11:29:03AM +0500, Илья Шипицин wrote:
> ping
>
> сб, 20 мар. 2021 г. в 22:43, Илья Шипицин :
>
> > while refactoring HA_OPENSSL_VERSION usage,
> > I've found unused definitions. nice.
> >
> >
> > Ilya
> >
Thanks, merged.
--
William Lallemand
rwarded message from ??? -
> Date: Wed, 24 Mar 2021 11:29:03 +0500
> From: ???
> Subject: Re: [PATCH] cleanup unused definitions
> To: HAProxy , Willy Tarreau
> Delivered-To: haproxy@formilux.org
> List-Id: Haproxy
>
> ping
>
> ??, 20 ???. 2021 ?
ping
сб, 20 мар. 2021 г. в 22:43, Илья Шипицин :
> while refactoring HA_OPENSSL_VERSION usage,
> I've found unused definitions. nice.
>
>
> Ilya
>
while refactoring HA_OPENSSL_VERSION usage,
I've found unused definitions. nice.
Ilya
From c5ba9de13cb7d5eda4781731bb4bfb68c823114c Mon Sep 17 00:00:00 2001
From: Ilya Shipitsin
Date: Sat, 20 Mar 2021 22:30:59 +0500
Subject: [PATCH] CLEANUP: remove unused definitions
not need
89e0db371699fa8c8eb74a69584ed27 Mon Sep 17 00:00:00 2001
> > From: Ilya Shipitsin
> > Date: Fri, 19 Mar 2021 23:06:36 +0500
> > Subject: [PATCH] CLEANUP: move "tmp_ssl" definition and usage only when
> it is
> > required
> >
> > if we do not have
Hi Ilya,
On Fri, Mar 19, 2021 at 11:19:14PM +0500, ??? wrote:
> Hello,
>
> pure cleanup, should fix #1162
>
> Ilya
> From 7915f3ed189e0db371699fa8c8eb74a69584ed27 Mon Sep 17 00:00:00 2001
> From: Ilya Shipitsin
> Date: Fri, 19 Mar 2021 23:06:36 +0500
> Sub
Hello,
pure cleanup, should fix #1162
Ilya
From 7915f3ed189e0db371699fa8c8eb74a69584ed27 Mon Sep 17 00:00:00 2001
From: Ilya Shipitsin
Date: Fri, 19 Mar 2021 23:06:36 +0500
Subject: [PATCH] CLEANUP: move "tmp_ssl" definition and usage only when it is
required
if we d
Both cleanups applied, thank you Tim!
Willy
Refactoring performed with the following Coccinelle patch:
@@
expression e;
statement S;
@@
- for (;e;)
+ while (e)
S
---
src/h2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/h2.c b/src/h2.c
index 84aa660b7..9ff3c938e 100644
--- a/src/h2.
Refactoring performed with the following Coccinelle patch:
@@
char *s;
@@
(
- ist2(s, strlen(s))
+ ist(s)
|
- ist2(strdup(s), strlen(s))
+ ist(strdup(s))
)
Note that this replacement is safe even in the strdup() case, because `ist()`
will not call `strlen(
Le 10/02/2021 à 09:09, Илья Шипицин a écrit :
Hello,
this is pure cleanup.
should fix #1048
Thanks Ilya, now merged !
--
Christopher Faulet
Hello,
this is pure cleanup.
should fix #1048
Ilya
From 350c37117369607928ddb232cf8f86b1c218bd47 Mon Sep 17 00:00:00 2001
From: Ilya Shipitsin
Date: Wed, 10 Feb 2021 13:03:30 +0500
Subject: [PATCH] CLEANUP: remove unused variable assigned found by Coverity
this is pure cleanup, no need to
On Fri, Jan 08, 2021 at 09:57:41PM +0100, William Dauchy wrote:
> - check functions are never called with a NULL args list, it is always
> an array, so first check can be removed
> - the expression parser guarantees that we can't have anything else,
> because we mentioned json converter takes a
- check functions are never called with a NULL args list, it is always
an array, so first check can be removed
- the expression parser guarantees that we can't have anything else,
because we mentioned json converter takes a mandatory string argument.
Thus test on `ARGT_STR` can be removed as
On Thu, Jan 07, 2021 at 10:59:26PM +0500, ??? wrote:
> patch resolving #1030 attached.
Applied, thanks Ilya!
Willy
Hi,
patch resolving #1030 attached.
Ilya
From eb849f02b0fef02a4d40f7566da3b54b2d0a8368 Mon Sep 17 00:00:00 2001
From: Ilya Shipitsin
Date: Thu, 7 Jan 2021 22:45:13 +0500
Subject: [PATCH] CLEANUP: replace "realloc" with "my_realloc2" to fix to
memory leak
my_realloc2 frees
On Tue, Jan 05, 2021 at 11:14:58AM +0100, William Dauchy wrote:
> there was an extra `s` added to the `var_check_arg` function
Merged, thank you William.
Willy
there was an extra `s` added to the `var_check_arg` function
Signed-off-by: William Dauchy
---
src/flt_spoe.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/flt_spoe.c b/src/flt_spoe.c
index 45370fee6..bfd6f4fbf 100644
--- a/src/flt_spoe.c
+++ b/src/flt_spoe.c
@@
Hi William,
On Wed, Dec 16, 2020 at 12:52:57PM +0100, William Dauchy wrote:
> Hi Willy
>
> On Tue, Jul 7, 2020 at 11:17 PM Willy Tarreau wrote:
> > On Tue, Jul 07, 2020 at 07:14:08PM +0200, Pierre Cheynier wrote:
> > > A typo I identified while having a look to our metric inventory.
> >
> > Than
Hi Willy
On Tue, Jul 7, 2020 at 11:17 PM Willy Tarreau wrote:
> On Tue, Jul 07, 2020 at 07:14:08PM +0200, Pierre Cheynier wrote:
> > A typo I identified while having a look to our metric inventory.
>
> Thank you, now merged.
Do you think that's something we could backport to v2.x to make it
cohe
Le 25/10/2020 à 14:01, William Dauchy a écrit :
`att_beg` is assigned to `next` at the end of the `for` loop, but is
assigned to `prev` at the beginning of the loop, which is itself
assigned to `next` after each loop. So it represents a double
assignation for the same value. Also `att_beg` is not
`att_beg` is assigned to `next` at the end of the `for` loop, but is
assigned to `prev` at the beginning of the loop, which is itself
assigned to `next` after each loop. So it represents a double
assignation for the same value. Also `att_beg` is not used after the end
of the loop.
this is a partia
On Sun, Sep 06, 2020 at 06:34:12PM +0200, Tim Duesterhus wrote:
> This excludes the currently tracked files from being ignored.
Good spot, now merged, thanks!
Willy
This excludes the currently tracked files from being ignored.
---
.gitignore | 4
1 file changed, 4 insertions(+)
diff --git a/.gitignore b/.gitignore
index 7e45489d2..3a760af99 100644
--- a/.gitignore
+++ b/.gitignore
@@ -2,7 +2,11 @@
# than blocking about 500 different test files and bug
On Fri, Aug 07, 2020 at 10:19:23PM +0200, William Dauchy wrote:
> trivial commit, does not change the code behaviour
>
Thanks, merged!
--
William Lallemand
trivial commit, does not change the code behaviour
Signed-off-by: William Dauchy
---
src/mux_fcgi.c | 2 +-
src/mux_h2.c | 2 +-
src/ring.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mux_fcgi.c b/src/mux_fcgi.c
index 875049884..ab9ddf095 100644
--- a/src/mux
1 - 100 of 325 matches
Mail list logo
