Re: [PATCH] Add b64dec sample converter

2017-05-12 Thread Holger Just
Hi Willy, Willy Tarreau wrote: > The thing is that we normally don't backport any feature anymore to > stable branches due to the terrible experience in 1.4 where too much > riskless stuff was backported, then fixed, then removed etc... making > each subsequent version a pain for certain users. >

Re: [PATCH] Add b64dec sample converter

2017-05-12 Thread Willy Tarreau
On Fri, May 12, 2017 at 05:39:28PM +0200, Holger Just wrote: > >> Once verified, I think this converter can be safely added to the > >> supported stable versions of HAProxy. > > > > Yes I think it can make sense to backport it at least to 1.7, it can > > help sometimes. > > That would be much

Re: [PATCH] Add b64dec sample converter

2017-05-12 Thread Holger Just
Hi Willy, thanks for applying the patch! Willy Tarreau wrote: > Thanks for the warning, much appreciated. It made me re-read it after > applying it. But your code is fine, no problem detected! So you're > becoming a C programmer ;-) Yeah, we will see about that :) >> Once verified, I think

Re: [PATCH] Add b64dec sample converter

2017-05-12 Thread Willy Tarreau
Hi Holger, On Sat, May 06, 2017 at 02:08:29AM +0200, Holger Just wrote: > This patch against current master adds a new b64dec converter. It takes > a base64 encoded string and returns its decoded binary representation. > > This converter can be used to e.g. extract the username of a basic auth >

[PATCH] Add b64dec sample converter

2017-05-05 Thread Holger Just
Hi all, This patch against current master adds a new b64dec converter. It takes a base64 encoded string and returns its decoded binary representation. This converter can be used to e.g. extract the username of a basic auth header to add it to the log: acl BASIC_AUTH hdr_beg(Authorization)