Re: [PATCH] BUG/MINOR: dns: Make dns_query_id_seed unsigned

2020-01-19 Thread Илья Шипицин
вс, 19 янв. 2020 г. в 14:09, Willy Tarreau : > On Sun, Jan 19, 2020 at 12:38:43PM +0500, ??? wrote: > > > > how noisy is ubsan ? should we add it to CI ? > > > > > > > > > > No idea. I created a dedicated test executable and copied over the > > > implementation to avoid needing to

Re: [PATCH] BUG/MINOR: dns: Make dns_query_id_seed unsigned

2020-01-19 Thread Willy Tarreau
On Sun, Jan 19, 2020 at 12:38:43PM +0500, ??? wrote: > > > how noisy is ubsan ? should we add it to CI ? > > > > > > > No idea. I created a dedicated test executable and copied over the > > implementation to avoid needing to configure HAProxy to use DNS for the > > verification of my

Re: [PATCH] BUG/MINOR: dns: Make dns_query_id_seed unsigned

2020-01-18 Thread Илья Шипицин
сб, 18 янв. 2020 г. в 15:30, Tim Düsterhus : > Ilya, > > Am 18.01.20 um 10:02 schrieb Илья Шипицин: > > how noisy is ubsan ? should we add it to CI ? > > > > No idea. I created a dedicated test executable and copied over the > implementation to avoid needing to configure HAProxy to use DNS for

Re: [PATCH] BUG/MINOR: dns: Make dns_query_id_seed unsigned

2020-01-18 Thread Tim Düsterhus
Ilya, Am 18.01.20 um 10:02 schrieb Илья Шипицин: > how noisy is ubsan ? should we add it to CI ? > No idea. I created a dedicated test executable and copied over the implementation to avoid needing to configure HAProxy to use DNS for the verification of my patch. In short: Simply try for

Re: [PATCH] BUG/MINOR: dns: Make dns_query_id_seed unsigned

2020-01-18 Thread Илья Шипицин
how noisy is ubsan ? should we add it to CI ? сб, 18 янв. 2020 г. в 06:07, Tim Duesterhus : > Left shifting of large signed values and negative values is undefined. > > In a test script clang's ubsan rightfully complains: > > > runtime error: left shift of 1934242336581872173 by 13 places cannot

Re: [PATCH] BUG/MINOR: dns: Make dns_query_id_seed unsigned

2020-01-17 Thread Willy Tarreau
On Sat, Jan 18, 2020 at 02:04:12AM +0100, Tim Duesterhus wrote: > Left shifting of large signed values and negative values is undefined. Applied, thanks. Willy

[PATCH] BUG/MINOR: dns: Make dns_query_id_seed unsigned

2020-01-17 Thread Tim Duesterhus
Left shifting of large signed values and negative values is undefined. In a test script clang's ubsan rightfully complains: > runtime error: left shift of 1934242336581872173 by 13 places cannot be > represented in type 'int64_t' (aka 'long') This bug was introduced in the initial version of