Re: [PATCH] BUG/MINOR: vars: Fix memory leak in vars_check_arg

2019-05-12 Thread Willy Tarreau
On Sun, May 12, 2019 at 06:01:26PM +0200, Tim Düsterhus wrote: > Willy, > > Am 11.05.19 um 05:53 schrieb Willy Tarreau: > >> diff --git a/src/vars.c b/src/vars.c > >> index 477a14632..d32310270 100644 > >> --- a/src/vars.c > >> +++ b/src/vars.c > >> @@ -510,6 +510,7 @@ int vars_check_arg(struct

Re: [PATCH] BUG/MINOR: vars: Fix memory leak in vars_check_arg

2019-05-12 Thread Tim Düsterhus
Willy, Am 11.05.19 um 05:53 schrieb Willy Tarreau: >> diff --git a/src/vars.c b/src/vars.c >> index 477a14632..d32310270 100644 >> --- a/src/vars.c >> +++ b/src/vars.c >> @@ -510,6 +510,7 @@ int vars_check_arg(struct arg *arg, char **err) >> err); >> if (!name) >>

Re: [PATCH] BUG/MINOR: vars: Fix memory leak in vars_check_arg

2019-05-10 Thread Willy Tarreau
On Fri, May 10, 2019 at 05:50:50PM +0200, Tim Duesterhus wrote: > vars_check_arg previously leaked the string containing the variable > name: (...) Thanks Tim! I'm going to apply a minor change : > diff --git a/src/vars.c b/src/vars.c > index 477a14632..d32310270 100644 > --- a/src/vars.c > +++

[PATCH] BUG/MINOR: vars: Fix memory leak in vars_check_arg

2019-05-10 Thread Tim Duesterhus
vars_check_arg previously leaked the string containing the variable name: Consider this config: frontend fe1 mode http bind :8080 http-request set-header X %[var(txn.host)] Starting HAProxy and immediately stopping it by sending a SIGINT makes Valgrind report this