Re: [EXTERNAL] Re: [PATCH] CLEANUP: http_fetch: Use ist helpers in smp_fetch_http_auth_bearer()

2021-10-29 Thread Willy Tarreau
On Fri, Oct 29, 2021 at 05:20:23PM +0200, Remi Tricot-Le Breton wrote: > > > Rémi, am I missing something or is it just that this code snippet indeed > > > has a bug that was not spotted by the regtests (which I'm fine with, > > > they're regression tests, not unit tests seeking 100% coverage) ? >

Re: [EXTERNAL] Re: [PATCH] CLEANUP: http_fetch: Use ist helpers in smp_fetch_http_auth_bearer()

2021-10-29 Thread Remi Tricot-Le Breton
Hello Tim, On 29/10/2021 16:57, Tim Düsterhus wrote: Willy, On 10/29/21 8:50 AM, Willy Tarreau wrote: I don't see how this can ever match:    - we search for a space in the first characters starting at    - if we find one such space, we check if these characters are exactly equal to

Re: [PATCH] CLEANUP: http_fetch: Use ist helpers in smp_fetch_http_auth_bearer()

2021-10-29 Thread Tim Düsterhus
Willy, On 10/29/21 8:50 AM, Willy Tarreau wrote: I don't see how this can ever match: - we search for a space in the first characters starting at - if we find one such space, we check if these characters are exactly equal to the string "Bearer" (modulo the case), and if so we take

Re: [PATCH] CLEANUP: http_fetch: Use ist helpers in smp_fetch_http_auth_bearer()

2021-10-29 Thread Willy Tarreau
On Thu, Oct 14, 2021 at 07:48:08PM +0200, Tim Duesterhus wrote: > Remi, > > please find a suggested cleanup for your JWT patch series. I think that > using the ist functions results in easier to understand code, because you > don't need to manually calculate lengths and offsets. > > Apply with

Re: [PATCH] CLEANUP: http_fetch: Use ist helpers in smp_fetch_http_auth_bearer()

2021-10-28 Thread Tim Düsterhus
Willy, On 10/14/21 7:48 PM, Tim Duesterhus wrote: please find a suggested cleanup for your JWT patch series. I think that using the ist functions results in easier to understand code, because you don't need to manually calculate lengths and offsets. Here's another patch that did not receive

[PATCH] CLEANUP: http_fetch: Use ist helpers in smp_fetch_http_auth_bearer()

2021-10-14 Thread Tim Duesterhus
Remi, please find a suggested cleanup for your JWT patch series. I think that using the ist functions results in easier to understand code, because you don't need to manually calculate lengths and offsets. Apply with `git am --scissors` to automatically cut the commit message. -- >8 -- Using